Skip to content
  1. Jul 23, 2023
    • Linus Torvalds's avatar
      Merge tag 'block-6.5-2023-07-21' of git://git.kernel.dk/linux · f036d67c
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - Fix for loop regressions (Mauricio)
      
       - Fix a potential stall with batched wakeups in sbitmap (David)
      
       - Fix for stall with recursive plug flushes (Ross)
      
       - Skip accounting of empty requests for blk-iocost (Chengming)
      
       - Remove a dead field in struct blk_mq_hw_ctx (Chengming)
      
      * tag 'block-6.5-2023-07-21' of git://git.kernel.dk/linux:
        loop: do not enforce max_loop hard limit by (new) default
        loop: deprecate autoloading callback loop_probe()
        sbitmap: fix batching wakeup
        blk-iocost: skip empty flush bio in iocost
        blk-mq: delete dead struct blk_mq_hw_ctx->queued field
        blk-mq: Fix stall due to recursive flush plug
      f036d67c
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.5-2023-07-21' of git://git.kernel.dk/linux · bdd1d82e
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - Fix for io-wq not always honoring REQ_F_NOWAIT, if it was set and
         punted directly (eg via DRAIN) (me)
      
       - Capability check fix (Ondrej)
      
       - Regression fix for the mmap changes that went into 6.4, which
         apparently broke IA64 (Helge)
      
      * tag 'io_uring-6.5-2023-07-21' of git://git.kernel.dk/linux:
        ia64: mmap: Consider pgoff when searching for free mapping
        io_uring: Fix io_uring mmap() by using architecture-provided get_unmapped_area()
        io_uring: treat -EAGAIN for REQ_F_NOWAIT as final for io-wq
        io_uring: don't audit the capability check in io_uring_create()
      bdd1d82e
    • Linus Torvalds's avatar
      Merge tag 'devicetree-fixes-for-6.5-1' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux · 725d444d
      Linus Torvalds authored
      Pull devicetree fixes from Rob Herring:
      
       - Fix moortec,mr75203 schema usage of 'multipleOf' keyword
      
       - Fix regression in systems depending on "of-display" device name
      
       - Build fix for s390 with CONFIG_PCI=n and OF_EARLY_FLATTREE=y
      
       - Drop two obsolete serial .txt bindings
      
      * tag 'devicetree-fixes-for-6.5-1' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux:
        dt-bindings: serial: Remove obsolete nxp,lpc1850-uart.txt
        dt-bindings: serial: Remove obsolete cavium-uart.txt
        dt-bindings: hwmon: moortec,mr75203: fix multipleOf for coefficients
        of: Preserve "of-display" device name for compatibility
        of: make OF_EARLY_FLATTREE depend on HAS_IOMEM
      725d444d
    • Linus Torvalds's avatar
      Merge tag 'regmap-fix-v6.5-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap · 39b14286
      Linus Torvalds authored
      Pull regmap fixes from Mark Brown:
       "Three fixes here:
      
         - The issues with accounting for register and padding length on raw
           buses turn out to be quite widespread in custom buses.
      
           In order to avoid disturbing anything drop the initial fixes and
           fall back to a point fix in the SMBus code where the issue was
           originally noticed, a more substantial refactoring of the API which
           ensures that all buses make the same assumptions will follow.
      
         - The generic regcache code had been forcing on async I/O which did
           not work with the new maple tree sync code when used with SPI.
      
           Since that was mainly for the rbtree cache and the assumptions
           about hardware that drove the choice are probably not true any more
           fix this by pushing the enablement of async down into the rbtree
           code.
      
           This probably also makes cache syncs for systems faster though it's
           not the point.
      
         - The test code was triggering use of the rbtree and maple tree
           caches with dynamic allocation of nodes since all the testing is
           with RAM backed caches with no I/O performance issues.
      
           Just disable the locking in the tests to avoid triggering warnings
           when allocation debugging is turned on, it's not really what's
           being tested"
      
      * tag 'regmap-fix-v6.5-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
        regmap: Disable locking for RBTREE and MAPLE unit tests
        regcache: Push async I/O request down into the rbtree cache
        regmap: Account for register length in SMBus I/O limits
        regmap: Drop initial version of maximum transfer length fixes
      39b14286
    • Linus Torvalds's avatar
      Merge tag 'gpio-fixes-for-v6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux · c0842db5
      Linus Torvalds authored
      Pull gpio fixes from Bartosz Golaszewski:
      
       - fix initial value handling for output-only pins in gpio-tps68470
      
       - fix two resource leaks in gpio-mvebu
      
      * tag 'gpio-fixes-for-v6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux:
        gpio: mvebu: fix irq domain leak
        gpio: mvebu: Make use of devm_pwmchip_add
        gpio: tps68470: Make tps68470_gpio_output() always set the initial value
      c0842db5
  2. Jul 22, 2023
    • Rob Herring's avatar
      dt-bindings: serial: Remove obsolete nxp,lpc1850-uart.txt · ffc59c64
      Rob Herring authored
      
      
      nxp,lpc1850-uart.txt binding is already covered by 8250.yaml, so remove
      it.
      
      Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
      Link: https://lore.kernel.org/r/20230707221607.1064888-1-robh@kernel.org
      
      
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      ffc59c64
    • Rob Herring's avatar
      dt-bindings: serial: Remove obsolete cavium-uart.txt · 5921181c
      Rob Herring authored
      
      
      cavium-uart.txt binding is already covered by 8250.yaml, so remove it.
      
      Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
      Link: https://lore.kernel.org/r/20230707221602.1063972-1-robh@kernel.org
      
      
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      5921181c
    • Mauricio Faria de Oliveira's avatar
      loop: do not enforce max_loop hard limit by (new) default · bb5faa99
      Mauricio Faria de Oliveira authored
      Problem:
      
      The max_loop parameter is used for 2 different purposes:
      
      1) initial number of loop devices to pre-create on init
      2) maximum number of loop devices to add on access/open()
      
      Historically, its default value (zero) caused 1) to create non-zero
      number of devices (CONFIG_BLK_DEV_LOOP_MIN_COUNT), and no hard limit on
      2) to add devices with autoloading.
      
      However, the default value changed in commit 85c50197 ("loop: Fix
      the max_loop commandline argument treatment when it is set to 0") to
      CONFIG_BLK_DEV_LOOP_MIN_COUNT, for max_loop=0 not to pre-create devices.
      
      That does improve 1), but unfortunately it breaks 2), as the default
      behavior changed from no-limit to hard-limit.
      
      Example:
      
      For example, this userspace code broke for N >= CONFIG, if the user
      relied on the default value 0 for max_loop:
      
          mknod("/dev/loopN");
          open("/dev/loopN");  // now fails with ENXIO
      
      Though affected users may "fix" it with (loop.)max_loop=0, this means to
      require a kernel parameter change on stable kernel update (that commit
      Fixes: an old commit in stable).
      
      Solution:
      
      The original semantics for the default value in 2) can be applied if the
      parameter is not set (ie, default behavior).
      
      This still keeps the intended function in 1) and 2) if set, and that
      commit's intended improvement in 1) if max_loop=0.
      
      Before 85c50197:
        - default:     1) CONFIG devices   2) no limit
        - max_loop=0:  1) CONFIG devices   2) no limit
        - max_loop=X:  1) X devices        2) X limit
      
      After 85c50197:
        - default:     1) CONFIG devices   2) CONFIG limit (*)
        - max_loop=0:  1) 0 devices (*)    2) no limit
        - max_loop=X:  1) X devices        2) X limit
      
      This commit:
        - default:     1) CONFIG devices   2) no limit (*)
        - max_loop=0:  1) 0 devices        2) no limit
        - max_loop=X:  1) X devices        2) X limit
      
      Future:
      
      The issue/regression from that commit only affects code under the
      CONFIG_BLOCK_LEGACY_AUTOLOAD deprecation guard, thus the fix too is
      contained under it.
      
      Once that deprecated functionality/code is removed, the purpose 2) of
      max_loop (hard limit) is no longer in use, so the module parameter
      description can be changed then.
      
      Tests:
      
      Linux 6.4-rc7
      CONFIG_BLK_DEV_LOOP_MIN_COUNT=8
      CONFIG_BLOCK_LEGACY_AUTOLOAD=y
      
      - default (original)
      
      	# ls -1 /dev/loop*
      	/dev/loop-control
      	/dev/loop0
      	...
      	/dev/loop7
      
      	# ./test-loop
      	open: /dev/loop8: No such device or address
      
      - default (patched)
      
      	# ls -1 /dev/loop*
      	/dev/loop-control
      	/dev/loop0
      	...
      	/dev/loop7
      
      	# ./test-loop
      	#
      
      - max_loop=0 (original & patched):
      
      	# ls -1 /dev/loop*
      	/dev/loop-control
      
      	# ./test-loop
      	#
      
      - max_loop=8 (original & patched):
      
      	# ls -1 /dev/loop*
      	/dev/loop-control
      	/dev/loop0
      	...
      	/dev/loop7
      
      	# ./test-loop
      	open: /dev/loop8: No such device or address
      
      - max_loop=0 (patched; CONFIG_BLOCK_LEGACY_AUTOLOAD is not set)
      
      	# ls -1 /dev/loop*
      	/dev/loop-control
      
      	# ./test-loop
      	open: /dev/loop8: No such device or address
      
      Fixes: 85c50197
      
       ("loop: Fix the max_loop commandline argument treatment when it is set to 0")
      Signed-off-by: default avatarMauricio Faria de Oliveira <mfo@canonical.com>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      Link: https://lore.kernel.org/r/20230720143033.841001-3-mfo@canonical.com
      
      
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      bb5faa99
    • Mauricio Faria de Oliveira's avatar
      loop: deprecate autoloading callback loop_probe() · 23881aec
      Mauricio Faria de Oliveira authored
      The 'probe' callback in __register_blkdev() is only used under the
      CONFIG_BLOCK_LEGACY_AUTOLOAD deprecation guard.
      
      The loop_probe() function is only used for that callback, so guard it
      too, accordingly.
      
      See commit fbdee71b
      
       ("block: deprecate autoloading based on dev_t").
      
      Signed-off-by: default avatarMauricio Faria de Oliveira <mfo@canonical.com>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      Link: https://lore.kernel.org/r/20230720143033.841001-2-mfo@canonical.com
      
      
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      23881aec
    • David Jeffery's avatar
      sbitmap: fix batching wakeup · 10639737
      David Jeffery authored
      
      
      Current code supposes that it is enough to provide forward progress by
      just waking up one wait queue after one completion batch is done.
      
      Unfortunately this way isn't enough, cause waiter can be added to wait
      queue just after it is woken up.
      
      Follows one example(64 depth, wake_batch is 8)
      
      1) all 64 tags are active
      
      2) in each wait queue, there is only one single waiter
      
      3) each time one completion batch(8 completions) wakes up just one
         waiter in each wait queue, then immediately one new sleeper is added
         to this wait queue
      
      4) after 64 completions, 8 waiters are wakeup, and there are still 8
         waiters in each wait queue
      
      5) after another 8 active tags are completed, only one waiter can be
         wakeup, and the other 7 can't be waken up anymore.
      
      Turns out it isn't easy to fix this problem, so simply wakeup enough
      waiters for single batch.
      
      Cc: Kemeng Shi <shikemeng@huaweicloud.com>
      Cc: Chengming Zhou <zhouchengming@bytedance.com>
      Cc: Jan Kara <jack@suse.cz>
      Signed-off-by: default avatarDavid Jeffery <djeffery@redhat.com>
      Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
      Reviewed-by: default avatarGabriel Krisman Bertazi <krisman@suse.de>
      Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
      Link: https://lore.kernel.org/r/20230721095715.232728-1-ming.lei@redhat.com
      
      
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      10639737
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · d192f538
      Linus Torvalds authored
      Pull arm64 fixes from Will Deacon:
       "I've picked up a handful of arm64 fixes while Catalin's been away, so
        here they are. Below is the usual summary, but we have basically have
        two cleanups, a fix for an SME crash and a fix for hibernation:
      
         - Fix saving of SME state after SVE vector length is changed
      
         - Fix sparse warnings for missing vDSO function prototypes
      
         - Fix hibernation resume path when kfence is enabled
      
         - Fix field names for the HFGxTR_EL2 register"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64/fpsimd: Ensure SME storage is allocated after SVE VL changes
        arm64: vdso: Clear common make C=2 warnings
        arm64: mm: Make hibernation aware of KFENCE
        arm64: Fix HFGxTR_EL2 field naming
      d192f538
    • Linus Torvalds's avatar
      Merge tag 'pm-6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 892d7c1b
      Linus Torvalds authored
      Pull power management fixes from Rafael Wysocki:
       "Revert three recent intel_idle commits that introduced a functional
        issue, included a coding mistake and have been questioned at the
        design level"
      
      * tag 'pm-6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        Revert "intel_idle: Add support for using intel_idle in a VM guest using just hlt"
        Revert "intel_idle: Add a "Long HLT" C1 state for the VM guest mode"
        Revert "intel_idle: Add __init annotation to matchup_vm_state_with_baremetal()"
      892d7c1b
    • Linus Torvalds's avatar
      Merge tag 'sound-6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · 3c05547a
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "A pile of fixes that have been gathered since the previous pull. Most
        of changes are device-specific, and nothing looks too scary.
      
         - A memory leak fix in ALSA sequencer code in 6.5-rc
      
         - Many fixes for ASoC Qualcomm CODEC drivers, covering SoundWire
           probe problems
      
         - A series of ASoC AMD fixes
      
         - A few fixes and cleanups of selftest stuff
      
         - HD-audio codec fixes and quirks for Clevo, HP, Lenovo, Dell"
      
      * tag 'sound-6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (52 commits)
        ALSA: hda/realtek: Add support for DELL Oasis 13/14/16 laptops
        ALSA: hda/realtek: Fix generic fixup definition for cs35l41 amp
        ALSA: hda/realtek: Enable Mute LED on HP Laptop 15s-eq2xxx
        selftests: ALSA: Add test-pcmtest-driver to .gitignore
        ALSA: hda/realtek: Add quirk for Clevo NS70AU
        ASoC: fsl_sai: Disable bit clock with transmitter
        ALSA: seq: Fix memory leak at error path in snd_seq_create_port()
        ASoC: SOF: ipc3-dtrace: uninitialized data in dfsentry_trace_filter_write()
        ASoC: cs42l51: fix driver to properly autoload with automatic module loading
        MAINTAINERS: Redo addition of ssm3515 to APPLE SOUND
        ASoC: rt5640: Fix the issue of speaker noise
        ALSA: hda/realtek - remove 3k pull low procedure
        selftests: ALSA: Fix fclose on an already fclosed file pointer
        ALSA: pcmtest: Don't use static storage to track per device data
        ALSA: pcmtest: Convert to platform remove callback returning void
        ASoC: dt-bindings: audio-graph-card2: Drop incomplete example
        ASoC: dt-bindings: Update maintainer email id
        ASoC: amd: ps: Fix extraneous error messages
        ASoC: fsl_sai: Revert "ASoC: fsl_sai: Enable MCTL_MCLK_EN bit for master mode"
        ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ
        ...
      3c05547a
    • Linus Torvalds's avatar
      Merge tag 'fbdev-for-6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev · 55c225fb
      Linus Torvalds authored
      Pull fbdev fixes and cleanups from Helge Deller:
       "Just the usual bunch of code cleanups in various drivers, this time
        mostly in vgacon and imxfb:
      
         - Code cleanup in vgacon (Jiri Slaby)
      
         - Explicitly include correct DT includes (Rob Herring)
      
         - imxfb code cleanup (Yangtao Li, Martin Kaiser)
      
         - kyrofb: make arrays const and smaller (Colin Ian King)
      
         - ep93xx-fb: return value check fix (Yuanjun Gong)
      
         - au1200fb: add missing IRQ check (Zhang Shurong)"
      
      * tag 'fbdev-for-6.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev:
        fbdev: Explicitly include correct DT includes
        fbdev: ep93xx-fb: fix return value check in ep93xxfb_probe
        fbdev: au1200fb: Fix missing IRQ check in au1200fb_drv_probe
        fbdev: kyro: make some const read-only arrays static and reduce type size
        fbcon: remove unused display (p) from fbcon_redraw()
        sticon: make sticon_set_def_font() void and remove op parameter
        vgacon: cache vc_cell_height in vgacon_cursor()
        vgacon: let vgacon_doresize() return void
        vgacon: remove unused xpos from vgacon_set_cursor_size()
        vgacon: remove unneeded forward declarations
        vgacon: switch vgacon_scrolldelta() and vgacon_restore_screen()
        fbdev: imxfb: remove unneeded labels
        fbdev: imxfb: Convert to devm_platform_ioremap_resource()
        fbdev: imxfb: Convert to devm_kmalloc_array()
        fbdev: imxfb: Removed unneeded release_mem_region
        fbdev: imxfb: switch to DEFINE_SIMPLE_DEV_PM_OPS
        fbdev: imxfb: warn about invalid left/right margin
      55c225fb
    • Daniel Vetter's avatar
      drm/atomic: Fix potential use-after-free in nonblocking commits · 4e076c73
      Daniel Vetter authored
      
      
      This requires a bit of background.  Properly done a modeset driver's
      unload/remove sequence should be
      
      	drm_dev_unplug();
      	drm_atomic_helper_shutdown();
      	drm_dev_put();
      
      The trouble is that the drm_dev_unplugged() checks are by design racy,
      they do not synchronize against all outstanding ioctl.  This is because
      those ioctl could block forever (both for modeset and for driver
      specific ioctls), leading to deadlocks in hotunplug.  Instead the code
      sections that touch the hardware need to be annotated with
      drm_dev_enter/exit, to avoid accessing hardware resources after the
      unload/remove has finished.
      
      To avoid use-after-free issues all the involved userspace visible
      objects are supposed to hold a reference on the underlying drm_device,
      like drm_file does.
      
      The issue now is that we missed one, the atomic modeset ioctl can be run
      in a nonblocking fashion, and in that case it cannot rely on the implied
      drm_device reference provided by the ioctl calling context.  This can
      result in a use-after-free if an nonblocking atomic commit is carefully
      raced against a driver unload.
      
      Fix this by unconditionally grabbing a drm_device reference for any
      drm_atomic_state structures.  Strictly speaking this isn't required for
      blocking commits and TEST_ONLY calls, but it's the simpler approach.
      
      Thanks to shanzhulig for the initial idea of grabbing an unconditional
      reference, I just added comments, a condensed commit message and fixed a
      minor potential issue in where exactly we drop the final reference.
      
      Reported-by: default avatarshanzhulig <shanzhulig@gmail.com>
      Suggested-by: default avatarshanzhulig <shanzhulig@gmail.com>
      Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Thomas Zimmermann <tzimmermann@suse.de>
      Cc: David Airlie <airlied@gmail.com>
      Cc: stable@kernel.org
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      4e076c73
  3. Jul 21, 2023