Skip to content
  1. Feb 04, 2009
  2. Feb 03, 2009
    • Linus Torvalds's avatar
      Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev · 52a84ec2
      Linus Torvalds authored
      * 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev:
        libata: implement HORKAGE_1_5_GBPS and apply it to WD My Book
        libata: add no penalty retry request for EH device handling routines
        libata: improve probe failure handling
        libata: add @spd_limit to sata_down_spd_limit()
        libata: clear dev->ering in smarter way
        libata: check onlineness before using SPD in sata_down_spd_limit()
        libata: move ata_dev_disable() to libata-eh.c
        libata: fix EH device failure handling
        sata_nv: ck804 has borked hardreset too
        ide/libata: fix ata_id_is_cfa() (take 4)
        libata: fix kernel-doc warnings
        ahci: add a module parameter to ignore the SSS flags for async scanning
        sata_mv: Fix chip type for Hightpoint RocketRaid 1740/1742
        [libata] sata_sil: Fix compilation error with libata debugging enabled
      52a84ec2
    • Tejun Heo's avatar
      libata: implement HORKAGE_1_5_GBPS and apply it to WD My Book · 9062712f
      Tejun Heo authored
      
      
      3Gbps is often much more prone to transmission failures.  It's usually
      okay to let EH handle speed down after transmission failures but some
      WD My Book drives completely shutdown after certain transmission
      failures and after it only power cycling can revive them.  Combined
      with the fact that external drives often end up with cable assembly
      which is longer than usual and more likely to have intervening gender,
      this makes these drives very likely to shutdown under certain
      configurations virtually rendering them unusable.
      
      This patch implements HOARKGE_1_5_GBPS and applies it to WD My Book
      such that 1.5Gbps is forced once the device is identified.
      
      Please take a look at the following bz for related reports.
      
        http://bugzilla.kernel.org/show_bug.cgi?id=9913
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      9062712f
    • Tejun Heo's avatar
      libata: add no penalty retry request for EH device handling routines · cf9a590a
      Tejun Heo authored
      
      
      Let -EAGAIN from EH device handling routines trigger EH retry without
      consuming its tries count.  This will be used to implement link SPD
      horkage which requires hardreset to adjust SPD without affecting other
      EH decisions.  As it bypasses the forward progress guarantee provided
      by the tries count, the requester is responsible for ensuring forward
      progress.
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      cf9a590a
    • Tejun Heo's avatar
      libata: improve probe failure handling · c2c7a89c
      Tejun Heo authored
      
      
      When link is flaky at high speed, it isn't uncommon for a device to
      repeatedly fail probing sequence early after successfully negotiating
      high link speed.  This often leads to consecutive hotplug events
      without successful probing.
      
      This patch improves libata EH such that it remembers probing trials
      and if there have been more than two unsuccessful trials in the past
      60 seconds, slows down link speed to 1.5Gbps.
      
      As link speed negotiation is the duty of the PHY layer proper, the
      goal of this fallback mechanism is to provide the last resort when
      everything else fails, which unfortunately happens not too
      infrequently, so no fancy 6->3->1.5 speeding down or highest
      successful transmission speed seen kind of logics (yet).
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      c2c7a89c
    • Tejun Heo's avatar
      libata: add @spd_limit to sata_down_spd_limit() · a07d499b
      Tejun Heo authored
      
      
      Add @spd_limit to sata_down_spd_limit() so that the caller can specify
      the SPD limit it wants.  This parameter doesn't get in the way even
      when it's too low.  The closest possible limit is applied.
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      a07d499b