Skip to content
  1. Jul 13, 2013
  2. Jul 08, 2013
  3. Jul 07, 2013
  4. Jul 05, 2013
    • Al Viro's avatar
      lustre: kill the pointless wrapper · 193deee1
      Al Viro authored
      
      
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      193deee1
    • Al Viro's avatar
      helper for reading ->d_count · 84d08fa8
      Al Viro authored
      
      
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      84d08fa8
    • Linus Torvalds's avatar
      Merge tag 'devicetree-for-linus' of git://git.secretlab.ca/git/linux · 74b9272b
      Linus Torvalds authored
      Pull device tree updates from Grant Likely:
       "This branch contains the following changes:
         - Removal of CONFIG_OF_DEVICE, it is always enabled by CONFIG_OF
         - Remove #ifdef from linux/of_platform.h to increase compiler syntax
           coverage
         - Bug fix for address decoding on Bimini and js2x powerpc platforms.
         - miscellaneous binding changes
      
        One note on the above.  The binding changes going in from all kinds of
        different trees has gotten rather out of hand.  I picked up some
        during this cycle, but even going though my tree isn't a great fit.
      
        Ian Campbell has prototyped splitting the bindings and .dtb files into
        a separate repository.  The plan is to migrate to using that sometime
        in the next few kernel releases which should get rid of a lot of the
        churn on binding docs and .dts files"
      
      * tag 'devicetree-for-linus' of git://git.secretlab.ca/git/linux:
        of: Fix address decoding on Bimini and js2x machines
        of: remove CONFIG_OF_DEVICE
        usb: chipidea: depend on CONFIG_OF instead of CONFIG_OF_DEVICE
        of: remove of_platform_driver
        ibmebus: convert of_platform_driver to platform_driver
        driver core: move to_platform_driver to platform_device.h
        mfd: DT bindings for the palmas family MFD
        ARM: dts: omap3-devkit8000: fix NAND memory binding
        of/base: fix typos
        of: remove #ifdef from linux/of_platform.h
      74b9272b
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input · f5b63ac0
      Linus Torvalds authored
      Pull input updates from Dmitry Torokhov:
       "First round of updates for the input subsystem.
      
        You will get a new touchsreen driver for Cypress 4th generation
        devices, a driver for a special controller implementing PS/2 protocol
        in OLPC devices, and a driver for power key for SiRFprimaII PWRC.
      
        HID and bcm5497 now support for the 2013 MacBook Air.
      
        EVIOCGKEY and the rest of evdev ioctls now flush events of matching
        type from the client's event queue so that clients can be sure any
        events received after issuing EVIOCG* ioctl are new events.
      
        And a host of cleanups and improvements in other drivers"
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input: (87 commits)
        Input: cyttsp4 - kfree xfer_buf on error path in probe()
        Input: tps6507x-ts - select INPUT_POLLDEV
        Input: bcm5974 - add support for the 2013 MacBook Air
        HID: apple: Add support for the 2013 Macbook Air
        Input: cyttsp4 - leak on error path in probe()
        Input: cyttsp4 - silence NULL dereference warning
        Input: cyttsp4 - silence shift wrap warning
        Input: tps6507x-ts - convert to polled input device infrastructure
        ARM: davinci: da850-evm: remove vref from touchscreen platform data
        Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices
        Input: cyttsp4 - I2C driver for Cypress TMA4XX touchscreen devices
        Input: cyttsp4 - add core driver for Cypress TMA4XX touchscreen devices
        Input: cyttsp - I2C driver split into two modules
        Input: add OLPC AP-SP driver
        Input: nspire-keypad - remove redundant dev_err call in nspire_keypad_probe()
        Input: tps6507x-ts - remove vref from platform data
        Input: tps6507x-ts - use bool for booleans
        Input: tps6507x-ts - remove bogus unreachable code
        Input: samsung-keypad - let device core setup the default pin configuration
        Input: wacom_i2c - implement hovering capability
        ...
      f5b63ac0
    • Ferruh Yigit's avatar
      Input: cyttsp4 - kfree xfer_buf on error path in probe() · 57961e3b
      Ferruh Yigit authored
      
      
      If probe() fails after cd->xfer_buf allocated, it will not freed.
      Added kfree(cd->xfer_buf) with and error label.
      
      Signed-off-by: default avatarFerruh Yigit <fery@cypress.com>
      Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
      57961e3b
    • Linus Torvalds's avatar
      Merge branch 'i2c/for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · 98f486f1
      Linus Torvalds authored
      Pull i2c updates from Wolfram Sang:
       - new drivers: Kontron PLD, Wondermedia VT
       - mv64xxx driver gained sun4i support and a bigger cleanup
       - duplicate driver 'intel-mid' removed
       - added generic device tree binding for sda holding time (and
         designware driver already uses it)
       - we tried to allow driver probing with only device tree and no i2c
         ids, but I had to revert it because of side effects.  Needs some
         rethinking.
       - driver bugfixes, cleanups...
      
      * 'i2c/for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: (34 commits)
        i2c-designware: use div_u64 to fix link
        i2c: Kontron PLD i2c bus driver
        i2c: iop3xxx: fix build failure after waitqueue changes
        i2c-designware: make SDA hold time configurable
        i2c: mv64xxx: Set bus frequency to 100kHz if clock-frequency is not provided
        i2c: imx: allow autoloading on dt ids
        i2c: mv64xxx: Fix transfer error code
        i2c: i801: SMBus patch for Intel Coleto Creek DeviceIDs
        i2c: omap: correct usage of the interrupt enable register
        i2c-pxa: prepare clock before use
        Revert "i2c: core: make it possible to match a pure device tree driver"
        i2c: nomadik: allocate adapter number dynamically
        i2c: nomadik: support elder Nomadiks
        i2c: mv64xxx: Add Allwinner sun4i compatible
        i2c: mv64xxx: make the registers offset configurable
        i2c: mv64xxx: Add macros to access parts of registers
        i2c: vt8500: Add support for I2C bus on Wondermedia SoCs
        i2c: designware: fix race between subsequent xfers
        i2c: bfin-twi: Read and write the FIFO in loop
        i2c: core: make it possible to match a pure device tree driver
        ...
      98f486f1
    • Linus Torvalds's avatar
      Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 84cbd722
      Linus Torvalds authored
      Pull first round of SCSI updates from James Bottomley:
       "The patch set is mostly driver updates (usf, zfcp, lpfc, mpt2sas,
        megaraid_sas, bfa, ipr) and a few bug fixes.  Also of note is that the
        Buslogic driver has been rewritten to a better coding style and 64 bit
        support added.  We also removed the libsas limitation on 16 bytes for
        the command size (currently no drivers make use of this)"
      
      * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (101 commits)
        [SCSI] megaraid: minor cut and paste error fixed.
        [SCSI] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call
        [SCSI] ufs: fix register address in UIC error interrupt handling
        [SCSI] ufshcd-pltfrm: add missing empty slot in ufs_of_match[]
        [SCSI] ufs: use devres functions for ufshcd
        [SCSI] ufs: Fix the response UPIU length setting
        [SCSI] ufs: rework link start-up process
        [SCSI] ufs: remove version check before IS reg clear
        [SCSI] ufs: amend interrupt configuration
        [SCSI] ufs: wrap the i/o access operations
        [SCSI] storvsc: Update the storage protocol to win8 level
        [SCSI] storvsc: Increase the value of scsi timeout for storvsc devices
        [SCSI] MAINTAINERS: Add myself as the maintainer for BusLogic SCSI driver
        [SCSI] BusLogic: Port driver to 64-bit.
        [SCSI] BusLogic: Fix style issues
        [SCSI] libiscsi: Added new boot entries in the session sysfs
        [SCSI] aacraid: Fix for arrays are going offline in the system. System hangs
        [SCSI] ipr: IOA Status Code(IOASC) update
        [SCSI] sd: Update WRITE SAME heuristics
        [SCSI] fnic: potential dead lock in fnic_is_abts_pending()
        ...
      84cbd722
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial · 80cc38b1
      Linus Torvalds authored
      Pull trivial tree updates from Jiri Kosina:
       "The usual stuff from trivial tree"
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (34 commits)
        treewide: relase -> release
        Documentation/cgroups/memory.txt: fix stat file documentation
        sysctl/net.txt: delete reference to obsolete 2.4.x kernel
        spinlock_api_smp.h: fix preprocessor comments
        treewide: Fix typo in printk
        doc: device tree: clarify stuff in usage-model.txt.
        open firmware: "/aliasas" -> "/aliases"
        md: bcache: Fixed a typo with the word 'arithmetic'
        irq/generic-chip: fix a few kernel-doc entries
        frv: Convert use of typedef ctl_table to struct ctl_table
        sgi: xpc: Convert use of typedef ctl_table to struct ctl_table
        doc: clk: Fix incorrect wording
        Documentation/arm/IXP4xx fix a typo
        Documentation/networking/ieee802154 fix a typo
        Documentation/DocBook/media/v4l fix a typo
        Documentation/video4linux/si476x.t...
      80cc38b1
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid · 3366dd9f
      Linus Torvalds authored
      Pull HID updates from Jiri Kosina:
       - HID battery handling cleanup by David Herrmann
       - ELO 4000/4500 driver, which has been finally ported to be proper HID
         driver by Jiri Slaby
       - ps3remote driver functionality is now provided by generic sony
         driver, by Jiri Kosina
       - PS2/3 Buzz controllers support, by Colin Leitner
       - rework of wiimote driver including full extensions hotpluggin
         support, sub-device modularization and speaker support by David
         Herrmann
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid: (55 commits)
        HID: wacom: Intuos4 battery charging changes
        HID: i2c-hid: support sending HID output reports using the output register
        HID: kye: Add report fixup for Genius Gila Gaming mouse
        HID: wiimote: support Nintendo Wii U Pro Controller
        Input: make gamepad API keycodes more clear
        input: document gamepad API and add extra keycodes
        HID: explain out-of-range check better
        HID: fix false positive out of range values
        HID: wiimote: fix coccinelle warnings
        HID: roccat: check cdev_add return value
        HID: fold ps3remote driver into generic Sony driver
        HID: hyperv: convert alloc+memcpy to memdup
        HID: core: fix reporting of raw events
        HID: wiimote: discard invalid EXT data reports
        HID: wiimote: fix classic controller parsing
        HID: wiimote: init EXT/MP during device detection
        HID: wiimote: fix DRM debug-attr to correctly parse input
        HID: wiimote: add MP quirks
        HID: wiimote: remove old static extension support
        HID: wiimote: add "bboard_calib" attribute
        ...
      3366dd9f
    • Linus Torvalds's avatar
      Merge tag 'md-3.11' of git://neil.brown.name/md · 697a067f
      Linus Torvalds authored
      Pull md updates from NeilBrown:
       "Mostly fixes, with a few minor features (eg 'last_sync_action' sysfs
        file)
      
        A couple marked for -stable including one recent bug which causes a
        RAID10 reshape to complete without moving any data :-(
      
        A couple more bugfixes (at least) to come, but haven't confirmed the
        right solution yet."
      
      * tag 'md-3.11' of git://neil.brown.name/md:
        md/raid10: fix bug which causes all RAID10 reshapes to move no data.
        md/raid5: allow 5-device RAID6 to be reshaped to 4-device.
        md/raid10: fix two bugs affecting RAID10 reshape.
        md: remove doubled description for sync_max, merging it within sync_min/sync_max
        MD: Remember the last sync operation that was performed
        md: fix buglet in RAID5 -> RAID0 conversion.
        md/raid10: check In_sync flag in 'enough()'.
        md/raid10: locking changes for 'enough()'.
        md: replace strict_strto*() with kstrto*()
        md: Wait for md_check_recovery before attempting device removal.
        dm-raid: silence compiler warning on rebuilds_per_group.
        DM RAID: Fix raid_resume not reviving failed devices in all cases
        DM RAID: Break-up untidy function
        DM RAID: Add ability to restore transiently failed devices on resume
      697a067f
    • Linus Torvalds's avatar
      Merge branch 'kconfig-diet' from Dave Hansen · e61aca51
      Linus Torvalds authored
      Merge Kconfig menu diet patches from Dave Hansen:
       "I think the "Kernel Hacking" menu has gotten a bit out of hand.  It is
        over 120 lines long on my system with everything enabled and options
        are scattered around it haphazardly.
      
              http://sr71.net/~dave/linux/kconfig-horror.png
      
        Let's try to introduce some sanity.  This set takes that 120 lines
        down to 55 and makes it vastly easier to find some things.  It's a
        start.
      
        This set stands on its own, but there is plenty of room for follow-up
        patches.  The arch-specific debug options still end up getting stuck
        in the top-level "kernel hacking" menu.  OPTIMIZE_INLINING, for
        instance, could obviously go in to the "compiler options" menu, but
        the fact that it is defined in arch/ in a separate Kconfig file keeps
        it on its own for the moment.
      
        The Signed-off-by's in here look funky.  I changed employers while
        working on this set, so I have signoffs from both email addresses"
      
      * emailed patches from Dave Hansen <dave@sr71.net>:
        hang and lockup detection menu
        kconfig: consolidate printk options
        group locking debugging options
        consolidate compilation option configs
        consolidate runtime testing configs
        order memory debugging Kconfig options
        consolidate per-arch stack overflow debugging options
      e61aca51
    • Dave Hansen's avatar
      hang and lockup detection menu · 92aef8fb
      Dave Hansen authored
      
      
      The hard/softlockup and hung-task entries take up 6 lines
      of screen real-estate when enabled.  I bet folks don't
      mess with these _that_ often, so move them in a group
      down a level.
      
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      92aef8fb
    • Dave Hansen's avatar
      kconfig: consolidate printk options · 604ff0dc
      Dave Hansen authored
      
      
      Same deal, take the printk-related things and hide them in a menu.
      This takes another 4 items out of the top-level menu.
      
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      604ff0dc
    • Dave Hansen's avatar
      group locking debugging options · 9eade16b
      Dave Hansen authored
      Original posting:
      
      	http://lkml.kernel.org/r/20121214184208.D9E5804D@kernel.stglabs.ibm.com
      
      
      
      There are quite a few of these, and we want to make sure that
      there is one-stop-shopping for lock debugging.
      
      Signed-off-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      9eade16b
    • Dave Hansen's avatar
      consolidate compilation option configs · 6dfc0665
      Dave Hansen authored
      Original Post:
      
      	http://lkml.kernel.org/r/20121214184207.6E00DDEC@kernel.stglabs.ibm.com
      
      
      
      Again, trying to come up with some common themes of the stuff in
      the kernel hacking menu...  There are quite a few options to
      tweak compilation in some way, or perform extra compile-time
      checks.  Give them their own menu.
      
      The diff here looks a bit funny... makes it look like I'm
      moving debugfs even though I'm actually moving the options on
      either side of it.
      
      Signed-off-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      6dfc0665
    • Dave Hansen's avatar
      consolidate runtime testing configs · 881c5149
      Dave Hansen authored
      Original posting:
      
      	http://lkml.kernel.org/r/20121214184206.FC11422F@kernel.stglabs.ibm.com
      
      
      
      These runtime tests are great, except that there are a lot of them,
      and they are very rarely needed.  Give them their own menu so that
      only the folks who need them will have to go looking for them.
      
      Note that there are some other runtime tests that are not in here,
      like for RCU or locking.  This menu should only be used for tests
      that do not have a more appropriate home.
      
      Signed-off-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      881c5149
    • Dave Hansen's avatar
      order memory debugging Kconfig options · 0610c8a8
      Dave Hansen authored
      Original posting:
      
      	http://lkml.kernel.org/r/20121214184203.37E6C724@kernel.stglabs.ibm.com
      
      
      
      There are a *LOT* of memory debugging options.  They are just scattered
      all over the "Kernel Hacking" menu.  Sure, "memory debugging" is a very
      vague term and it's going to be hard to make absolute rules about what
      goes in here, but this has to be better than what we had before.
      
      This does, however, leave out the architecture-specific memory
      debugging options (like x86's DEBUG_SET_MODULE_RONX).  There would need
      to be some substantial changes to move those in here.  Kconfig can not
      easily mix arch-specific and generic options together: it really
      requires a file per-architecture, and I think having an
      arch/foo/Kconfig.debug-memory might be taking things a bit too far
      
      Signed-off-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      0610c8a8
    • Dave Hansen's avatar
      consolidate per-arch stack overflow debugging options · d1a1dc0b
      Dave Hansen authored
      Original posting:
      
      	http://lkml.kernel.org/r/20121214184202.F54094D9@kernel.stglabs.ibm.com
      
      
      
      Several architectures have similar stack debugging config options.
      They all pretty much do the same thing, some with slightly
      differing help text.
      
      This patch changes the architectures to instead enable a Kconfig
      boolean, and then use that boolean in the generic Kconfig.debug
      to present the actual menu option.  This removes a bunch of
      duplication and adds consistency across arches.
      
      Signed-off-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
      Reviewed-by: default avatarH. Peter Anvin <hpa@zytor.com>
      Reviewed-by: default avatarJames Hogan <james.hogan@imgtec.com>
      Acked-by: Chris Metcalf <cmetcalf@tilera.com> [for tile]
      Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d1a1dc0b
    • Linus Torvalds's avatar
      Merge branch 'hpfs' from Mikulas Patocka · da67db4e
      Linus Torvalds authored
      Merge hpfs patches from Mikulas Patocka.
      
      * emailed patches from Mikulas Patocka <mpatocka@artax.karlin.mff.cuni.cz>:
        hpfs: implement prefetch to improve performance
        hpfs: use mpage
        hpfs: better test for errors
      da67db4e
    • Mikulas Patocka's avatar
      hpfs: implement prefetch to improve performance · 275f495d
      Mikulas Patocka authored
      
      
      This patch implements prefetch to improve performance.  It helps mostly
      when scanning the bitmaps to calculate free space.
      
      Signed-off-by: default avatarMikulas Patocka <mpatocka@artax.karlin.mff.cuni.cz>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      275f495d
    • Mikulas Patocka's avatar
      hpfs: use mpage · a0c1b759
      Mikulas Patocka authored
      
      
      Use the mpage interface to improve performance.
      
      Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a0c1b759
    • Mikulas Patocka's avatar
      hpfs: better test for errors · 3ebacb05
      Mikulas Patocka authored
      
      
      The test if bitmap access is out of bound could errorneously pass if the
      device size is divisible by 16384 sectors and we are asking for one bitmap
      after the end.
      
      Check for invalid size in the superblock. Invalid size could cause integer
      overflows in the rest of the code.
      
      Signed-off-by: default avatarMikulas Patocka <mpatocka@artax.karlin.mff.cuni.cz>
      Cc: stable@kernel.org
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      3ebacb05
    • Linus Torvalds's avatar
      Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc · 65b97fb7
      Linus Torvalds authored
      Pull powerpc updates from Ben Herrenschmidt:
       "This is the powerpc changes for the 3.11 merge window.  In addition to
        the usual bug fixes and small updates, the main highlights are:
      
         - Support for transparent huge pages by Aneesh Kumar for 64-bit
           server processors.  This allows the use of 16M pages as transparent
           huge pages on kernels compiled with a 64K base page size.
      
         - Base VFIO support for KVM on power by Alexey Kardashevskiy
      
         - Wiring up of our nvram to the pstore infrastructure, including
           putting compressed oopses in there by Aruna Balakrishnaiah
      
         - Move, rework and improve our "EEH" (basically PCI error handling
           and recovery) infrastructure.  It is no longer specific to pseries
           but is now usable by the new "powernv" platform as well (no
           hypervisor) by Gavin Shan.
      
         - I fixed some bugs in our math-emu instruction decoding and made it
           usable to emulate some optional FP instructions on processors with
           hard FP that lack them (such as fsqrt on Freescale embedded
           processors).
      
         - Support for Power8 "Event Based Branch" facility by Michael
           Ellerman.  This facility allows what is basically "userspace
           interrupts" for performance monitor events.
      
         - A bunch of Transactional Memory vs.  Signals bug fixes and HW
           breakpoint/watchpoint fixes by Michael Neuling.
      
        And more ...  I appologize in advance if I've failed to highlight
        something that somebody deemed worth it."
      
      * 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc: (156 commits)
        pstore: Add hsize argument in write_buf call of pstore_ftrace_call
        powerpc/fsl: add MPIC timer wakeup support
        powerpc/mpic: create mpic subsystem object
        powerpc/mpic: add global timer support
        powerpc/mpic: add irq_set_wake support
        powerpc/85xx: enable coreint for all the 64bit boards
        powerpc/8xx: Erroneous double irq_eoi() on CPM IRQ in MPC8xx
        powerpc/fsl: Enable CONFIG_E1000E in mpc85xx_smp_defconfig
        powerpc/mpic: Add get_version API both for internal and external use
        powerpc: Handle both new style and old style reserve maps
        powerpc/hw_brk: Fix off by one error when validating DAWR region end
        powerpc/pseries: Support compression of oops text via pstore
        powerpc/pseries: Re-organise the oops compression code
        pstore: Pass header size in the pstore write callback
        powerpc/powernv: Fix iommu initialization again
        powerpc/pseries: Inform the hypervisor we are using EBB regs
        powerpc/perf: Add power8 EBB support
        powerpc/perf: Core EBB support for 64-bit book3s
        powerpc/perf: Drop MMCRA from thread_struct
        powerpc/perf: Don't enable if we have zero events
        ...
      65b97fb7
  5. Jul 04, 2013