Skip to content
  1. Apr 21, 2020
    • Shengjiu Wang's avatar
      ASoC: fsl_asrc: Move common definition to fsl_asrc_common · be7bd03f
      Shengjiu Wang authored
      
      
      There is a new ASRC included in i.MX serial platform, there
      are some common definition can be shared with each other.
      So move the common definition to a separate header file.
      
      And add fsl_asrc_pair_priv and fsl_asrc_priv for
      the variable specific for the module, which can be used
      internally.
      
      Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
      Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
      Link: https://lore.kernel.org/r/7106993928ea9e9720e6b42ec601871103155b1c.1587038908.git.shengjiu.wang@nxp.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      be7bd03f
    • Shengjiu Wang's avatar
      ASoC: fsl_asrc: Support new property fsl,asrc-format · 4520af41
      Shengjiu Wang authored
      
      
      In order to align with new ESARC, we add new property fsl,asrc-format.
      The fsl,asrc-format can replace the fsl,asrc-width, driver
      can accept format from devicetree, don't need to convert it to
      format through width.
      
      Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
      Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
      Link: https://lore.kernel.org/r/2be9664768f32982ba4f71e49749f7390096ac9f.1587038908.git.shengjiu.wang@nxp.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      4520af41
    • Shengjiu Wang's avatar
      ASoC: fsl-asoc-card: Support new property fsl, asrc-format · 859e3643
      Shengjiu Wang authored
      
      
      In order to align with new ESARC, we add new property fsl,asrc-format.
      The fsl,asrc-format can replace the fsl,asrc-width, driver
      can accept format from devicetree, don't need to convert it to
      format through width.
      
      Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
      Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
      Link: https://lore.kernel.org/r/02f53d5512b9acd3492e2acdd5e0ba3113f18009.1587038908.git.shengjiu.wang@nxp.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      859e3643
    • Shengjiu Wang's avatar
      ASoC: dt-bindings: fsl_asrc: Add new property fsl, asrc-format · b84b4c9a
      Shengjiu Wang authored
      
      
      In order to support new EASRC and simplify the code structure,
      We decide to share the common structure between them. This bring
      a problem that EASRC accept format directly from devicetree, but
      ASRC accept width from devicetree.
      
      In order to align with new ESARC, we add new property fsl,asrc-format.
      The fsl,asrc-format can replace the fsl,asrc-width, then driver
      can accept format from devicetree, don't need to convert it to
      format through width.
      
      Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
      Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
      Acked-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/e7acbde4b26a82b674a4091515a219e09f847eac.1587038908.git.shengjiu.wang@nxp.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      b84b4c9a
    • Shengjiu Wang's avatar
      ASoC: fsl_asrc: rename asrc_priv to asrc · 7470704d
      Shengjiu Wang authored
      
      
      In order to move common structure to fsl_asrc_common.h
      we change the name of asrc_priv to asrc, the asrc_priv
      will be used by new struct fsl_asrc_priv.
      
      Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
      Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
      Link: https://lore.kernel.org/r/722142c2e1b57a95f911db1d42d901b88fc283d6.1587038908.git.shengjiu.wang@nxp.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      7470704d
    • Jason Yan's avatar
      ASoC: wcd934x: remove unneeded semicolon · e48e83d1
      Jason Yan authored
      
      
      Fix the following coccicheck warning:
      
      sound/soc/codecs/wcd934x.c:3621:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:4270:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:4018:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:4043:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:3804:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:3866:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:3596:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:3542:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:3673:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:3723:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:2492:2-3: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:1790:3-4: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:1806:3-4: Unneeded semicolon
      sound/soc/codecs/wcd934x.c:1812:2-3: Unneeded semicolon
      
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Link: https://lore.kernel.org/r/20200420042911.19379-1-yanaijie@huawei.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      e48e83d1
    • Jason Yan's avatar
      ASoC: wcd9335: remove unneeded semicolon · 0eb06746
      Jason Yan authored
      
      
      Fix the following coccicheck warning:
      
      sound/soc/codecs/wcd9335.c:2606:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3619:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:2849:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:2955:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:2988:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3960:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3776:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3924:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3355:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3832:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3079:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3089:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3232:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3878:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3578:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3728:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:1922:3-4: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:1938:3-4: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:1944:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:3144:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:2568:2-3: Unneeded semicolon
      sound/soc/codecs/wcd9335.c:2219:2-3: Unneeded semicolon
      
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Link: https://lore.kernel.org/r/20200420042847.19206-1-yanaijie@huawei.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      0eb06746
    • Jason Yan's avatar
      ASoC: wcd934x: remove unnecessary comparisons to bool · 4f05b5c6
      Jason Yan authored
      
      
      Fix the following coccicheck warning:
      
      sound/soc/codecs/wcd934x.c:3881:8-17: WARNING: Comparison of 0/1 to bool
      variable
      
      Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
      Link: https://lore.kernel.org/r/20200420042833.19116-1-yanaijie@huawei.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      4f05b5c6
    • Mac Chiang's avatar
      ASoC: Intel: boards: split woofer and tweeter support · 629ba12e
      Mac Chiang authored
      
      
      Support Woofer stereo speakers by default and optionally
      Tweeter stereo speakers with a DMI quirk
      
      Signed-off-by: default avatarMac Chiang <mac.chiang@intel.com>
      Link: https://lore.kernel.org/r/1584931764-2778-1-git-send-email-mac.chiang@intel.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      629ba12e
  2. Apr 20, 2020
    • Kuninori Morimoto's avatar
      soundwire: intel: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer · 4eb542cc
      Kuninori Morimoto authored
      
      
      Now ALSA SoC needs to use asoc_rtd_to_codec(),
      otherwise, it will be compile error.
      
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Acked-By: default avatarVinod Koul <vkoul@kernel.org>
      Link: https://lore.kernel.org/r/87y2qqvdxu.wl-kuninori.morimoto.gx@renesas.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      4eb542cc
    • Mark Brown's avatar
      Merge series "ASoC: Fix dependency issues of SND_SOC" from Wei Li <liwei391@huawei.com>: · ace105dd
      Mark Brown authored
      Fix dependency issues of SND_SOC introduced by commit ea00d952
      ("ASoC: Use imply for SND_SOC_ALL_CODECS").
      
      Wei Li (2):
        ASoC: wm89xx: Fix build errors caused by I2C dependency
        ASoC: Fix wrong dependency of da7210 and wm8983
      
       sound/soc/codecs/Kconfig | 7 +++++--
       1 file changed, 5 insertions(+), 2 deletions(-)
      
      --
      2.17.1
      ace105dd
    • Wei Li's avatar
      ASoC: Fix wrong dependency of da7210 and wm8983 · c1c050ee
      Wei Li authored
      As these two drivers support I2C and SPI, we should add the SND_SOC_I2C_AND_SPI
      dependency instead.
      
      Fixes: ce0c97f8
      
       ("ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout")
      Signed-off-by: default avatarWei Li <liwei391@huawei.com>
      Link: https://lore.kernel.org/r/20200420202410.47327-3-liwei391@huawei.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      c1c050ee
    • Wei Li's avatar
      ASoC: wm89xx: Fix build errors caused by I2C dependency · 91e475b5
      Wei Li authored
      When I2C=m, SND_SOC_WM8900=y, SND_SOC_WM8988=y, SND_SOC_WM8995=y:
      
      sound/soc/codecs/wm8900.o: In function `wm8900_i2c_probe':
      wm8900.c:(.text+0xa16): undefined reference to `__devm_regmap_init_i2c'
      sound/soc/codecs/wm8900.o: In function `wm8900_modinit':
      wm8900.c:(.init.text+0xb): undefined reference to `i2c_register_driver'
      sound/soc/codecs/wm8900.o: In function `wm8900_exit':
      wm8900.c:(.exit.text+0x8): undefined reference to `i2c_del_driver'
      sound/soc/codecs/wm8988.o: In function `wm8988_i2c_probe':
      wm8988.c:(.text+0x86b): undefined reference to `__devm_regmap_init_i2c'
      sound/soc/codecs/wm8988.o: In function `wm8988_modinit':
      wm8988.c:(.init.text+0xb): undefined reference to `i2c_register_driver'
      sound/soc/codecs/wm8988.o: In function `wm8988_exit':
      wm8988.c:(.exit.text+0x8): undefined reference to `i2c_del_driver'
      sound/soc/codecs/wm8995.o: In function `wm8995_i2c_probe':
      wm8995.c:(.text+0x1b5b): undefined reference to `__devm_regmap_init_i2c'
      sound/soc/codecs/wm8995.o: In function `wm8995_modinit':
      wm8995.c:(.init.text+0xb): undefined reference to `i2c_register_driver'
      sound/soc/codecs/wm8995.o: In function `wm8995_exit':
      wm8995.c:(.exit.text+0x8): undefined reference to `i2c_del_driver'
      
      As these drivers support I2C and SPI, we add the SND_SOC_I2C_AND_SPI
      dependency to solve it.
      
      Fixes: ea00d952
      
       ("ASoC: Use imply for SND_SOC_ALL_CODECS")
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Signed-off-by: default avatarWei Li <liwei391@huawei.com>
      Link: https://lore.kernel.org/r/20200420202410.47327-2-liwei391@huawei.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      91e475b5
    • Mark Brown's avatar
      Merge series "ASoC: rsnd: multi-SSI setup fixes" from Matthias Blankertz... · bce32169
      Mark Brown authored
      Merge series "ASoC: rsnd: multi-SSI setup fixes" from Matthias Blankertz <matthias.blankertz@cetitec.com>:
      
      Fix rsnd_dai_call() operations being performed twice for the master SSI
      in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI
      setups.
      The only visible effect of these issues was some "status check failed"
      spam when the rsnd_ssi_stop was called, but overall the code is cleaner
      now, and some questionable writes to the SSICR register which did not
      lead to any observable misbehaviour but were contrary to the datasheet
      are fixed.
      
      Mark:
      The first patch kind of reverts my "ASoC: rsnd: Fix parent SSI
      start/stop in multi-SSI mode" from a few days ago and achieves the same
      effect in a simpler fashion, if you would prefer a clean patch series
      based on v5.6 drop me a note.
      
      Greetings,
      	Matthias
      
      Matthias Blankertz (2):
        ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent
        ASoC: rsnd: Fix "status check failed" spam for multi-SSI
      
       sound/soc/sh/rcar/ssi.c | 18 +++++++++++++-----
       1 file changed, 13 insertions(+), 5 deletions(-)
      
      base-commit: 15a5760c
      --
      2.26.1
      bce32169
    • Mark Brown's avatar
      Merge series "ASoC: meson: fix codec-to-codec link setup" from Jerome Brunet... · 036889b2
      Mark Brown authored
      Merge series "ASoC: meson: fix codec-to-codec link setup" from Jerome Brunet <jbrunet@baylibre.com>:
      
      This patchset fixes the problem reported by Marc in this thread [0]
      The problem was due to an error in the meson card drivers which had
      the "no_pcm" dai_link property set on codec-to-codec links
      
      [0]: https://lore.kernel.org/r/20200417122732.GC5315@sirena.org.uk
      
      Jerome Brunet (2):
        ASoC: meson: axg-card: fix codec-to-codec link setup
        ASoC: meson: gx-card: fix codec-to-codec link setup
      
       sound/soc/meson/axg-card.c | 4 +++-
       sound/soc/meson/gx-card.c  | 4 +++-
       2 files changed, 6 insertions(+), 2 deletions(-)
      
      --
      2.25.2
      036889b2
    • Gyeongtaek Lee's avatar
      ASoC: dapm: fixup dapm kcontrol widget · ebf14747
      Gyeongtaek Lee authored
      
      
      snd_soc_dapm_kcontrol widget which is created by autodisable control
      should contain correct on_val, mask and shift because it is set when the
      widget is powered and changed value is applied on registers by following
      code in dapm_seq_run_coalesced().
      
      		mask |= w->mask << w->shift;
      		if (w->power)
      			value |= w->on_val << w->shift;
      		else
      			value |= w->off_val << w->shift;
      
      Shift on the mask in dapm_kcontrol_data_alloc() is removed to prevent
      double shift.
      And, on_val in dapm_kcontrol_set_value() is modified to get correct
      value in the dapm_seq_run_coalesced().
      
      Signed-off-by: default avatarGyeongtaek Lee <gt82.lee@samsung.com>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/000001d61537$b212f620$1638e260$@samsung.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      ebf14747
    • Matthias Blankertz's avatar
      ASoC: rsnd: Fix "status check failed" spam for multi-SSI · 54cb6221
      Matthias Blankertz authored
      
      
      Fix the rsnd_ssi_stop function to skip disabling the individual SSIs of
      a multi-SSI setup, as the actual stop is performed by rsnd_ssiu_stop_gen2
      - the same logic as in rsnd_ssi_start. The attempt to disable these SSIs
      was harmless, but caused a "status check failed" message to be printed
      for every SSI in the multi-SSI setup.
      The disabling of interrupts is still performed, as they are enabled for
      all SSIs in rsnd_ssi_init, but care is taken to not accidentally set the
      EN bit for an SSI where it was not set by rsnd_ssi_start.
      
      Signed-off-by: default avatarMatthias Blankertz <matthias.blankertz@cetitec.com>
      Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/20200417153017.1744454-3-matthias.blankertz@cetitec.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      54cb6221
    • Matthias Blankertz's avatar
      ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent · 0c258657
      Matthias Blankertz authored
      The master SSI of a multi-SSI setup was attached both to the
      RSND_MOD_SSI slot and the RSND_MOD_SSIP slot of the rsnd_dai_stream.
      This is not correct wrt. the meaning of being "parent" in the rest of
      the SSI code, where it seems to indicate an SSI that provides clock and
      word sync but is not transmitting/receiving audio data.
      
      Not treating the multi-SSI master as parent allows removal of various
      special cases to the rsnd_ssi_is_parent conditions introduced in commit
      a09fb3f2
      
       ("ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode").
      It also fixes the issue that operations performed via rsnd_dai_call()
      were performed twice for the master SSI. This caused some "status check
      failed" spam when stopping a multi-SSI stream as the driver attempted to
      stop the master SSI twice.
      
      Signed-off-by: default avatarMatthias Blankertz <matthias.blankertz@cetitec.com>
      Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/20200417153017.1744454-2-matthias.blankertz@cetitec.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      0c258657
    • Jerome Brunet's avatar
      ASoC: meson: gx-card: fix codec-to-codec link setup · de911b4e
      Jerome Brunet authored
      Since the addition of commit 9b5db059 ("ASoC: soc-pcm: dpcm: Only allow
      playback/capture if supported"), meson-axg cards which have codec-to-codec
      links fail to init and Oops.
      
        Unable to handle kernel NULL pointer dereference at virtual address 0000000000000128
        Internal error: Oops: 96000044 [#1] PREEMPT SMP
        CPU: 3 PID: 1582 Comm: arecord Not tainted 5.7.0-rc1
        pc : invalidate_paths_ep+0x30/0xe0
        lr : snd_soc_dapm_dai_get_connected_widgets+0x170/0x1a8
        Call trace:
         invalidate_paths_ep+0x30/0xe0
         snd_soc_dapm_dai_get_connected_widgets+0x170/0x1a8
         dpcm_path_get+0x38/0xd0
         dpcm_fe_dai_open+0x70/0x920
         snd_pcm_open_substream+0x564/0x840
         snd_pcm_open+0xfc/0x228
         snd_pcm_capture_open+0x4c/0x78
         snd_open+0xac/0x1a8
         ...
      
      While this error was initially reported the axg-card type, it also applies
      to the gx-card type.
      
      While initiliazing the links, ASoC treats the codec-to-codec links of this
      card type as a DPCM backend. This error eventually leads to the Oops.
      
      Most of the card driver code is shared between DPCM backends and
      codec-to-codec links. The property "no_pcm" marking DCPM BE was left set on
      codec-to-codec links, leading to this problem. This commit fixes that.
      
      Fixes: e37a0c31
      
       ("ASoC: meson: gx: add sound card support")
      Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
      Link: https://lore.kernel.org/r/20200420114511.450560-3-jbrunet@baylibre.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      de911b4e
    • Jerome Brunet's avatar
      ASoC: meson: axg-card: fix codec-to-codec link setup · 11642842
      Jerome Brunet authored
      Since the addition of commit 9b5db059 ("ASoC: soc-pcm: dpcm: Only allow
      playback/capture if supported"), meson-axg cards which have codec-to-codec
      links fail to init and Oops:
      
        Unable to handle kernel NULL pointer dereference at virtual address 0000000000000128
        Internal error: Oops: 96000044 [#1] PREEMPT SMP
        CPU: 3 PID: 1582 Comm: arecord Not tainted 5.7.0-rc1
        pc : invalidate_paths_ep+0x30/0xe0
        lr : snd_soc_dapm_dai_get_connected_widgets+0x170/0x1a8
        Call trace:
         invalidate_paths_ep+0x30/0xe0
         snd_soc_dapm_dai_get_connected_widgets+0x170/0x1a8
         dpcm_path_get+0x38/0xd0
         dpcm_fe_dai_open+0x70/0x920
         snd_pcm_open_substream+0x564/0x840
         snd_pcm_open+0xfc/0x228
         snd_pcm_capture_open+0x4c/0x78
         snd_open+0xac/0x1a8
         ...
      
      While initiliazing the links, ASoC treats the codec-to-codec links of this
      card type as a DPCM backend. This error eventually leads to the Oops.
      
      Most of the card driver code is shared between DPCM backends and
      codec-to-codec links. The property "no_pcm" marking DCPM BE was left set on
      codec-to-codec links, leading to this problem. This commit fixes that.
      
      Fixes: 0a8f1117
      
       ("ASoC: meson: axg-card: add basic codec-to-codec link support")
      Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
      Link: https://lore.kernel.org/r/20200420114511.450560-2-jbrunet@baylibre.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      11642842
  3. Apr 18, 2020
    • Cezary Rojewski's avatar
      ASoC: Intel: haswell: Power transition refactor · 8ec7d604
      Cezary Rojewski authored
      
      
      Update D0 <-> D3 sequence to correctly transition hardware and DSP core
      from and to D3. On top of that, set SHIM registers to their recommended
      defaults during D0 and D3 proceduces as HW does not reset registers for
      us.
      
      Connected to:
      [alsa-devel][BUG] bdw-rt5650 DSP boot timeout
      https://mailman.alsa-project.org/pipermail/alsa-devel/2019-July/153098.html
      
      Github issue ticket reference:
      https://github.com/thesofproject/linux/pull/1842
      
      Tested on:
      - BDW-Y RVP with rt286
      - SAMUS with rt5677
      
      Proposed solution (both in July 2019 and on github):
      'Revert "ASoC: Intel: Work around to fix HW d3 potential crash issue"'
      is NAKed as it only covers the problem up and actually brings back the
      undefined behavior: some registers (e.g.: APLLSE) are describing LPT
      offsets rather than WPT ones. In consequence, during power-transitions
      driver issues incorrect writes and leaves the regs of interest alone.
      
      Existing patch - the non-revert - does not resolve the HW D3 issue at
      all as it ignores the recommended sequence and does not initialize
      hardware registers as expected. And thus, leaving things as are is also
      unacceptable.
      
      Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
      Tested-by: default avatarRoss Zwisler <zwisler@google.com>
      Link: https://lore.kernel.org/r/20200330194520.13253-1-cezary.rojewski@intel.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      8ec7d604
    • Pierre-Louis Bossart's avatar
      ASoC: SOF: Intel: add min/max channels for SSP on Baytrail/Broadwell · 8c05246c
      Pierre-Louis Bossart authored
      Major regressions were detected by SOF CI on CherryTrail and Broadwell:
      
      [   25.705750]  SSP2-Codec: ASoC: no backend playback stream
      [   27.923378]  SSP2-Codec: ASoC: no users playback at close - state
      
      This is root-caused to the introduction of the DAI capability checks
      with snd_soc_dai_stream_valid(). Its use in soc-pcm.c makes it a
      requirement for all DAIs to report at least a non-zero min_channels
      field.
      
      For some reason the SSP structures used for SKL+ did provide this
      information but legacy platforms didn't.
      
      Fixes: 9b5db059
      
       ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
      Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
      Link: https://lore.kernel.org/r/20200417172014.11760-1-pierre-louis.bossart@linux.intel.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      8c05246c
    • Olivier Moysan's avatar
      ASoC: stm32: sai: fix sai probe · e2bcb657
      Olivier Moysan authored
      pcm config must be set before snd_dmaengine_pcm_register() call.
      
      Fixes: 0d6defc7
      
       ("ASoC: stm32: sai: manage rebind issue")
      
      Signed-off-by: default avatarOlivier Moysan <olivier.moysan@st.com>
      Link: https://lore.kernel.org/r/20200417142122.10212-1-olivier.moysan@st.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      e2bcb657
  4. Apr 16, 2020