Skip to content
  1. Nov 04, 2019
    • Paolo Bonzini's avatar
      kvm: mmu: ITLB_MULTIHIT mitigation · b8e8c830
      Paolo Bonzini authored
      
      
      With some Intel processors, putting the same virtual address in the TLB
      as both a 4 KiB and 2 MiB page can confuse the instruction fetch unit
      and cause the processor to issue a machine check resulting in a CPU lockup.
      
      Unfortunately when EPT page tables use huge pages, it is possible for a
      malicious guest to cause this situation.
      
      Add a knob to mark huge pages as non-executable. When the nx_huge_pages
      parameter is enabled (and we are using EPT), all huge pages are marked as
      NX. If the guest attempts to execute in one of those pages, the page is
      broken down into 4K pages, which are then marked executable.
      
      This is not an issue for shadow paging (except nested EPT), because then
      the host is in control of TLB flushes and the problematic situation cannot
      happen.  With nested EPT, again the nested guest can cause problems shadow
      and direct EPT is treated in the same way.
      
      [ tglx: Fixup default to auto and massage wording a bit ]
      
      Originally-by: default avatarJunaid Shahid <junaids@google.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      b8e8c830
    • Tyler Hicks's avatar
      cpu/speculation: Uninline and export CPU mitigations helpers · 731dc9df
      Tyler Hicks authored
      
      
      A kernel module may need to check the value of the "mitigations=" kernel
      command line parameter as part of its setup when the module needs
      to perform software mitigations for a CPU flaw.
      
      Uninline and export the helper functions surrounding the cpu_mitigations
      enum to allow for their usage from a module.
      
      Lastly, privatize the enum and cpu_mitigations variable since the value of
      cpu_mitigations can be checked with the exported helper functions.
      
      Signed-off-by: default avatarTyler Hicks <tyhicks@canonical.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      731dc9df
    • Pawan Gupta's avatar
      x86/cpu: Add Tremont to the cpu vulnerability whitelist · cad14885
      Pawan Gupta authored
      
      
      Add the new cpu family ATOM_TREMONT_D to the cpu vunerability
      whitelist. ATOM_TREMONT_D is not affected by X86_BUG_ITLB_MULTIHIT.
      
      ATOM_TREMONT_D might have mitigations against other issues as well, but
      only the ITLB multihit mitigation is confirmed at this point.
      
      Signed-off-by: default avatarPawan Gupta <pawan.kumar.gupta@linux.intel.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      cad14885
    • Vineela Tummalapalli's avatar
      x86/bugs: Add ITLB_MULTIHIT bug infrastructure · db4d30fb
      Vineela Tummalapalli authored
      Some processors may incur a machine check error possibly resulting in an
      unrecoverable CPU lockup when an instruction fetch encounters a TLB
      multi-hit in the instruction TLB. This can occur when the page size is
      changed along with either the physical address or cache type. The relevant
      erratum can be found here:
      
         https://bugzilla.kernel.org/show_bug.cgi?id=205195
      
      
      
      There are other processors affected for which the erratum does not fully
      disclose the impact.
      
      This issue affects both bare-metal x86 page tables and EPT.
      
      It can be mitigated by either eliminating the use of large pages or by
      using careful TLB invalidations when changing the page size in the page
      tables.
      
      Just like Spectre, Meltdown, L1TF and MDS, a new bit has been allocated in
      MSR_IA32_ARCH_CAPABILITIES (PSCHANGE_MC_NO) and will be set on CPUs which
      are mitigated against this issue.
      
      Signed-off-by: default avatarVineela Tummalapalli <vineela.tummalapalli@intel.com>
      Co-developed-by: default avatarPawan Gupta <pawan.kumar.gupta@linux.intel.com>
      Signed-off-by: default avatarPawan Gupta <pawan.kumar.gupta@linux.intel.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      db4d30fb
    • Thomas Gleixner's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux · ca8888d7
      Thomas Gleixner authored
      to pick up the KVM fix which is required for the NX series.
      ca8888d7
    • Linus Torvalds's avatar
      Linux 5.4-rc6 · a99d8080
      Linus Torvalds authored
      a99d8080
    • Linus Torvalds's avatar
      Merge tag 'usb-5.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb · 3a69c9e5
      Linus Torvalds authored
      Pull USB fixes from Greg KH:
       "The USB sub-maintainers woke up this past week and sent a bunch of
        tiny fixes. Here are a lot of small patches that that resolve a bunch
        of reported issues in the USB core, drivers, serial drivers, gadget
        drivers, and of course, xhci :)
      
        All of these have been in linux-next with no reported issues"
      
      * tag 'usb-5.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (31 commits)
        usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
        usb: cdns3: gadget: Fix g_audio use case when connected to Super-Speed host
        usb: cdns3: gadget: reset EP_CLAIMED flag while unloading
        USB: serial: whiteheat: fix line-speed endianness
        USB: serial: whiteheat: fix potential slab corruption
        USB: gadget: Reject endpoints with 0 maxpacket value
        UAS: Revert commit 3ae62a42 ("UAS: fix alignment of scatter/gather segments")
        usb-storage: Revert commit 747668db ("usb-storage: Set virt_boundary_mask to avoid SG overflows")
        usbip: Fix free of unallocated memory in vhci tx
        usbip: tools: Fix read_usb_vudc_device() error path handling
        usb: xhci: fix __le32/__le64 accessors in debugfs code
        usb: xhci: fix Immediate Data Transfer endianness
        xhci: Fix use-after-free regression in xhci clear hub TT implementation
        USB: ldusb: fix control-message timeout
        USB: ldusb: use unsigned size format specifiers
        USB: ldusb: fix ring-buffer locking
        USB: Skip endpoints with 0 maxpacket length
        usb: cdns3: gadget: Don't manage pullups
        usb: dwc3: remove the call trace of USBx_GFLADJ
        usb: gadget: configfs: fix concurrent issue between composite APIs
        ...
      3a69c9e5
  2. Nov 03, 2019
  3. Nov 02, 2019
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 1204c70d
      Linus Torvalds authored
      Pull networking fixes from David Miller:
      
       1) Fix free/alloc races in batmanadv, from Sven Eckelmann.
      
       2) Several leaks and other fixes in kTLS support of mlx5 driver, from
          Tariq Toukan.
      
       3) BPF devmap_hash cost calculation can overflow on 32-bit, from Toke
          Høiland-Jørgensen.
      
       4) Add an r8152 device ID, from Kazutoshi Noguchi.
      
       5) Missing include in ipv6's addrconf.c, from Ben Dooks.
      
       6) Use siphash in flow dissector, from Eric Dumazet. Attackers can
          easily infer the 32-bit secret otherwise etc.
      
       7) Several netdevice nesting depth fixes from Taehee Yoo.
      
       8) Fix several KCSAN reported errors, from Eric Dumazet. For example,
          when doing lockless skb_queue_empty() checks, and accessing
          sk_napi_id/sk_incoming_cpu lockless as well.
      
       9) Fix jumbo packet handling in RXRPC, from David Howells.
      
      10) Bump SOMAXCONN and tcp_max_syn_backlog values, from Eric Dumazet.
      
      11) Fix DMA synchronization in gve driver, from Yangchun Fu.
      
      12) Several bpf offload fixes, from Jakub Kicinski.
      
      13) Fix sk_page_frag() recursion during memory reclaim, from Tejun Heo.
      
      14) Fix ping latency during high traffic rates in hisilicon driver, from
          Jiangfent Xiao.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (146 commits)
        net: fix installing orphaned programs
        net: cls_bpf: fix NULL deref on offload filter removal
        selftests: bpf: Skip write only files in debugfs
        selftests: net: reuseport_dualstack: fix uninitalized parameter
        r8169: fix wrong PHY ID issue with RTL8168dp
        net: dsa: bcm_sf2: Fix IMP setup for port different than 8
        net: phylink: Fix phylink_dbg() macro
        gve: Fixes DMA synchronization.
        inet: stop leaking jiffies on the wire
        ixgbe: Remove duplicate clear_bit() call
        Documentation: networking: device drivers: Remove stray asterisks
        e1000: fix memory leaks
        i40e: Fix receive buffer starvation for AF_XDP
        igb: Fix constant media auto sense switching when no cable is connected
        net: ethernet: arc: add the missed clk_disable_unprepare
        igb: Enable media autosense for the i350.
        igb/igc: Don't warn on fatal read failures when the device is removed
        tcp: increase tcp_max_syn_backlog max value
        net: increase SOMAXCONN to 4096
        netdevsim: Fix use-after-free during device dismantle
        ...
      1204c70d
    • Linus Torvalds's avatar
      Merge tag 'nfs-for-5.4-3' of git://git.linux-nfs.org/projects/anna/linux-nfs · 372bf6c1
      Linus Torvalds authored
      Pull NFS client bugfixes from Anna Schumaker:
       "This contains two delegation fixes (with the RCU lock leak fix marked
        for stable), and three patches to fix destroying the the sunrpc back
        channel.
      
        Stable bugfixes:
      
         - Fix an RCU lock leak in nfs4_refresh_delegation_stateid()
      
        Other fixes:
      
         - The TCP back channel mustn't disappear while requests are
           outstanding
      
         - The RDMA back channel mustn't disappear while requests are
           outstanding
      
         - Destroy the back channel when we destroy the host transport
      
         - Don't allow a cached open with a revoked delegation"
      
      * tag 'nfs-for-5.4-3' of git://git.linux-nfs.org/projects/anna/linux-nfs:
        NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()
        NFSv4: Don't allow a cached open with a revoked delegation
        SUNRPC: Destroy the back channel when we destroy the host transport
        SUNRPC: The RDMA back channel mustn't disappear while requests are outstanding
        SUNRPC: The TCP back channel mustn't disappear while requests are outstanding
      372bf6c1
    • Linus Torvalds's avatar
      Merge tag 'for-linus-20191101' of git://git.kernel.dk/linux-block · 0821de28
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - Two small nvme fixes, one is a fabrics connection fix, the other one
         a cleanup made possible by that fix (Anton, via Keith)
      
       - Fix requeue handling in umb ubd (Anton)
      
       - Fix spin_lock_irq() nesting in blk-iocost (Dan)
      
       - Three small io_uring fixes:
           - Install io_uring fd after done with ctx (me)
           - Clear ->result before every poll issue (me)
           - Fix leak of shadow request on error (Pavel)
      
      * tag 'for-linus-20191101' of git://git.kernel.dk/linux-block:
        iocost: don't nest spin_lock_irq in ioc_weight_write()
        io_uring: ensure we clear io_kiocb->result before each issue
        um-ubd: Entrust re-queue to the upper layers
        nvme-multipath: remove unused groups_only mode in ana log
        nvme-multipath: fix possible io hang after ctrl reconnect
        io_uring: don't touch ctx in setup after ring fd install
        io_uring: Fix leaked shadow_req
      0821de28
    • Linus Torvalds's avatar
      Merge tag 'riscv/for-v5.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · e5897c7d
      Linus Torvalds authored
      Pull RISC-V fixes from Paul Walmsley:
       "One fix for PCIe users:
      
         - Fix legacy PCI I/O port access emulation
      
        One set of cleanups:
      
         - Resolve most of the warnings generated by sparse across arch/riscv.
           No functional changes
      
        And one MAINTAINERS update:
      
         - Update Palmer's E-mail address"
      
      * tag 'riscv/for-v5.4-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        MAINTAINERS: Change to my personal email address
        RISC-V: Add PCIe I/O BAR memory mapping
        riscv: for C functions called only from assembly, mark with __visible
        riscv: fp: add missing __user pointer annotations
        riscv: add missing header file includes
        riscv: mark some code and data as file-static
        riscv: init: merge split string literals in preprocessor directive
        riscv: add prototypes for assembly language functions from head.S
      e5897c7d
    • Linus Torvalds's avatar
      Merge branch 'parisc-5.4-3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux · 31408fbe
      Linus Torvalds authored
      Pull parisc fix from Helge Deller:
       "Fix a parisc kernel crash with ftrace functions when compiled without
        frame pointers"
      
      * 'parisc-5.4-3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux:
        parisc: fix frame pointer in ftrace_regs_caller()
      31408fbe
    • David S. Miller's avatar
      Merge branch 'fix-BPF-offload-related-bugs' · aeb1b85c
      David S. Miller authored
      
      
      Jakub Kicinski says:
      
      ====================
      fix BPF offload related bugs
      
      test_offload.py catches some recently added bugs.
      
      First of a bug in test_offload.py itself after recent changes
      to netdevsim is fixed.
      
      Second patch fixes a bug in cls_bpf, and last one addresses
      a problem with the recently added XDP installation optimization.
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aeb1b85c
    • Jakub Kicinski's avatar
      net: fix installing orphaned programs · aefc3e72
      Jakub Kicinski authored
      When netdevice with offloaded BPF programs is destroyed
      the programs are orphaned and removed from the program
      IDA - their IDs get released (the programs may remain
      accessible via existing open file descriptors and pinned
      files). After IDs are released they are set to 0.
      
      This confuses dev_change_xdp_fd() because it compares
      the __dev_xdp_query() result where 0 means no program
      with prog->aux->id where 0 means orphaned.
      
      dev_change_xdp_fd() would have incorrectly returned success
      even though it had not installed the program.
      
      Since drivers already catch this case via bpf_offload_dev_match()
      let them handle this case. The error message drivers produce in
      this case ("program loaded for a different device") is in fact
      correct as the orphaned program must had to be loaded for a
      different device.
      
      Fixes: c14a9f63
      
       ("net: Don't call XDP_SETUP_PROG when nothing is changed")
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aefc3e72
    • Jakub Kicinski's avatar
      net: cls_bpf: fix NULL deref on offload filter removal · 41aa29a5
      Jakub Kicinski authored
      Commit 40119211 ("net: sched: refactor block offloads counter
      usage") missed the fact that either new prog or old prog may be
      NULL.
      
      Fixes: 40119211
      
       ("net: sched: refactor block offloads counter usage")
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      41aa29a5
    • Jakub Kicinski's avatar
      selftests: bpf: Skip write only files in debugfs · 8101e069
      Jakub Kicinski authored
      DebugFS for netdevsim now contains some "action trigger" files
      which are write only. Don't try to capture the contents of those.
      
      Note that we can't use os.access() because the script requires
      root.
      
      Fixes: 4418f862
      
       ("netdevsim: implement support for devlink region and snapshots")
      Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8101e069
    • Wei Wang's avatar
      selftests: net: reuseport_dualstack: fix uninitalized parameter · d64479a3
      Wei Wang authored
      This test reports EINVAL for getsockopt(SOL_SOCKET, SO_DOMAIN)
      occasionally due to the uninitialized length parameter.
      Initialize it to fix this, and also use int for "test_family" to comply
      with the API standard.
      
      Fixes: d6a61f80
      
       ("soreuseport: test mixed v4/v6 sockets")
      Reported-by: default avatarMaciej Żenczykowski <maze@google.com>
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarWei Wang <weiwan@google.com>
      Cc: Craig Gallek <cgallek@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d64479a3
    • Heiner Kallweit's avatar
      r8169: fix wrong PHY ID issue with RTL8168dp · 62bdc8fd
      Heiner Kallweit authored
      As reported in [0] at least one RTL8168dp version has problems
      establishing a link. This chip version has an integrated RTL8211b PHY,
      however the chip seems to report a wrong PHY ID, resulting in a wrong
      PHY driver (for Generic Realtek PHY) being loaded.
      Work around this issue by adding a hook to r8168dp_2_mdio_read()
      for returning the correct PHY ID.
      
      [0] https://bbs.archlinux.org/viewtopic.php?id=246508
      
      Fixes: 242cd9b5
      
       ("r8169: use phy_resume/phy_suspend")
      Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      62bdc8fd
    • Florian Fainelli's avatar
      net: dsa: bcm_sf2: Fix IMP setup for port different than 8 · 5fc0f212
      Florian Fainelli authored
      Since it became possible for the DSA core to use a CPU port different
      than 8, our bcm_sf2_imp_setup() function was broken because it assumes
      that registers are applicable to port 8. In particular, the port's MAC
      is going to stay disabled, so make sure we clear the RX_DIS and TX_DIS
      bits if we are not configured for port 8.
      
      Fixes: 9f91484f
      
       ("net: dsa: make "label" property optional for dsa2")
      Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5fc0f212
    • Florian Fainelli's avatar
      net: phylink: Fix phylink_dbg() macro · 9d68db50
      Florian Fainelli authored
      The phylink_dbg() macro does not follow dynamic debug or defined(DEBUG)
      and as a result, it spams the kernel log since a PR_DEBUG level is
      currently used. Fix it to be defined appropriately whether
      CONFIG_DYNAMIC_DEBUG or defined(DEBUG) are set.
      
      Fixes: 17091180
      
       ("net: phylink: Add phylink_{printk, err, warn, info, dbg} macros")
      Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9d68db50
    • Yangchun Fu's avatar
      gve: Fixes DMA synchronization. · 9cfeeb57
      Yangchun Fu authored
      
      
      Synces the DMA buffer properly in order for CPU and device to see
      the most up-to-data data.
      
      Signed-off-by: default avatarYangchun Fu <yangchun@google.com>
      Reviewed-by: default avatarCatherine Sullivan <csully@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9cfeeb57
    • Eric Dumazet's avatar
      inet: stop leaking jiffies on the wire · a904a069
      Eric Dumazet authored
      Historically linux tried to stick to RFC 791, 1122, 2003
      for IPv4 ID field generation.
      
      RFC 6864 made clear that no matter how hard we try,
      we can not ensure unicity of IP ID within maximum
      lifetime for all datagrams with a given source
      address/destination address/protocol tuple.
      
      Linux uses a per socket inet generator (inet_id), initialized
      at connection startup with a XOR of 'jiffies' and other
      fields that appear clear on the wire.
      
      Thiemo Nagel pointed that this strategy is a privacy
      concern as this provides 16 bits of entropy to fingerprint
      devices.
      
      Let's switch to a random starting point, this is just as
      good as far as RFC 6864 is concerned and does not leak
      anything critical.
      
      Fixes: 1da177e4
      
       ("Linux-2.6.12-rc2")
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Reported-by: default avatarThiemo Nagel <tnagel@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a904a069
    • David S. Miller's avatar
      Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue · c8c2cd81
      David S. Miller authored
      
      
      Jeff Kirsher says:
      
      ====================
      Intel Wired LAN Driver Updates 2019-11-01
      
      This series contains updates to e1000, igb, igc, ixgbe, i40e and driver
      documentation.
      
      Lyude Paul fixes an issue where a fatal read error occurs when the
      device is unplugged from the machine.  So change the read error into a
      warn while the device is still present.
      
      Manfred Rudigier found that the i350 device was not apart of the "Media
      Auto Sense" feature, yet the device supports it.  So add the missing
      i350 device to the check and fix an issue where the media auto sense
      would flip/flop when no cable was connected to the port causing spurious
      kernel log messages.
      
      I fixed an issue where the fix to resolve receive buffer starvation was
      applied in more than one place in the driver, one being the incorrect
      location in the i40e driver.
      
      Wenwen Wang fixes a potential memory leak in e1000 where allocated
      memory is not properly cleaned up in one of the error paths.
      
      Jonathan Neuschäfer cleans up the driver documentation to be consistent
      and remove the footnote reference, since the footnote no longer exists in
      the documentation.
      
      Igor Pylypiv cleans up a duplicate clearing of a bit, no need to clear
      it twice.
      
      v2: Fixed alignment issue in patch 3 of the series based on community
          feedback.
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c8c2cd81
    • Igor Pylypiv's avatar
      ixgbe: Remove duplicate clear_bit() call · 451fe015
      Igor Pylypiv authored
      
      
      __IXGBE_RX_BUILD_SKB_ENABLED bit is already cleared.
      
      Signed-off-by: default avatarIgor Pylypiv <igor.pylypiv@gmail.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      451fe015
    • Jonathan Neuschäfer's avatar
      Documentation: networking: device drivers: Remove stray asterisks · 17df5ae1
      Jonathan Neuschäfer authored
      These asterisks were once references to a line that said:
        "* Other names and brands may be claimed as the property of others."
      But now, they serve no purpose; they can only irritate the reader.
      
      Fixes: de3edab4 ("e1000: update README for e1000")
      Fixes: a3fb6568 ("e100.txt: Cleanup license info in kernel doc")
      Fixes: da8c01c4 ("e1000e.txt: Add e1000e documentation")
      Fixes: f12a84a9 ("Documentation: fm10k: Add kernel documentation")
      Fixes: b55c52b1 ("igb.txt: Add igb documentation")
      Fixes: c4e9b56e ("igbvf.txt: Add igbvf Documentation")
      Fixes: d7064f4c ("Documentation/networking/: Update Intel wired LAN driver documentation")
      Fixes: c4b8c011 ("ixgbevf.txt: Update ixgbevf documentation")
      Fixes: 1e06edcc ("Documentation: i40e: Prepare documentation for RST conversion")
      Fixes: 105bf2fe ("i40evf: add driver to kernel build system")
      Fixes: 1fae869b ("Documentation: ice: Prepare documentation for RST conversion")
      Fixes: df69ba43
      
       ("ionic: Add basic framework for IONIC Network device driver")
      Signed-off-by: default avatarJonathan Neuschäfer <j.neuschaefer@gmx.net>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      17df5ae1
    • Wenwen Wang's avatar
      e1000: fix memory leaks · 8472ba62
      Wenwen Wang authored
      
      
      In e1000_set_ringparam(), 'tx_old' and 'rx_old' are not deallocated if
      e1000_up() fails, leading to memory leaks. Refactor the code to fix this
      issue.
      
      Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      8472ba62
    • Jeff Kirsher's avatar
      i40e: Fix receive buffer starvation for AF_XDP · 2c19e395
      Jeff Kirsher authored
      Magnus's fix to resolve a potential receive buffer starvation for AF_XDP
      got applied to both the i40e_xsk_umem_enable/disable() functions, when it
      should have only been applied to the "enable".  So clean up the undesired
      code in the disable function.
      
      CC: Magnus Karlsson <magnus.karlsson@intel.com>
      Fixes: 1f459bdc
      
       ("i40e: fix potential RX buffer starvation for AF_XDP")
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
      2c19e395
    • Manfred Rudigier's avatar
      igb: Fix constant media auto sense switching when no cable is connected · 8d5cfd7f
      Manfred Rudigier authored
      
      
      At least on the i350 there is an annoying behavior that is maybe also
      present on 82580 devices, but was probably not noticed yet as MAS is not
      widely used.
      
      If no cable is connected on both fiber/copper ports the media auto sense
      code will constantly swap between them as part of the watchdog task and
      produce many unnecessary kernel log messages.
      
      The swap code responsible for this behavior (switching to fiber) should
      not be executed if the current media type is copper and there is no signal
      detected on the fiber port. In this case we can safely wait until the
      AUTOSENSE_EN bit is cleared.
      
      Signed-off-by: default avatarManfred Rudigier <manfred.rudigier@omicronenergy.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      8d5cfd7f
    • Linus Torvalds's avatar
      Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 0dbe6cb8
      Linus Torvalds authored
      Pull scheduler fixes from Ingo Molnar:
       "Fix two scheduler topology bugs/oversights on Juno r0 2+4 big.LITTLE
        systems"
      
      * 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        sched/topology: Allow sched_asym_cpucapacity to be disabled
        sched/topology: Don't try to build empty sched domains
      0dbe6cb8
    • Linus Torvalds's avatar
      Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 355f83c1
      Linus Torvalds authored
      Pull perf fixes from Ingo Molnar:
       "Misc fixes: an ABI fix for a reserved field, AMD IBS fixes, an Intel
        uncore PMU driver fix and a header typo fix"
      
      * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        perf/headers: Fix spelling s/EACCESS/EACCES/, s/privilidge/privilege/
        perf/x86/uncore: Fix event group support
        perf/x86/amd/ibs: Handle erratum #420 only on the affected CPU family (10h)
        perf/x86/amd/ibs: Fix reading of the IBS OpData register and thus precise RIP validity
        perf/core: Start rejecting the syscall with attr.__reserved_2 set
      355f83c1
    • Linus Torvalds's avatar
      Merge branch 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · b2a18c25
      Linus Torvalds authored
      Pull EFI fixes from Ingo Molnar:
       "Various fixes all over the map: prevent boot crashes on HyperV,
        classify UEFI randomness as bootloader randomness, fix EFI boot for
        the Raspberry Pi2, fix efi_test permissions, etc"
      
      * 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        efi/efi_test: Lock down /dev/efi_test and require CAP_SYS_ADMIN
        x86, efi: Never relocate kernel below lowest acceptable address
        efi: libstub/arm: Account for firmware reserved memory at the base of RAM
        efi/random: Treat EFI_RNG_PROTOCOL output as bootloader randomness
        efi/tpm: Return -EINVAL when determining tpm final events log size fails
        efi: Make CONFIG_EFI_RCI2_TABLE selectable on x86 only
      b2a18c25
    • David S. Miller's avatar
      Merge tag 'wireless-drivers-2019-11-01' of... · 33e49805
      David S. Miller authored
      Merge tag 'wireless-drivers-2019-11-01' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers
      
      
      
      Kalle Valo says:
      
      ====================
      wireless-drivers fixes for 5.4
      
      Third set of fixes for 5.4. Most of them are for iwlwifi but important
      fixes also for rtlwifi and mt76, the overflow fix for rtlwifi being
      most important.
      
      iwlwifi
      
      * fix merge damage on earlier patch
      
      * various fixes to device id handling
      
      * fix scan config command handling which caused firmware asserts
      
      rtlwifi
      
      * fix overflow on P2P IE handling
      
      * don't deliver too small frames to mac80211
      
      mt76
      
      * disable PCIE_ASPM
      
      * fix buffer DMA unmap on certain cases
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      33e49805
    • Chuhong Yuan's avatar
      net: ethernet: arc: add the missed clk_disable_unprepare · 4202e219
      Chuhong Yuan authored
      
      
      The remove misses to disable and unprepare priv->macclk like what is done
      when probe fails.
      Add the missed call in remove.
      
      Signed-off-by: default avatarChuhong Yuan <hslester96@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4202e219
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · d540c398
      Linus Torvalds authored
      Pull arm64 fixes from Will Deacon:
       "These are almost exclusively related to CPU errata in CPUs from
        Broadcom and Qualcomm where the workarounds were either not being
        enabled when they should have been or enabled when they shouldn't have
        been.
      
        The only "interesting" fix is ensuring that writeable, shared mappings
        are initially mapped as clean since we inadvertently broke the logic
        back in v4.14 and then noticed the problem via code inspection the
        other day.
      
        The only critical issue we have outstanding is a sporadic NULL
        dereference in the scheduler, which doesn't appear to be
        arm64-specific and PeterZ is tearing his hair out over it at the
        moment.
      
        Summary:
      
         - Enable CPU errata workarounds for Broadcom Brahma-B53
      
         - Enable CPU errata workarounds for Qualcomm Hydra/Kryo CPUs
      
         - Fix initial dirty status of writeable, shared mappings"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: apply ARM64_ERRATUM_843419 workaround for Brahma-B53 core
        arm64: Brahma-B53 is SSB and spectre v2 safe
        arm64: apply ARM64_ERRATUM_845719 workaround for Brahma-B53 core
        arm64: cpufeature: Enable Qualcomm Falkor errata 1009 for Kryo
        arm64: cpufeature: Enable Qualcomm Falkor/Kryo errata 1003
        arm64: Ensure VM_WRITE|VM_SHARED ptes are clean by default
      d540c398