Skip to content
  1. Jan 20, 2019
    • Linus Torvalds's avatar
      Merge tag 'nfs-for-5.0-2' of git://git.linux-nfs.org/projects/anna/linux-nfs · b0efca46
      Linus Torvalds authored
      Pull NFS client fixes from Anna Schumaker:
       "These are mostly fixes for SUNRPC bugs, with a single v4.2
        copy_file_range() fix mixed in.
      
        Stable bugfixes:
         - Fix TCP receive code on archs with flush_dcache_page()
      
        Other bugfixes:
         - Fix error code in rpcrdma_buffer_create()
         - Fix a double free in rpcrdma_send_ctxs_create()
         - Fix kernel BUG at kernel/cred.c:825
         - Fix unnecessary retry in nfs42_proc_copy_file_range()
         - Ensure rq_bytes_sent is reset before request transmission
         - Ensure we respect the RPCSEC_GSS sequence number limit
         - Address Kerberos performance/behavior regression"
      
      * tag 'nfs-for-5.0-2' of git://git.linux-nfs.org/projects/anna/linux-nfs:
        SUNRPC: Address Kerberos performance/behavior regression
        SUNRPC: Ensure we respect the RPCSEC_GSS sequence number limit
        SUNRPC: Ensure rq_bytes_sent is reset before request transmission
        NFSv4.2 fix unnecessary retry in nfs4_copy_file_range
        sunrpc: kernel BUG at kernel/cred.c:825!
        SUNRPC: Fix TCP receive code on archs with flush_dcache_page()
        xprtrdma: Double free in rpcrdma_sendctxs_create()
        xprtrdma: Fix error code in rpcrdma_buffer_create()
      b0efca46
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 4d5f6e02
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "A set of 17 fixes. Most of these are minor or trivial.
      
        The one fix that may be serious is the isci one: the bug can cause hba
        parameters to be set from uninitialized memory. I don't think it's
        exploitable, but you never know"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: cxgb4i: add wait_for_completion()
        scsi: qla1280: set 64bit coherent mask
        scsi: ufs: Fix geometry descriptor size
        scsi: megaraid_sas: Retry reads of outbound_intr_status reg
        scsi: qedi: Add ep_state for login completion on un-reachable targets
        scsi: ufs: Fix system suspend status
        scsi: qla2xxx: Use correct number of vectors for online CPUs
        scsi: hisi_sas: Set protection parameters prior to adding SCSI host
        scsi: tcmu: avoid cmd/qfull timers updated whenever a new cmd comes
        scsi: isci: initialize shost fully before calling scsi_add_host()
        scsi: lpfc: lpfc_sli: Mark expected switch fall-throughs
        scsi: smartpqi_init: fix boolean expression in pqi_device_remove_start
        scsi: core: Synchronize request queue PM status only on successful resume
        scsi: pm80xx: reduce indentation
        scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
        scsi: megaraid_sas: correct an info message
        scsi: target/iscsi: fix error msg typo when create lio_qr_cache failed
        scsi: sd: Fix cache_type_store()
      4d5f6e02
    • Linus Torvalds's avatar
      Merge tag 'for-linus-20190118' of git://git.kernel.dk/linux-block · 0facb892
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - block size setting fixes for loop/nbd (Jan Kara)
      
       - md bio_alloc_mddev() cleanup (Marcos)
      
       - Ensure we don't lose the REQ_INTEGRITY flag (Ming)
      
       - Two NVMe fixes by way of Christoph:
          - Fix NVMe IRQ calculation (Ming)
          - Uninitialized variable in nvmet-tcp (Sagi)
      
       - BFQ comment fix (Paolo)
      
       - License cleanup for recently added blk-mq-debugfs-zoned (Thomas)
      
      * tag 'for-linus-20190118' of git://git.kernel.dk/linux-block:
        block: Cleanup license notice
        nvme-pci: fix nvme_setup_irqs()
        nvmet-tcp: fix uninitialized variable access
        block: don't lose track of REQ_INTEGRITY flag
        blockdev: Fix livelocks on loop device
        nbd: Use set_blocksize() to set device blocksize
        md: Make bio_alloc_mddev use bio_alloc_bioset
        block, bfq: fix comments on __bfq_deactivate_entity
      0facb892
  2. Jan 19, 2019
    • Linus Torvalds's avatar
      Merge tag 'media/v5.0-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media · 2339e91d
      Linus Torvalds authored
      Pull media fixes from Mauro Carvalho Chehab:
      
       - a regression fix at v4l2 core, with affects multi-plane streams
      
       - a fix at vim2m driver
      
      * tag 'media/v5.0-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media:
        media: vim2m: only cancel work if it is for right context
        media: v4l: ioctl: Validate num_planes for debug messages
        media: v4l: ioctl: Validate num_planes before using it
        media: v4l2-ioctl: Clear only per-plane reserved fields
      2339e91d
    • Linus Torvalds's avatar
      Merge tag 'pci-v5.0-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci · d28f3e72
      Linus Torvalds authored
      Pull PCI fixes from Bjorn Helgaas::
      
       - Fix PCI kconfig menu organization (Rob Herring)
      
       - Fix pci_alloc_irq_vectors_affinity() error return to allow "reduce
         and retry" for drivers using IRQ sets (Ming Lei)
      
       - Fix "pci=disable_acs_redir" initdata use-after-free problem (Logan
         Gunthorpe)
      
      * tag 'pci-v5.0-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci:
        PCI: Fix __initdata issue with "pci=disable_acs_redir" parameter
        PCI/MSI: Return -ENOSPC from pci_alloc_irq_vectors_affinity()
        PCI: Fix PCI kconfig menu organization
      d28f3e72
    • Linus Torvalds's avatar
      Merge tag 'i3c/fixes-for-5.0-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux · 8b4fe58d
      Linus Torvalds authored
      Pull i3c fixes from Boris Brezillon:
      
       - Fix the error check on master->sysclk val in the Cadence driver
      
       - Fix reattach implementation in the Designware driver
      
      * tag 'i3c/fixes-for-5.0-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux:
        i3c: master: dw-i3c-master: fix i3c_attach/reattach
        i3c: master: Fix an error checking typo in 'cdns_i3c_master_probe()'
      8b4fe58d
    • Linus Torvalds's avatar
      Merge tag 'mtd/fixes-for-5.0-rc3' of git://git.infradead.org/linux-mtd · 3cdf680e
      Linus Torvalds authored
      Pull mtd fixes from Boris Brezillon:
       "Raw NAND changes:
      
         - jz4740: fix a compilation warning
      
         - fsmc: fix a regression introduced by ->select_chip() deprecation
      
         - denali: fix a regression introduced by NAND_KEEP_TIMINGS addition"
      
      * tag 'mtd/fixes-for-5.0-rc3' of git://git.infradead.org/linux-mtd:
        mtd: rawnand: denali: get ->setup_data_interface() working again
        mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem'
        mtd: rawnand: fsmc: Keep bank enable bit set
      3cdf680e
    • Linus Torvalds's avatar
      Merge tag 'regmap-fix-v5.0-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap · 6e4673b4
      Linus Torvalds authored
      Pull regmap fixes from Mark Brown:
       "The cleanups for the way we handle type information introduced during
        the merge window revealed that we'd been abusing the irq APIs for a
        long time, causing breakage for systems.
      
        This has a couple of minimal fixes for that which restore the previous
        behaviour for the time being, we'll fix it properly for v5.1 but
        that'd be a bit much to do as a bug fix"
      
      * tag 'regmap-fix-v5.0-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
        regmap-irq: do not write mask register if mask_base is zero
        regmap: regmap-irq: silently ignore unsupported type settings
      6e4673b4
    • Linus Torvalds's avatar
      Merge tag 'powerpc-5.0-3' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · c5b70980
      Linus Torvalds authored
      Pull powerpc fixes from Michael Ellerman:
       "A couple of weeks of fixes.
      
        There's one fix for an oops on Power9 machines with Open CAPI
        adapters.
      
        And a fix for probable memory corruption in some of the new NPU code,
        caught by smatch though and not seen in the wild.
      
        Plus a few other minor fixes.
      
        There's one non-fix which is the perf_regs change. That was sent
        during the merge window but I accidentally only merged the first of
        two patches in the series. It's been in linux-next so hopefully
        doesn't conflict with anything in acme's tree.
      
        Thanks to: Alexey Kardashevskiy, Andrew Donnellan, Breno Leitao,
        Christian Lamparter, Christophe Leroy, Dan Carpenter, Frederic Barrat,
        Greg Kurz, Jason A. Donenfeld, Madhavan Srinivasan"
      
      * tag 'powerpc-5.0-3' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        powerpc/syscalls: Fix syscall tracing
        powerpc/pseries: Fix build break due to pnv_npu2_init()
        powerpc/4xx/ocm: Fix fix for phys_addr_t printf warnings
        powerpc/powernv/npu: Fix oops in pnv_try_setup_npu_table_group()
        powerpc/tm: Limit TM code inside PPC_TRANSACTIONAL_MEM
        powerpc/8xx: fix setting of pagetable for Abatron BDI debug tool.
        powerpc/powernv/npu: Allocate enough memory in pnv_try_setup_npu_table_group()
        powerpc/perf: Update perf_regs structure to include MMCRA
      c5b70980
    • Linus Torvalds's avatar
      Merge tag 'for-linus-5.0-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · e6ec2fda
      Linus Torvalds authored
      Pull xen fixes from Juergen Gross:
      
       - Several fixes for the Xen pvcalls drivers (1 fix for the backend and
         8 for the frontend).
      
       - A fix for a rather longstanding bug in the Xen sched_clock()
         interface which led to weird time jumps when migrating the system.
      
       - A fix for avoiding accesses to x2apic MSRs in Xen PV guests.
      
      * tag 'for-linus-5.0-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        xen: Fix x86 sched_clock() interface for xen
        pvcalls-front: fix potential null dereference
        always clear the X2APIC_ENABLE bit for PV guest
        pvcalls-front: Avoid get_free_pages(GFP_KERNEL) under spinlock
        xen/pvcalls: remove set but not used variable 'intf'
        pvcalls-back: set -ENOTCONN in pvcalls_conn_back_read
        pvcalls-front: don't return error when the ring is full
        pvcalls-front: properly allocate sk
        pvcalls-front: don't try to free unallocated rings
        pvcalls-front: read all data before closing the connection
      e6ec2fda
    • Linus Torvalds's avatar
      Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 · dc6fef2c
      Linus Torvalds authored
      Pull crypto fixes from Herbert Xu:
       "This fixes the following issues:
         - Zero-length DMA mapping in caam
         - Invalidly mapping stack memory for DMA in talitos
         - Use after free in cavium/nitrox
         - Key parsing in authenc
         - Undefined shift in sm3
         - Bogus completion call in authencesn
         - SHA support detection in caam"
      
      * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
        crypto: sm3 - fix undefined shift by >= width of value
        crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK
        crypto: talitos - reorder code in talitos_edesc_alloc()
        crypto: adiantum - initialize crypto_spawn::inst
        crypto: cavium/nitrox - Use after free in process_response_list()
        crypto: authencesn - Avoid twice completion call in decrypt path
        crypto: caam - fix SHA support detection
        crypto: caam - fix zero-length buffer DMA mapping
        crypto: ccree - convert to use crypto_authenc_extractkeys()
        crypto: bcm - convert to use crypto_authenc_extractkeys()
        crypto: authenc - fix parsing key with misaligned rta_len
      dc6fef2c
    • Linus Torvalds's avatar
      Merge tag 'acpi-5.0-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 6e434bf2
      Linus Torvalds authored
      Pull ACPI fixes from Rafael Wysocki:
       "These fix an ACPI initialization ordering issue introduced in the 4.17
        time frame and causing functional problems to appear on multiple
        systems and fix some fallout of the recent change to enable building
        kernels with ACPI support and without PCI.
      
        Specifics:
      
         - Restore the ACPI initialization ordering changed implicitly by the
           module-level AML handling rework during the 4.17 development cycle
           that caused the EC address space handler based on information from
           ECDT to be set up before loading AML definition blocks, making it
           effectively not accessible by AML on some systems that don't work
           as expected any more (Rafael Wysocki).
      
         - Add direct dependencies on PCI to Kconfig in multiple places for
           code that depends on both ACPI and PCI, but the PCI dependency was
           implicitly satisfied by the ACPI dependency before, to prevent
           invalid configurations from being created, for example by
           randconfig (Sinan Kaya)"
      
      * tag 'acpi-5.0-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPI: EC: Look for ECDT EC after calling acpi_load_tables()
        drivers: thermal: int340x_thermal: Make PCI dependency explicit
        x86/intel/lpss: Make PCI dependency explicit
        platform/x86: apple-gmux: Make PCI dependency explicit
        platform/x86: intel_pmc: Make PCI dependency explicit
        platform/x86: intel_ips: make PCI dependency explicit
        vga-switcheroo: make PCI dependency explicit
        ata: pata_acpi: Make PCI dependency explicit
        ACPI / LPSS: Make PCI dependency explicit
      6e434bf2
    • Linus Torvalds's avatar
      Merge tag 'fbdev-v5.0-rc3' of git://github.com/bzolnier/linux · 2a8cbf2a
      Linus Torvalds authored
      Pull fbdev fixes from Bartlomiej Zolnierkiewicz:
      
       - fix stack memory leak in omap2fb driver (Vlad Tsyrklevich)
      
       - fix OF node name handling v4.20 regression in offb driver (Rob
         Herring)
      
       - convert CONFIG_FB_LOGO_CENTER config option added in v5.0-rc1 into a
         kernel parameter (Peter Rosin)
      
      * tag 'fbdev-v5.0-rc3' of git://github.com/bzolnier/linux:
        fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line option
        fbdev: offb: Fix OF node name handling
        omap2fb: Fix stack memory disclosure
      2a8cbf2a
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2019-01-18-1' of git://anongit.freedesktop.org/drm/drm · c3653ebd
      Linus Torvalds authored
      Pull drm update from Dave Airlie:
       "Add nouveau TU102 (RTX 2080 Ti) support"
      
      * tag 'drm-fixes-2019-01-18-1' of git://anongit.freedesktop.org/drm/drm:
        drm/nouveau/core: recognise TU102
      c3653ebd
  3. Jan 18, 2019
  4. Jan 17, 2019
    • David Howells's avatar
      afs: Fix race in async call refcounting · 34fa4761
      David Howells authored
      There's a race between afs_make_call() and afs_wake_up_async_call() in the
      case that an error is returned from rxrpc_kernel_send_data() after it has
      queued the final packet.
      
      afs_make_call() will try and clean up the mess, but the call state may have
      been moved on thereby causing afs_process_async_call() to also try and to
      delete the call.
      
      Fix this by:
      
       (1) Getting an extra ref for an asynchronous call for the call itself to
           hold.  This makes sure the call doesn't evaporate on us accidentally
           and will allow the call to be retained by the caller in a future
           patch.  The ref is released on leaving afs_make_call() or
           afs_wait_for_call_to_complete().
      
       (2) In the event of an error from rxrpc_kernel_send_data():
      
           (a) Don't set the call state to AFS_CALL_COMPLETE until *after* the
           	 call has been aborted and ended.  This prevents
           	 afs_deliver_to_call() from doing anything with any notifications
           	 it gets.
      
           (b) Explicitly end the call immediately to prevent further callbacks.
      
           (c) Cancel any queued async_work and wait for the work if it's
           	 executing.  This allows us to be sure the race won't recur when we
           	 change the state.  We put the work queue's ref on the call if we
           	 managed to cancel it.
      
           (d) Put the call's ref that we got in (1).  This belongs to us as long
           	 as the call is in state AFS_CALL_CL_REQUESTING.
      
      Fixes: 341f741f
      
       ("afs: Refcount the afs_call struct")
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      34fa4761
    • David Howells's avatar
      afs: Provide a function to get a ref on a call · 7a75b007
      David Howells authored
      
      
      Provide a function to get a reference on an afs_call struct.
      
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      7a75b007
    • David Howells's avatar
      afs: Fix key refcounting in file locking code · 59d49076
      David Howells authored
      Fix the refcounting of the authentication keys in the file locking code.
      The vnode->lock_key member points to a key on which it expects to be
      holding a ref, but it isn't always given an extra ref, however.
      
      Fixes: 0fafdc9f
      
       ("afs: Fix file locking")
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      59d49076
    • Marc Dionne's avatar
      afs: Don't set vnode->cb_s_break in afs_validate() · 4882a27c
      Marc Dionne authored
      A cb_interest record is not necessarily attached to the vnode on entry to
      afs_validate(), which can cause an oops when we try to bring the vnode's
      cb_s_break up to date in the default case (ie. no current callback promise
      and the vnode has not been deleted).
      
      Fix this by simply removing the line, as vnode->cb_s_break will be set when
      needed by afs_register_server_cb_interest() when we next get a callback
      promise from RPC call.
      
      The oops looks something like:
      
          BUG: unable to handle kernel NULL pointer dereference at 0000000000000018
          ...
          RIP: 0010:afs_validate+0x66/0x250 [kafs]
          ...
          Call Trace:
           afs_d_revalidate+0x8d/0x340 [kafs]
           ? __d_lookup+0x61/0x150
           lookup_dcache+0x44/0x70
           ? lookup_dcache+0x44/0x70
           __lookup_hash+0x24/0xa0
           do_unlinkat+0x11d/0x2c0
           __x64_sys_unlink+0x23/0x30
           do_syscall_64+0x4d/0xf0
           entry_SYSCALL_64_after_hwframe+0x44/0xa9
      
      Fixes: ae3b7361
      
       ("afs: Fix validation/callback interaction")
      Signed-off-by: default avatarMarc Dionne <marc.dionne@auristor.com>
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      4882a27c
    • Logan Gunthorpe's avatar
      PCI: Fix __initdata issue with "pci=disable_acs_redir" parameter · d2fd6e81
      Logan Gunthorpe authored
      The disable_acs_redir parameter stores a pointer to the string passed to
      pci_setup().  However, the string passed to PCI setup is actually a
      temporary copy allocated in static __initdata memory.  After init, once the
      memory is freed, it is no longer valid to reference this pointer.
      
      This bug was noticed in v5.0-rc1 after a change in commit c5eb1190
      ("PCI / PM: Allow runtime PM without callback functions") caused
      pci_disable_acs_redir() to be called during shutdown which manifested
      as an unable to handle kernel paging request at:
      
        RIP: 0010:pci_enable_acs+0x3f/0x1e0
        Call Trace:
           pci_restore_state.part.44+0x159/0x3c0
           pci_restore_standard_config+0x33/0x40
           pci_pm_runtime_resume+0x2b/0xd0
           ? pci_restore_standard_config+0x40/0x40
           __rpm_callback+0xbc/0x1b0
           rpm_callback+0x1f/0x70
           ? pci_restore_standard_config+0x40/0x40
            rpm_resume+0x4f9/0x710
           ? pci_conf1_read+0xb6/0xf0
           ? pci_conf1_write+0xb2/0xe0
           __pm_runtime_resume+0x47/0x70
           pci_device_shutdown+0x1e/0x60
           device_shutdown+0x14a/0x1f0
           kernel_restart+0xe/0x50
           __do_sys_reboot+0x1ee/0x210
           ? __fput+0x144/0x1d0
           do_writev+0x5e/0xf0
           ? do_writev+0x5e/0xf0
           do_syscall_64+0x48/0xf0
           entry_SYSCALL_64_after_hwframe+0x44/0xa9
      
      It was also likely possible to trigger this bug when hotplugging PCI
      devices.
      
      To fix this, instead of storing a pointer, we use kstrdup() to copy the
      disable_acs_redir_param to its own buffer which will never be freed.
      
      Fixes: aaca43fd
      
       ("PCI: Add "pci=disable_acs_redir=" parameter for peer-to-peer support")
      Tested-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
      Signed-off-by: default avatarLogan Gunthorpe <logang@deltatee.com>
      Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
      Reviewed-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
      d2fd6e81
    • Masahiro Yamada's avatar
      kbuild: mark prepare0 as PHONY to fix external module build · e00d8880
      Masahiro Yamada authored
      Commit c3ff2a51 ("powerpc/32: add stack protector support")
      caused kernel panic on PowerPC when an external module is used with
      CONFIG_STACKPROTECTOR because the 'prepare' target was not executed
      for the external module build.
      
      Commit e07db28e ("kbuild: fix single target build for external
      module") turned it into a build error because the 'prepare' target is
      now executed but the 'prepare0' target is missing for the external
      module build.
      
      External module on arm/arm64 with CONFIG_STACKPROTECTOR_PER_TASK is
      also broken in the same way.
      
      Move 'PHONY += prepare0' to the common place. GNU Make is fine with
      missing rule for phony targets. I also removed the comment which is
      wrong irrespective of this commit.
      
      I minimize the change so it can be easily backported to 4.20.x
      
      To fix v4.20, please backport e07db28e ("kbuild: fix single target
      build for external module"), and then this commit.
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=201891
      Fixes: e07db28e ("kbuild: fix single target build for external module")
      Fixes: c3ff2a51 ("powerpc/32: add stack protector support")
      Fixes: 189af465 ("ARM: smp: add support for per-task stack canaries")
      Fixes: 0a1213fa
      
       ("arm64: enable per-task stack canaries")
      Cc: linux-stable <stable@vger.kernel.org> # v4.20
      Reported-by: default avatarSamuel Holland <samuel@sholland.org>
      Reported-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Acked-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
      Tested-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
      e00d8880
    • Masahiro Yamada's avatar
      openrisc: remove unneeded code in arch/openrisc/Makefile · 1b504a7b
      Masahiro Yamada authored
      
      
       - LDFLAGS_vmlinux is cleared by the top Makefile
      
       - 'all: vmlinux' is specified by the top Makefile
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      1b504a7b