Skip to content
  1. Aug 11, 2019
  2. Aug 10, 2019
    • Linus Torvalds's avatar
      Merge tag 'kbuild-fixes-v5.3-3' of... · 451577f3
      Linus Torvalds authored
      Merge tag 'kbuild-fixes-v5.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
      
      Pull Kbuild fixes from Masahiro Yamada:
      
       - revive single target %.ko
      
       - do not create built-in.a where it is unneeded
      
       - do not create modules.order where it is unneeded
      
       - show a warning if subdir-y/m is used to visit a module Makefile
      
      * tag 'kbuild-fixes-v5.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        kbuild: show hint if subdir-y/m is used to visit module Makefile
        kbuild: generate modules.order only in directories visited by obj-y/m
        kbuild: fix false-positive need-builtin calculation
        kbuild: revive single target %.ko
      451577f3
    • Gustavo A. R. Silva's avatar
      ARM: ep93xx: Mark expected switch fall-through · 1f7585f3
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warnings (Building: arm-ep93xx_defconfig arm):
      
      arch/arm/mach-ep93xx/crunch.c: In function 'crunch_do':
      arch/arm/mach-ep93xx/crunch.c:46:3: warning: this statement may
      fall through [-Wimplicit-fallthrough=]
            memset(crunch_state, 0, sizeof(*crunch_state));
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         arch/arm/mach-ep93xx/crunch.c:53:2: note: here
           case THREAD_NOTIFY_EXIT:
           ^~~~
      
      Notice that, in this particular case, the code comment is
      modified in accordance with what GCC is expecting to find.
      
      Reported-by: default avatarkbuild test robot <lkp@intel.com>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      1f7585f3
    • Gustavo A. R. Silva's avatar
      scsi: fas216: Mark expected switch fall-throughs · fccf01b6
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warnings (Building: rpc_defconfig arm):
      
      drivers/scsi/arm/fas216.c: In function ‘fas216_disconnect_intr’:
      drivers/scsi/arm/fas216.c:913:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (fas216_get_last_msg(info, info->scsi.msgin_fifo) == ABORT) {
            ^
      drivers/scsi/arm/fas216.c:919:2: note: here
        default:    /* huh?     */
        ^~~~~~~
      drivers/scsi/arm/fas216.c: In function ‘fas216_kick’:
      drivers/scsi/arm/fas216.c:1959:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         fas216_allocate_tag(info, SCpnt);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/scsi/arm/fas216.c:1960:2: note: here
        case TYPE_OTHER:
        ^~~~
      drivers/scsi/arm/fas216.c: In function ‘fas216_busservice_intr’:
      drivers/scsi/arm/fas216.c:1413:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         fas216_stoptransfer(info);
         ^~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/scsi/arm/fas216.c:1414:2: note: here
        case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status       */
        ^~~~
      drivers/scsi/arm/fas216.c:1424:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         fas216_stoptransfer(info);
         ^~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/scsi/arm/fas216.c:1425:2: note: here
        case STATE(STAT_MESGIN, PHASE_COMMAND): /* Command -> Message In */
        ^~~~
      drivers/scsi/arm/fas216.c: In function ‘fas216_funcdone_intr’:
      drivers/scsi/arm/fas216.c:1573:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if ((stat & STAT_BUSMASK) == STAT_MESGIN) {
            ^
      drivers/scsi/arm/fas216.c:1579:2: note: here
        default:
        ^~~~~~~
      drivers/scsi/arm/fas216.c: In function ‘fas216_handlesync’:
      drivers/scsi/arm/fas216.c:605:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
         info->scsi.phase = PHASE_MSGOUT_EXPECT;
         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
      drivers/scsi/arm/fas216.c:607:2: note: here
        case async:
        ^~~~
      
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      fccf01b6
    • Gustavo A. R. Silva's avatar
      pcmcia: db1xxx_ss: Mark expected switch fall-throughs · 5f163f33
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings (Building: db1xxx_defconfig mips):
      
      drivers/pcmcia/db1xxx_ss.c:257:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/pcmcia/db1xxx_ss.c:269:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      5f163f33
    • Gustavo A. R. Silva's avatar
      video: fbdev: omapfb_main: Mark expected switch fall-throughs · 70a2783c
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warning (Building: omap1_defconfig arm):
      
      drivers/watchdog/wdt285.c:170:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/watchdog/ar7_wdt.c:237:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      70a2783c
    • Gustavo A. R. Silva's avatar
      watchdog: riowd: Mark expected switch fall-through · 40ad2de3
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings (Building: sparc64):
      
      drivers/watchdog/riowd.c: In function ‘riowd_ioctl’:
      drivers/watchdog/riowd.c:136:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         riowd_writereg(p, riowd_timeout, WDTO_INDEX);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/watchdog/riowd.c:139:2: note: here
        case WDIOC_GETTIMEOUT:
        ^~~~
      
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      40ad2de3
    • Gustavo A. R. Silva's avatar
      s390/net: Mark expected switch fall-throughs · 7b733151
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings (Building: s390):
      
      drivers/s390/net/ctcm_fsms.c: In function ‘ctcmpc_chx_attnbusy’:
      drivers/s390/net/ctcm_fsms.c:1703:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (grp->changed_side == 1) {
            ^
      drivers/s390/net/ctcm_fsms.c:1707:2: note: here
        case MPCG_STATE_XID0IOWAIX:
        ^~~~
      
      drivers/s390/net/ctcm_mpc.c: In function ‘ctc_mpc_alloc_channel’:
      drivers/s390/net/ctcm_mpc.c:358:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (callback)
            ^
      drivers/s390/net/ctcm_mpc.c:360:2: note: here
        case MPCG_STATE_XID0IOWAIT:
        ^~~~
      
      drivers/s390/net/ctcm_mpc.c: In function ‘mpc_action_timeout’:
      drivers/s390/net/ctcm_mpc.c:1469:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if ((fsm_getstate(rch->fsm) == CH_XID0_PENDING) &&
            ^
      drivers/s390/net/ctcm_mpc.c:1472:2: note: here
        default:
        ^~~~~~~
      drivers/s390/net/ctcm_mpc.c: In function ‘mpc_send_qllc_discontact’:
      drivers/s390/net/ctcm_mpc.c:2087:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (grp->estconnfunc) {
            ^
      drivers/s390/net/ctcm_mpc.c:2092:2: note: here
        case MPCG_STATE_FLOWC:
        ^~~~
      
      drivers/s390/net/qeth_l2_main.c: In function ‘qeth_l2_process_inbound_buffer’:
      drivers/s390/net/qeth_l2_main.c:328:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
          if (IS_OSN(card)) {
             ^
      drivers/s390/net/qeth_l2_main.c:337:3: note: here
         default:
         ^~~~~~~
      
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      7b733151
    • Gustavo A. R. Silva's avatar
      crypto: ux500/crypt: Mark expected switch fall-throughs · 3d86c7ad
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warning (Building: arm):
      
      drivers/crypto/ux500/cryp/cryp.c: In function ‘cryp_save_device_context’:
      drivers/crypto/ux500/cryp/cryp.c:316:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
         ctx->key_4_r = readl_relaxed(&src_reg->key_4_r);
      drivers/crypto/ux500/cryp/cryp.c:318:2: note: here
        case CRYP_KEY_SIZE_192:
        ^~~~
      drivers/crypto/ux500/cryp/cryp.c:320:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
         ctx->key_3_r = readl_relaxed(&src_reg->key_3_r);
      drivers/crypto/ux500/cryp/cryp.c:322:2: note: here
        case CRYP_KEY_SIZE_128:
        ^~~~
      drivers/crypto/ux500/cryp/cryp.c:324:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
         ctx->key_2_r = readl_relaxed(&src_reg->key_2_r);
      drivers/crypto/ux500/cryp/cryp.c:326:2: note: here
        default:
        ^~~~~~~
      In file included from ./include/linux/io.h:13:0,
                       from drivers/crypto/ux500/cryp/cryp_p.h:14,
                       from drivers/crypto/ux500/cryp/cryp.c:15:
      drivers/crypto/ux500/cryp/cryp.c: In function ‘cryp_restore_device_context’:
      ./arch/arm/include/asm/io.h:92:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
       #define __raw_writel __raw_writel
                            ^
      ./arch/arm/include/asm/io.h:299:29: note: in expansion of macro ‘__raw_writel’
       #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
                                   ^~~~~~~~~~~~
      drivers/crypto/ux500/cryp/cryp.c:363:3: note: in expansion of macro ‘writel_relaxed’
         writel_relaxed(ctx->key_4_r, &reg->key_4_r);
         ^~~~~~~~~~~~~~
      drivers/crypto/ux500/cryp/cryp.c:365:2: note: here
        case CRYP_KEY_SIZE_192:
        ^~~~
      In file included from ./include/linux/io.h:13:0,
                       from drivers/crypto/ux500/cryp/cryp_p.h:14,
                       from drivers/crypto/ux500/cryp/cryp.c:15:
      ./arch/arm/include/asm/io.h:92:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
       #define __raw_writel __raw_writel
                            ^
      ./arch/arm/include/asm/io.h:299:29: note: in expansion of macro ‘__raw_writel’
       #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
                                   ^~~~~~~~~~~~
      drivers/crypto/ux500/cryp/cryp.c:367:3: note: in expansion of macro ‘writel_relaxed’
         writel_relaxed(ctx->key_3_r, &reg->key_3_r);
         ^~~~~~~~~~~~~~
      drivers/crypto/ux500/cryp/cryp.c:369:2: note: here
        case CRYP_KEY_SIZE_128:
        ^~~~
      In file included from ./include/linux/io.h:13:0,
                       from drivers/crypto/ux500/cryp/cryp_p.h:14,
                       from drivers/crypto/ux500/cryp/cryp.c:15:
      ./arch/arm/include/asm/io.h:92:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
       #define __raw_writel __raw_writel
                            ^
      ./arch/arm/include/asm/io.h:299:29: note: in expansion of macro ‘__raw_writel’
       #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
                                   ^~~~~~~~~~~~
      drivers/crypto/ux500/cryp/cryp.c:371:3: note: in expansion of macro ‘writel_relaxed’
         writel_relaxed(ctx->key_2_r, &reg->key_2_r);
         ^~~~~~~~~~~~~~
      drivers/crypto/ux500/cryp/cryp.c:373:2: note: here
        default:
        ^~~~~~~
      
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      3d86c7ad
    • Gustavo A. R. Silva's avatar
      watchdog: wdt977: Mark expected switch fall-through · d51c6163
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warning (Building: arm):
      
      drivers/watchdog/wdt977.c: In function ‘wdt977_ioctl’:
        LD [M]  drivers/media/platform/vicodec/vicodec.o
      drivers/watchdog/wdt977.c:400:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         wdt977_keepalive();
         ^~~~~~~~~~~~~~~~~~
      drivers/watchdog/wdt977.c:403:2: note: here
        case WDIOC_GETTIMEOUT:
        ^~~~
      
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      d51c6163
    • Gustavo A. R. Silva's avatar
      watchdog: scx200_wdt: Mark expected switch fall-through · 24f21618
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warning (Building: i386):
      
      drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’:
      drivers/watchdog/scx200_wdt.c:188:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         scx200_wdt_ping();
         ^~~~~~~~~~~~~~~~~
      drivers/watchdog/scx200_wdt.c:189:2: note: here
        case WDIOC_GETTIMEOUT:
        ^~~~
      
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      24f21618
    • Gustavo A. R. Silva's avatar
      watchdog: Mark expected switch fall-throughs · d259f94f
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings:
      
      drivers/watchdog/ar7_wdt.c: warning: this statement may fall
      through [-Wimplicit-fallthrough=]:  => 237:3
      drivers/watchdog/pcwd.c: warning: this statement may fall
      through [-Wimplicit-fallthrough=]:  => 653:3
      drivers/watchdog/sb_wdog.c: warning: this statement may fall
      through [-Wimplicit-fallthrough=]:  => 204:3
      drivers/watchdog/wdt.c: warning: this statement may fall
      through [-Wimplicit-fallthrough=]:  => 391:3
      
      Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      d259f94f
    • Gustavo A. R. Silva's avatar
      ARM: signal: Mark expected switch fall-through · e9d81fc5
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warning:
      
      arch/arm/kernel/signal.c: In function 'do_signal':
      arch/arm/kernel/signal.c:598:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
          restart -= 2;
          ~~~~~~~~^~~~
      arch/arm/kernel/signal.c:599:3: note: here
         case -ERESTARTNOHAND:
         ^~~~
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      e9d81fc5
    • Gustavo A. R. Silva's avatar
      mfd: omap-usb-host: Mark expected switch fall-throughs · 90397820
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings:
      
      drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_resume':
      drivers/mfd/omap-usb-host.c:303:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
          if (!IS_ERR(omap->hsic480m_clk[i])) {
             ^
      drivers/mfd/omap-usb-host.c:313:3: note: here
         case OMAP_EHCI_PORT_MODE_TLL:
         ^~~~
      drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_suspend':
      drivers/mfd/omap-usb-host.c:345:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
          if (!IS_ERR(omap->hsic480m_clk[i]))
             ^
      drivers/mfd/omap-usb-host.c:349:3: note: here
         case OMAP_EHCI_PORT_MODE_TLL:
         ^~~~
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      90397820
    • Gustavo A. R. Silva's avatar
      mfd: db8500-prcmu: Mark expected switch fall-throughs · 795952d9
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings:
      
      drivers/mfd/db8500-prcmu.c: In function 'dsiclk_rate':
      drivers/mfd/db8500-prcmu.c:1592:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
         div *= 2;
         ~~~~^~~~
      drivers/mfd/db8500-prcmu.c:1593:2: note: here
        case PRCM_DSI_PLLOUT_SEL_PHI_2:
        ^~~~
      drivers/mfd/db8500-prcmu.c:1594:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
         div *= 2;
         ~~~~^~~~
      drivers/mfd/db8500-prcmu.c:1595:2: note: here
        case PRCM_DSI_PLLOUT_SEL_PHI:
        ^~~~
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      795952d9
    • Gustavo A. R. Silva's avatar
      ARM: OMAP: dma: Mark expected switch fall-throughs · 3da6bd94
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings:
      
      arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_burst_mode':
      arch/arm/plat-omap/dma.c:384:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (dma_omap2plus()) {
            ^
      arch/arm/plat-omap/dma.c:393:2: note: here
        case OMAP_DMA_DATA_BURST_16:
        ^~~~
      arch/arm/plat-omap/dma.c:394:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (dma_omap2plus()) {
            ^
      arch/arm/plat-omap/dma.c:402:2: note: here
        default:
        ^~~~~~~
      arch/arm/plat-omap/dma.c: In function 'omap_set_dma_dest_burst_mode':
      arch/arm/plat-omap/dma.c:473:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (dma_omap2plus()) {
            ^
      arch/arm/plat-omap/dma.c:481:2: note: here
        default:
        ^~~~~~~
      
      Notice that, in this particular case, the code comment is
      modified in accordance with what GCC is expecting to find.
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      3da6bd94
    • Gustavo A. R. Silva's avatar
      ARM: alignment: Mark expected switch fall-throughs · e7c0c9f6
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings:
      
      arch/arm/mm/alignment.c: In function 'thumb2arm':
      arch/arm/mm/alignment.c:688:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if ((tinstr & (3 << 9)) == 0x0400) {
            ^
      arch/arm/mm/alignment.c:700:2: note: here
        default:
        ^~~~~~~
      arch/arm/mm/alignment.c: In function 'do_alignment_t32_to_handler':
      arch/arm/mm/alignment.c:753:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
         poffset->un = (tinst2 & 0xff) << 2;
         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
      arch/arm/mm/alignment.c:754:2: note: here
        case 0xe940:
        ^~~~
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      e7c0c9f6
    • Gustavo A. R. Silva's avatar
      ARM: tegra: Mark expected switch fall-through · 9b76ad3a
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warning:
      
      arch/arm/mach-tegra/reset.c: In function 'tegra_cpu_reset_handler_enable':
      arch/arm/mach-tegra/reset.c:72:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         tegra_cpu_reset_handler_set(reset_address);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      arch/arm/mach-tegra/reset.c:74:2: note: here
        case 0:
        ^~~~
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      9b76ad3a
    • Gustavo A. R. Silva's avatar
      ARM/hw_breakpoint: Mark expected switch fall-throughs · 2d0e988d
      Gustavo A. R. Silva authored
      
      
      Mark switch cases where we are expecting to fall through.
      
      This patch fixes the following warnings:
      
      arch/arm/kernel/hw_breakpoint.c: In function 'hw_breakpoint_arch_parse':
      arch/arm/kernel/hw_breakpoint.c:609:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (hw->ctrl.len == ARM_BREAKPOINT_LEN_2)
            ^
      arch/arm/kernel/hw_breakpoint.c:611:2: note: here
        case 3:
        ^~~~
      arch/arm/kernel/hw_breakpoint.c:613:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (hw->ctrl.len == ARM_BREAKPOINT_LEN_1)
            ^
      arch/arm/kernel/hw_breakpoint.c:615:2: note: here
        default:
        ^~~~~~~
      arch/arm/kernel/hw_breakpoint.c: In function 'arch_build_bp_info':
      arch/arm/kernel/hw_breakpoint.c:544:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if ((hw->ctrl.type != ARM_BREAKPOINT_EXECUTE)
            ^
      arch/arm/kernel/hw_breakpoint.c:547:2: note: here
        default:
        ^~~~~~~
      In file included from include/linux/kernel.h:11,
                       from include/linux/list.h:9,
                       from include/linux/preempt.h:11,
                       from include/linux/hardirq.h:5,
                       from arch/arm/kernel/hw_breakpoint.c:16:
      arch/arm/kernel/hw_breakpoint.c: In function 'hw_breakpoint_pending':
      include/linux/compiler.h:78:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
       # define unlikely(x) __builtin_expect(!!(x), 0)
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
      include/asm-generic/bug.h:136:2: note: in expansion of macro 'unlikely'
        unlikely(__ret_warn_on);     \
        ^~~~~~~~
      arch/arm/kernel/hw_breakpoint.c:863:3: note: in expansion of macro 'WARN'
         WARN(1, "Asynchronous watchpoint exception taken. Debugging results may be unreliable\n");
         ^~~~
      arch/arm/kernel/hw_breakpoint.c:864:2: note: here
        case ARM_ENTRY_SYNC_WATCHPOINT:
        ^~~~
      arch/arm/kernel/hw_breakpoint.c: In function 'core_has_os_save_restore':
      arch/arm/kernel/hw_breakpoint.c:910:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (oslsr & ARM_OSLSR_OSLM0)
            ^
      arch/arm/kernel/hw_breakpoint.c:912:2: note: here
        default:
        ^~~~~~~
      
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      2d0e988d
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 7f20fd23
      Linus Torvalds authored
      Pull kvm fixes from Paolo Bonzini:
       "Bugfixes (arm and x86) and cleanups"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        selftests: kvm: Adding config fragments
        KVM: selftests: Update gitignore file for latest changes
        kvm: remove unnecessary PageReserved check
        KVM: arm/arm64: vgic: Reevaluate level sensitive interrupts on enable
        KVM: arm: Don't write junk to CP15 registers on reset
        KVM: arm64: Don't write junk to sysregs on reset
        KVM: arm/arm64: Sync ICH_VMCR_EL2 back when about to block
        x86: kvm: remove useless calls to kvm_para_available
        KVM: no need to check return value of debugfs_create functions
        KVM: remove kvm_arch_has_vcpu_debugfs()
        KVM: Fix leak vCPU's VMCS value into other pCPU
        KVM: Check preempted_in_kernel for involuntary preemption
        KVM: LAPIC: Don't need to wakeup vCPU twice afer timer fire
        arm64: KVM: hyp: debug-sr: Mark expected switch fall-through
        KVM: arm64: Update kvm_arm_ex...
      7f20fd23
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input · 15abf142
      Linus Torvalds authored
      Pull input updates from Dmitry Torokhov:
      
       - newer systems with Elan touchpads will be switched over to SMBus
      
       - HP Spectre X360 will be using SMbus/RMI4
      
       - checks for invalid USB descriptors in kbtab and iforce
      
       - build fixes for applespi driver (misconfigs)
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
        Input: iforce - add sanity checks
        Input: applespi - use struct_size() helper
        Input: kbtab - sanity check for endpoint type
        Input: usbtouchscreen - initialize PM mutex before using it
        Input: applespi - add dependency on LEDS_CLASS
        Input: synaptics - enable RMI mode for HP Spectre X360
        Input: elantech - annotate fall-through case in elantech_use_host_notify()
        Input: elantech - enable SMBus on new (2018+) systems
        Input: applespi - fix trivial typo in struct description
        Input: applespi - select CRC16 module
        Input: applespi - fix warnings detected by sparse
      15abf142
    • Masahiro Yamada's avatar
      kbuild: show hint if subdir-y/m is used to visit module Makefile · c07d8d47
      Masahiro Yamada authored
      Since commit ff9b45c5
      
       ("kbuild: modpost: read modules.order instead
      of $(MODVERDIR)/*.mod"), a module is no longer built in the following
      pattern:
      
        [Makefile]
        subdir-y := some-module
      
        [some-module/Makefile]
        obj-m := some-module.o
      
      You cannot write Makefile this way in upstream because modules.order is
      not correctly generated. subdir-y is used to descend to a sub-directory
      that builds tools, device trees, etc.
      
      For external modules, the modules order does not matter. So, the
      Makefile above was known to work.
      
      I believe the Makefile should be re-written as follows:
      
        [Makefile]
        obj-m := some-module/
      
        [some-module/Makefile]
        obj-m := some-module.o
      
      However, people will have no idea if their Makefile suddenly stops
      working. In fact, I received questions from multiple people.
      
      Show a warning for a while if obj-m is specified in a Makefile visited
      by subdir-y or subdir-m.
      
      I touched the %/ rule to avoid false-positive warnings for the single
      target.
      
      Cc: Jan Kiszka <jan.kiszka@siemens.com>
      Cc: Tom Stonecypher <thomas.edwardx.stonecypher@intel.com>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Tested-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
      c07d8d47
    • Masahiro Yamada's avatar
      kbuild: generate modules.order only in directories visited by obj-y/m · 4f2c8f30
      Masahiro Yamada authored
      
      
      The modules.order files in directories visited by the chain of obj-y
      or obj-m are merged to the upper-level ones, and become parts of the
      top-level modules.order. On the other hand, there is no need to
      generate modules.order in directories visited by subdir-y or subdir-m
      since they would become orphan anyway.
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      4f2c8f30
    • Masahiro Yamada's avatar
      kbuild: fix false-positive need-builtin calculation · d9f78edf
      Masahiro Yamada authored
      
      
      The current implementation of need-builtin is false-positive,
      for example, in the following Makefile:
      
        obj-m := foo/
        obj-y := foo/bar/
      
      ..., where foo/built-in.a is not required.
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      d9f78edf
    • Masahiro Yamada's avatar
      kbuild: revive single target %.ko · 47801c97
      Masahiro Yamada authored
      I removed the single target %.ko in commit ff9b45c5 ("kbuild:
      modpost: read modules.order instead of $(MODVERDIR)/*.mod") because
      the modpost stage does not work reliably. For instance, the module
      dependency, modversion, etc. do not work if we lack symbol information
      from the other modules.
      
      Yet, some people still want to build only one module in their interest,
      and it may be still useful if it is used within those limitations.
      
      Fixes: ff9b45c5
      
       ("kbuild: modpost: read modules.order instead of $(MODVERDIR)/*.mod")
      Reported-by: default avatarDon Brace <don.brace@microsemi.com>
      Reported-by: default avatarArend Van Spriel <arend.vanspriel@broadcom.com>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      47801c97
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2019-08-09' of git://anongit.freedesktop.org/drm/drm · 2226fb57
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Usual fixes roundup. Nothing too crazy or serious, one non-released
        ioctl is removed in the amdkfd driver.
      
        core:
         - mode parser strncpy fix
      
        i915:
         - GLK DSI escape clock setting
         - HDCP memleak fix
      
        tegra:
         - one gpiod/of regression fix
      
        amdgpu:
         - fix VCN to handle the latest navi10 firmware
         - fix for fan control on navi10
         - properly handle SMU metrics table on navi10
         - fix a resume regression on Stoney
         - kfd revert a GWS ioctl
      
        vmwgfx:
         - memory leak fix
      
        rockchip:
         - suspend fix"
      
      * tag 'drm-fixes-2019-08-09' of git://anongit.freedesktop.org/drm/drm:
        drm/vmwgfx: fix memory leak when too many retries have occurred
        Revert "drm/amdkfd: New IOCTL to allocate queue GWS"
        Revert "drm/amdgpu: fix transform feedback GDS hang on gfx10 (v2)"
        drm/amdgpu: pin the csb buffer on hw init for gfx v8
        drm/rockchip: Suspend DP late
        drm/i915: Fix wrong escape clock divisor init for GLK
        drm/i915: fix possible memory leak in intel_hdcp_auth_downstream()
        drm/modes: Fix unterminated strncpy
        drm/amd/powerplay: correct navi10 vcn powergate
        drm/amd/powerplay: honor hw limit on fetching metrics data for navi10
        drm/amd/powerplay: Allow changing of fan_control in smu_v11_0
        drm/amd/amdgpu/vcn_v2_0: Move VCN 2.0 specific dec ring test to vcn_v2_0
        drm/amd/amdgpu/vcn_v2_0: Mark RB commands as KMD commands
        drm/tegra: Fix gpiod_get_from_of_node() regression
      2226fb57
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 15a555a4
      Linus Torvalds authored
      Pull arm64 fix from Catalin Marinas:
       "Fix bad_pte warning caused by pte_mkdevmap() not setting PTE_SPECIAL"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64
      15a555a4
    • Linus Torvalds's avatar
      Merge tag 's390-5.3-5' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · cb7ef4bc
      Linus Torvalds authored
      Pull s390 fixes from Vasily Gorbik:
      
       - Map vdso also for statically linked binaries like all other
         architectures.
      
       - Fix no .bss usage compile-time check to account common objects with
         the help of binutils size tool. Top level Makefile change acked-by
         Masahiro.
      
       - A fix to make perf happy with _etext symbol type.
      
       - Fix dump_pagetables which is broken since p*d_offset implementation
         change to comply with mm/gup.c expectations.
      
       - Revert memory sharing for diag calls in protected virtualization,
         since this is not required after all.
      
       - Couple of other minor code cleanups.
      
      * tag 's390-5.3-5' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
        s390/vdso: map vdso also for statically linked binaries
        s390/build: use size command to perform empty .bss check
        kbuild: add OBJSIZE variable for the size tool
        s390: put _stext and _etext into .text section
        s390/head64: cleanup unused labels
        s390/unwind: remove stack recursion warning
        s390/setup: adjust start_code of init_mm to _text
        s390/mm: fix dump_pagetables top level page table walking
        s390/protvirt: avoid memory sharing for diag 308 set/store
      cb7ef4bc
    • Linus Torvalds's avatar
      Merge tag 'for-linus-20190809' of git://git.kernel.dk/linux-block · 50e73a4a
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - Revert of a bcache patch that caused an oops for some (Coly)
      
       - ata rb532 unused warning fix (Gustavo)
      
       - AoE kernel crash fix (He)
      
       - Error handling fixup for blkdev_get() (Jan)
      
       - libata read/write translation and SFF PIO fix (me)
      
       - Use after free and error handling fix for O_DIRECT fragments. There's
         still a nowait + sync oddity in there, we'll nail that start next
         week. If all else fails, I'll queue a revert of the NOWAIT change.
         (me)
      
       - Loop GFP_KERNEL -> GFP_NOIO deadlock fix (Mikulas)
      
       - Two BFQ regression fixes that caused crashes (Paolo)
      
      * tag 'for-linus-20190809' of git://git.kernel.dk/linux-block:
        bcache: Revert "bcache: use sysfs_match_string() instead of __sysfs_match_string()"
        loop: set PF_MEMALLOC_NOIO for the worker thread
        bdev: Fixup error handling in blkdev_get()
        block, bfq: handle NULL return value by bfq_init_rq()
        block, bfq: move update of waker and woken list to queue freeing
        block, bfq: reset last_completed_rq_bfqq if the pointed queue is freed
        block: aoe: Fix kernel crash due to atomic sleep when exiting
        libata: add SG safety checks in SFF pio transfers
        libata: have ata_scsi_rw_xlat() fail invalid passthrough requests
        block: fix O_DIRECT error handling for bio fragments
        ata: rb532_cf: Fix unused variable warning in rb532_pata_driver_probe
      50e73a4a
    • Linus Torvalds's avatar
      Merge tag 'mmc-v5.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc · 461d2815
      Linus Torvalds authored
      Pull MMC fixes from Ulf Hansson:
      
       - cavium: Fix DMA support
      
       - sdhci-sprd: Fix soft reset when runtime resuming"
      
      * tag 'mmc-v5.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc:
        mmc: cavium: Add the missing dma unmap when the dma has finished.
        mmc: cavium: Set the correct dma max segment size for mmc_host
        mmc: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming
      461d2815
    • Linus Torvalds's avatar
      Merge tag 'fbdev-v5.3-rc4' of git://github.com/bzolnier/linux · ec4c99ad
      Linus Torvalds authored
      Pull fbdev fix from Bartlomiej Zolnierkiewicz:
       "fbdev patches will now go to upstream through drm-misc tree for
        improved maintainership and better integration testing so update
        MAINTAINERS file accordingly"
      
      * tag 'fbdev-v5.3-rc4' of git://github.com/bzolnier/linux:
        MAINTAINERS: handle fbdev changes through drm-misc tree
      ec4c99ad
    • Linus Torvalds's avatar
      Merge tag 'pwm/for-5.3-rc4' of... · c808f2ad
      Linus Torvalds authored
      Merge tag 'pwm/for-5.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm
      
      Pull pwm fix from Thierry Reding:
       "A single fix for a backlight brightness regression introduced in
        this merge window"
      
      * tag 'pwm/for-5.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm:
        pwm: Fallback to the static lookup-list when acpi_pwm_get fails
      c808f2ad
    • Linus Torvalds's avatar
      Merge tag 'sound-5.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · cb42f06c
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "Lots of small fixes at this time since we've received the ASoC fix
        batch now.
      
         - Some coverage in ASoC core mostly for minor issues like NULL checks
           for DPCM and proper error handling in DAI instantiation
      
         - A collection of small device-specific changes in various ASoC codec
           and platform drivers
      
         - OF-tree refcount fixes in a few ASoC drivers
      
         - Fixes of memory leaks in the error paths of various ASoC / ALSA
           drivers
      
         - A workaround for a long-standing issue on AMD HD-audio device
      
         - Updates of MAINTAINERS, mail addresses, file permission fixups"
      
      * tag 'sound-5.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (38 commits)
        ALSA: firewire: fix a memory leak bug
        sound: fix a memory leak bug
        ALSA: hda - Workaround for crackled sound on AMD controller (1022:1457)
        ALSA: hiface: fix multiple memory leak bugs
        ALSA: hda - Don't override global PCM hw info flag
        ALSA: usb-audio: fix a memory leak bug
        ASoC: max98373: Remove executable bits
        ASoC: amd: acp3x: use dma address for acp3x dma driver
        ASoC: amd: acp3x: use dma_ops of parent device for acp3x dma driver
        ASoC: max98373: add 88200 and 96000 sampling rate support
        ASoC: sun4i-i2s: Incorrect SR and WSS computation
        MAINTAINERS: Update Intel ASoC drivers maintainers
        ASoC: ti: davinci-mcasp: Correct slot_width posed constraint
        ASoC: rockchip: Fix mono capture
        ASoC: Intel: Fix some acpi vs apci typo in somme comments
        ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode
        ASoC: Fail card instantiation if DAI format setup fails
        ASoC: SOF: Intel: hda: remove misleading error trace from IRQ thread
        ASoC: qcom: apq8016_sbc: Fix oops with multiple DAI links
        ASoC: dapm: fix a memory leak bug
        ...
      cb42f06c
    • Linus Torvalds's avatar
      Merge tag 'media/v5.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media · 6c02b630
      Linus Torvalds authored
      Pull media fix from Mauro Carvalho Chehab:
       "A fix at the vivid CEC support"
      
      * tag 'media/v5.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media:
        media: vivid: fix missing cec adapter name
      6c02b630
    • Linus Torvalds's avatar
      Merge tag 'pm-5.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 0acf5676
      Linus Torvalds authored
      Pull power management fix from Rafael Wysocki:
       "Revert a recent PCI power management change that caused problems to
        occur on multiple systems (Mika Westerberg)"
      
      * tag 'pm-5.3-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        Revert "PCI: Add missing link delays required by the PCIe spec"
      0acf5676
    • Linus Torvalds's avatar
      Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 · e577dc15
      Linus Torvalds authored
      Pull crypto fixes from Herbert Xu:
       "Fix a number of bugs in the ccp driver"
      
      * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
        crypto: ccp - Ignore tag length when decrypting GCM ciphertext
        crypto: ccp - Add support for valid authsize values less than 16
        crypto: ccp - Fix oops by properly managing allocated structures
      e577dc15
  3. Aug 09, 2019