Skip to content
  1. Oct 27, 2021
  2. Oct 20, 2021
    • Greg Kroah-Hartman's avatar
      Linux 5.10.75 · 3a9842b4
      Greg Kroah-Hartman authored
      
      
      Link: https://lore.kernel.org/r/20211018132334.702559133@linuxfoundation.org
      Tested-by: default avatarFox Chen <foxhlchen@gmail.com>
      Tested-by: default avatarPavel Machek (CIP) <pavel@denx.de>
      Tested-by: default avatarShuah Khan <skhan@linuxfoundation.org>
      Tested-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Tested-by: default avatarJon Hunter <jonathanh@nvidia.com>
      Tested-by: default avatarLinux Kernel Functional Testing <lkft@linaro.org>
      Tested-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
      Tested-by: default avatarSalvatore Bonaccorso <carnil@debian.org>
      Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Tested-by: default avatarHulk Robot <hulkrobot@huawei.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3a9842b4
    • Maarten Zanders's avatar
      net: dsa: mv88e6xxx: don't use PHY_DETECT on internal PHY's · 3e287365
      Maarten Zanders authored
      commit 4a3e0aed upstream.
      
      mv88e6xxx_port_ppu_updates() interpretes data in the PORT_STS
      register incorrectly for internal ports (ie no PPU). In these
      cases, the PHY_DETECT bit indicates link status. This results
      in forcing the MAC state whenever the PHY link goes down which
      is not intended. As a side effect, LED's configured to show
      link status stay lit even though the physical link is down.
      
      Add a check in mac_link_down and mac_link_up to see if it
      concerns an external port and only then, look at PPU status.
      
      Fixes: 5d5b231d
      
       (net: dsa: mv88e6xxx: use PHY_DETECT in mac_link_up/mac_link_down)
      Reported-by: default avatarMaarten Zanders <m.zanders@televic.com>
      Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
      Signed-off-by: default avatarMaarten Zanders <maarten.zanders@mind.be>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3e287365
    • Shannon Nelson's avatar
      ionic: don't remove netdev->dev_addr when syncing uc list · 3593fa14
      Shannon Nelson authored
      commit 5c976a56 upstream.
      
      Bridging, and possibly other upper stack gizmos, adds the
      lower device's netdev->dev_addr to its own uc list, and
      then requests it be deleted when the upper bridge device is
      removed.  This delete request also happens with the bridging
      vlan_filtering is enabled and then disabled.
      
      Bonding has a similar behavior with the uc list, but since it
      also uses set_mac to manage netdev->dev_addr, it doesn't have
      the same the failure case.
      
      Because we store our netdev->dev_addr in our uc list, we need
      to ignore the delete request from dev_uc_sync so as to not
      lose the address and all hope of communicating.  Note that
      ndo_set_mac_address is expressly changing netdev->dev_addr,
      so no limitation is set there.
      
      Fixes: 2a654540
      
       ("ionic: Add Rx filter and rx_mode ndo support")
      Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3593fa14
    • Vladimir Oltean's avatar
      net: mscc: ocelot: warn when a PTP IRQ is raised for an unknown skb · f33890d9
      Vladimir Oltean authored
      commit 9fde506e upstream.
      
      When skb_match is NULL, it means we received a PTP IRQ for a timestamp
      ID that the kernel has no idea about, since there is no skb in the
      timestamping queue with that timestamp ID.
      
      This is a grave error and not something to just "continue" over.
      So print a big warning in case this happens.
      
      Also, move the check above ocelot_get_hwtimestamp(), there is no point
      in reading the full 64-bit current PTP time if we're not going to do
      anything with it anyway for this skb.
      
      Fixes: 4e3b0468
      
       ("net: mscc: PTP Hardware Clock (PHC) support")
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f33890d9
    • Baowen Zheng's avatar
      nfp: flow_offload: move flow_indr_dev_register from app init to app start · 9c546af1
      Baowen Zheng authored
      commit 60d950f4 upstream.
      
      In commit 74fc4f82 ("net: Fix offloading indirect devices dependency
      on qdisc order creation"), it adds a process to trigger the callback to
      setup the bo callback when the driver regists a callback.
      
      In our current implement, we are not ready to run the callback when nfp
      call the function flow_indr_dev_register, then there will be error
      message as:
      
      kernel: Oops: 0000 [#1] SMP PTI
      kernel: CPU: 0 PID: 14119 Comm: kworker/0:0 Tainted: G
      kernel: Workqueue: events work_for_cpu_fn
      kernel: RIP: 0010:nfp_flower_indr_setup_tc_cb+0x258/0x410
      kernel: RSP: 0018:ffffbc1e02c57bf8 EFLAGS: 00010286
      kernel: RAX: 0000000000000000 RBX: ffff9c761fabc000 RCX: 0000000000000001
      kernel: RDX: 0000000000000001 RSI: fffffffffffffff0 RDI: ffffffffc0be9ef1
      kernel: RBP: ffffbc1e02c57c58 R08: ffffffffc08f33aa R09: ffff9c6db7478800
      kernel: R10: 0000009c003f6e00 R11: ffffbc1e02800000 R12: ffffbc1e000d9000
      kernel: R13: ffffbc1e000db428 R14: ffff9c6db7478800 R15: ffff9c761e884e80
      kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      kernel: CR2: fffffffffffffff0 CR3: 00000009e260a004 CR4: 00000000007706f0
      kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      kernel: DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      kernel: PKRU: 55555554
      kernel: Call Trace:
      kernel: ? flow_indr_dev_register+0xab/0x210
      kernel: ? __cond_resched+0x15/0x30
      kernel: ? kmem_cache_alloc_trace+0x44/0x4b0
      kernel: ? nfp_flower_setup_tc+0x1d0/0x1d0 [nfp]
      kernel: flow_indr_dev_register+0x158/0x210
      kernel: ? tcf_block_unbind+0xe0/0xe0
      kernel: nfp_flower_init+0x40b/0x650 [nfp]
      kernel: nfp_net_pci_probe+0x25f/0x960 [nfp]
      kernel: ? nfp_rtsym_read_le+0x76/0x130 [nfp]
      kernel: nfp_pci_probe+0x6a9/0x820 [nfp]
      kernel: local_pci_probe+0x45/0x80
      
      So we need to call flow_indr_dev_register in app start process instead of
      init stage.
      
      Fixes: 74fc4f82
      
       ("net: Fix offloading indirect devices dependency on qdisc order creation")
      Signed-off-by: default avatarBaowen Zheng <baowen.zheng@corigine.com>
      Signed-off-by: default avatarSimon Horman <simon.horman@corigine.com>
      Signed-off-by: default avatarLouis Peens <louis.peens@corigine.com>
      Link: https://lore.kernel.org/r/20211012124850.13025-1-louis.peens@corigine.com
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      9c546af1
    • Vegard Nossum's avatar
      r8152: select CRC32 and CRYPTO/CRYPTO_HASH/CRYPTO_SHA256 · 6da9af2d
      Vegard Nossum authored
      commit 9973a430 upstream.
      
      Fix the following build/link errors by adding a dependency on
      CRYPTO, CRYPTO_HASH, CRYPTO_SHA256 and CRC32:
      
        ld: drivers/net/usb/r8152.o: in function `rtl8152_fw_verify_checksum':
        r8152.c:(.text+0x2b2a): undefined reference to `crypto_alloc_shash'
        ld: r8152.c:(.text+0x2bed): undefined reference to `crypto_shash_digest'
        ld: r8152.c:(.text+0x2c50): undefined reference to `crypto_destroy_tfm'
        ld: drivers/net/usb/r8152.o: in function `_rtl8152_set_rx_mode':
        r8152.c:(.text+0xdcb0): undefined reference to `crc32_le'
      
      Fixes: 9370f2d0 ("r8152: support request_firmware for RTL8153")
      Fixes: ac718b69
      
       ("net/usb: new driver for RTL8152")
      Signed-off-by: default avatarVegard Nossum <vegard.nossum@oracle.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6da9af2d
    • chongjiapeng's avatar
      qed: Fix missing error code in qed_slowpath_start() · ecfd4fa1
      chongjiapeng authored
      commit a5a14ea7
      
       upstream.
      
      The error code is missing in this code scenario, add the error code
      '-EINVAL' to the return value 'rc'.
      
      Eliminate the follow smatch warning:
      
      drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
      warn: missing error code 'rc'.
      
      Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
      Fixes: d51e4af5
      
       ("qed: aRFS infrastructure support")
      Signed-off-by: default avatarchongjiapeng <jiapeng.chong@linux.alibaba.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      ecfd4fa1
    • Sebastian Andrzej Siewior's avatar
      mqprio: Correct stats in mqprio_dump_class_stats(). · 51f6e72c
      Sebastian Andrzej Siewior authored
      commit 14132690 upstream.
      
      Introduction of lockless subqueues broke the class statistics.
      Before the change stats were accumulated in `bstats' and `qstats'
      on the stack which was then copied to struct gnet_dump.
      
      After the change the `bstats' and `qstats' are initialized to 0
      and never updated, yet still fed to gnet_dump. The code updates
      the global qdisc->cpu_bstats and qdisc->cpu_qstats instead,
      clobbering them. Most likely a copy-paste error from the code in
      mqprio_dump().
      
      __gnet_stats_copy_basic() and __gnet_stats_copy_queue() accumulate
      the values for per-CPU case but for global stats they overwrite
      the value, so only stats from the last loop iteration / tc end up
      in sch->[bq]stats.
      
      Use the on-stack [bq]stats variables again and add the stats manually
      in the global case.
      
      Fixes: ce679e8d
      
       ("net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mqprio")
      Cc: John Fastabend <john.fastabend@gmail.com>
      Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
      https://lore.kernel.org/all/20211007175000.2334713-2-bigeasy@linutronix.de/
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      51f6e72c
    • Prashant Malani's avatar
      platform/x86: intel_scu_ipc: Fix busy loop expiry time · fdaff7f9
      Prashant Malani authored
      commit 41512e4d upstream.
      
      The macro IPC_TIMEOUT is already in jiffies (it is also used like that
      elsewhere in the file when calling wait_for_completion_timeout()). Don’t
      convert it using helper functions for the purposes of calculating the
      busy loop expiry time.
      
      Fixes: e7b7ab38
      
       (“platform/x86: intel_scu_ipc: Sleeping is fine when polling”)
      Signed-off-by: default avatarPrashant Malani <pmalani@chromium.org>
      Cc: Benson Leung <bleung@chromium.org>
      Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
      Link: https://lore.kernel.org/r/20210928101932.2543937-2-pmalani@chromium.org
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fdaff7f9
    • Jackie Liu's avatar
      acpi/arm64: fix next_platform_timer() section mismatch error · 057ee684
      Jackie Liu authored
      commit 596143e3 upstream.
      
      Fix modpost Section mismatch error in next_platform_timer().
      
        [...]
        WARNING: modpost: vmlinux.o(.text.unlikely+0x26e60): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
        The function next_platform_timer() references
        the variable __initdata acpi_gtdt_desc.
        This is often because next_platform_timer lacks a __initdata
        annotation or the annotation of acpi_gtdt_desc is wrong.
      
        WARNING: modpost: vmlinux.o(.text.unlikely+0x26e64): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
        The function next_platform_timer() references
        the variable __initdata acpi_gtdt_desc.
        This is often because next_platform_timer lacks a __initdata
        annotation or the annotation of acpi_gtdt_desc is wrong.
      
        ERROR: modpost: Section mismatches detected.
        Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
        make[1]: *** [scripts/Makefile.modpost:59: vmlinux.symvers] Error 1
        make[1]: *** Deleting file 'vmlinux.symvers'
        make: *** [Makefile:1176: vmlinux] Error 2
        [...]
      
      Fixes: a712c3ed
      
       ("acpi/arm64: Add memory-mapped timer support in GTDT driver")
      Signed-off-by: default avatarJackie Liu <liuyun01@kylinos.cn>
      Acked-by: default avatarHanjun Guo <guohanjun@huawei.com>
      Link: https://lore.kernel.org/r/20210823092526.2407526-1-liu.yun@linux.dev
      Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      057ee684
    • Dan Carpenter's avatar
      drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling · c6b24000
      Dan Carpenter authored
      commit c8f01ffc upstream.
      
      This disables a lock which wasn't enabled and it does not disable
      the first lock in the array.
      
      Fixes: 6e0eb52e
      
       ("drm/msm/dsi: Parse bus clocks from a list")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Link: https://lore.kernel.org/r/20211001123409.GG2283@kili
      Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c6b24000
    • Dan Carpenter's avatar
      drm/msm/dsi: Fix an error code in msm_dsi_modeset_init() · 2c565871
      Dan Carpenter authored
      commit 739b4e77 upstream.
      
      Return an error code if msm_dsi_manager_validate_current_config().
      Don't return success.
      
      Fixes: 8b03ad30
      
       ("drm/msm/dsi: Use one connector for dual DSI mode")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Link: https://lore.kernel.org/r/20211001123308.GF2283@kili
      Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2c565871
    • Rob Clark's avatar
      drm/msm/a6xx: Track current ctx by seqno · b28586fb
      Rob Clark authored
      commit 14eb0cb4 upstream.
      
      In theory a context can be destroyed and a new one allocated at the same
      address, making the pointer comparision to detect when we don't need to
      update the current pagetables invalid.  Instead assign a sequence number
      to each context on creation, and use this for the check.
      
      Fixes: 84c31ee1
      
       ("drm/msm/a6xx: Add support for per-instance pagetables")
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b28586fb
    • Dmitry Baryshkov's avatar
      drm/msm/mdp5: fix cursor-related warnings · abd11864
      Dmitry Baryshkov authored
      commit c491a0c7 upstream.
      
      Since f35a2a99 ("drm/encoder: make encoder control functions
      optional") drm_mode_config_validate would print warnings if both cursor
      plane and cursor functions are provided. Restore separate set of
      drm_crtc_funcs to be used if separate cursor plane is provided.
      
      [    6.556046] ------------[ cut here ]------------
      [    6.556071] [CRTC:93:crtc-0] must not have both a cursor plane and a cursor_set func
      [    6.556091] WARNING: CPU: 1 PID: 76 at drivers/gpu/drm/drm_mode_config.c:648 drm_mode_config_validate+0x238/0x4d0
      [    6.567453] Modules linked in:
      [    6.577604] CPU: 1 PID: 76 Comm: kworker/u8:2 Not tainted 5.15.0-rc1-dirty #43
      [    6.580557] Hardware name: Qualcomm Technologies, Inc. DB820c (DT)
      [    6.587763] Workqueue: events_unbound deferred_probe_work_func
      [    6.593926] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
      [    6.599740] pc : drm_mode_config_validate+0x238/0x4d0
      [    6.606596] lr : drm_mode_config_validate+0x238/0x4d0
      [    6.611804] sp : ffff8000121b3980
      [    6.616838] x29: ffff8000121b3990 x28: 0000000000000000 x27: 0000000000000001
      [    6.620140] x26: ffff8000114cde50 x25: ffff8000114cdd40 x24: ffff0000987282d8
      [    6.627258] x23: 0000000000000000 x22: 0000000000000000 x21: 0000000000000001
      [    6.634376] x20: ffff000098728000 x19: ffff000080a39000 x18: ffffffffffffffff
      [    6.641494] x17: 3136564e3631564e x16: 0000000000000324 x15: ffff800011c78709
      [    6.648613] x14: 0000000000000000 x13: ffff800011a22850 x12: 00000000000009ab
      [    6.655730] x11: 0000000000000339 x10: ffff800011a22850 x9 : ffff800011a22850
      [    6.662848] x8 : 00000000ffffefff x7 : ffff800011a7a850 x6 : ffff800011a7a850
      [    6.669966] x5 : 000000000000bff4 x4 : 40000000fffff339 x3 : 0000000000000000
      [    6.677084] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00008093b800
      [    6.684205] Call trace:
      [    6.691319]  drm_mode_config_validate+0x238/0x4d0
      [    6.693577]  drm_dev_register+0x17c/0x210
      [    6.698435]  msm_drm_bind+0x4b4/0x694
      [    6.702429]  try_to_bring_up_master+0x164/0x1d0
      [    6.706075]  __component_add+0xa0/0x170
      [    6.710415]  component_add+0x14/0x20
      [    6.714234]  msm_hdmi_dev_probe+0x1c/0x2c
      [    6.718053]  platform_probe+0x68/0xe0
      [    6.721959]  really_probe.part.0+0x9c/0x30c
      [    6.725606]  __driver_probe_device+0x98/0x144
      [    6.729600]  driver_probe_device+0xc8/0x15c
      [    6.734114]  __device_attach_driver+0xb4/0x120
      [    6.738106]  bus_for_each_drv+0x78/0xd0
      [    6.742619]  __device_attach+0xdc/0x184
      [    6.746351]  device_initial_probe+0x14/0x20
      [    6.750172]  bus_probe_device+0x9c/0xa4
      [    6.754337]  deferred_probe_work_func+0x88/0xc0
      [    6.758158]  process_one_work+0x1d0/0x370
      [    6.762671]  worker_thread+0x2c8/0x470
      [    6.766839]  kthread+0x15c/0x170
      [    6.770483]  ret_from_fork+0x10/0x20
      [    6.773870] ---[ end trace 5884eb76cd26d274 ]---
      [    6.777500] ------------[ cut here ]------------
      [    6.782043] [CRTC:93:crtc-0] must not have both a cursor plane and a cursor_move func
      [    6.782063] WARNING: CPU: 1 PID: 76 at drivers/gpu/drm/drm_mode_config.c:654 drm_mode_config_validate+0x290/0x4d0
      [    6.794362] Modules linked in:
      [    6.804600] CPU: 1 PID: 76 Comm: kworker/u8:2 Tainted: G        W         5.15.0-rc1-dirty #43
      [    6.807555] Hardware name: Qualcomm Technologies, Inc. DB820c (DT)
      [    6.816148] Workqueue: events_unbound deferred_probe_work_func
      [    6.822311] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
      [    6.828126] pc : drm_mode_config_validate+0x290/0x4d0
      [    6.834981] lr : drm_mode_config_validate+0x290/0x4d0
      [    6.840189] sp : ffff8000121b3980
      [    6.845223] x29: ffff8000121b3990 x28: 0000000000000000 x27: 0000000000000001
      [    6.848525] x26: ffff8000114cde50 x25: ffff8000114cdd40 x24: ffff0000987282d8
      [    6.855643] x23: 0000000000000000 x22: 0000000000000000 x21: 0000000000000001
      [    6.862763] x20: ffff000098728000 x19: ffff000080a39000 x18: ffffffffffffffff
      [    6.869879] x17: 3136564e3631564e x16: 0000000000000324 x15: ffff800011c790c2
      [    6.876998] x14: 0000000000000000 x13: ffff800011a22850 x12: 0000000000000a2f
      [    6.884116] x11: 0000000000000365 x10: ffff800011a22850 x9 : ffff800011a22850
      [    6.891234] x8 : 00000000ffffefff x7 : ffff800011a7a850 x6 : ffff800011a7a850
      [    6.898351] x5 : 000000000000bff4 x4 : 40000000fffff365 x3 : 0000000000000000
      [    6.905470] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00008093b800
      [    6.912590] Call trace:
      [    6.919702]  drm_mode_config_validate+0x290/0x4d0
      [    6.921960]  drm_dev_register+0x17c/0x210
      [    6.926821]  msm_drm_bind+0x4b4/0x694
      [    6.930813]  try_to_bring_up_master+0x164/0x1d0
      [    6.934459]  __component_add+0xa0/0x170
      [    6.938799]  component_add+0x14/0x20
      [    6.942619]  msm_hdmi_dev_probe+0x1c/0x2c
      [    6.946438]  platform_probe+0x68/0xe0
      [    6.950345]  really_probe.part.0+0x9c/0x30c
      [    6.953991]  __driver_probe_device+0x98/0x144
      [    6.957984]  driver_probe_device+0xc8/0x15c
      [    6.962498]  __device_attach_driver+0xb4/0x120
      [    6.966492]  bus_for_each_drv+0x78/0xd0
      [    6.971004]  __device_attach+0xdc/0x184
      [    6.974737]  device_initial_probe+0x14/0x20
      [    6.978556]  bus_probe_device+0x9c/0xa4
      [    6.982722]  deferred_probe_work_func+0x88/0xc0
      [    6.986543]  process_one_work+0x1d0/0x370
      [    6.991057]  worker_thread+0x2c8/0x470
      [    6.995223]  kthread+0x15c/0x170
      [    6.998869]  ret_from_fork+0x10/0x20
      [    7.002255] ---[ end trace 5884eb76cd26d275 ]---
      
      Fixes: aa649e87
      
       ("drm/msm/mdp5: mdp5_crtc: Restore cursor state only if LM cursors are enabled")
      Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Link: https://lore.kernel.org/r/20210925192824.3416259-1-dmitry.baryshkov@linaro.org
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      abd11864
    • Colin Ian King's avatar
      drm/msm: Fix null pointer dereference on pointer edp · 91a34076
      Colin Ian King authored
      commit 2133c4fc upstream.
      
      The initialization of pointer dev dereferences pointer edp before
      edp is null checked, so there is a potential null pointer deference
      issue. Fix this by only dereferencing edp after edp has been null
      checked.
      
      Addresses-Coverity: ("Dereference before null check")
      Fixes: ab5b0107
      
       ("drm/msm: Initial add eDP support in msm drm driver (v5)")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
      Link: https://lore.kernel.org/r/20210929121857.213922-1-colin.king@canonical.com
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      91a34076