Skip to content
  1. Jun 30, 2015
    • Peter Zijlstra's avatar
      perf/x86: Fix 'active_events' imbalance · 93472aff
      Peter Zijlstra authored
      Commit 1b7b938f
      
       ("perf/x86/intel: Fix PMI handling for Intel PT") conditionally
      increments active_events in x86_add_exclusive() but unconditionally decrements in
      x86_del_exclusive().
      
      These extra decrements can lead to the situation where
      active_events is zero and thus the PMI handler is 'disabled'
      while we have active events on the PMU generating PMIs.
      
      This leads to a truckload of:
      
        Uhhuh. NMI received for unknown reason 21 on CPU 28.
        Do you have a strange power saving mode enabled?
        Dazed and confused, but trying to continue
      
      messages and generally messes up perf.
      
      Remove the condition on the increment, double increment balanced
      by a double decrement is perfectly fine.
      
      Restructure the code a little bit to make the unconditional inc
      a bit more natural.
      
      Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Borislav Petkov <bp@alien8.de>
      Cc: H. Peter Anvin <hpa@zytor.com>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: alexander.shishkin@linux.intel.com
      Cc: brgerst@gmail.com
      Cc: dvlasenk@redhat.com
      Cc: luto@amacapital.net
      Cc: oleg@redhat.com
      Fixes: 1b7b938f ("perf/x86/intel: Fix PMI handling for Intel PT")
      Link: http://lkml.kernel.org/r/20150624144750.GJ18673@twins.programming.kicks-ass.net
      
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      93472aff
    • Ingo Molnar's avatar
      Merge tag 'perf-core-for-mingo' of... · 2d6dac2f
      Ingo Molnar authored
      Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux
      
       into perf/urgent
      
      Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo:
      
      User visible changes:
      
        - Validate syscall list passed via -e argument to 'perf trace'. (Arnaldo Carvalho de Melo)
      
        - Introduce 'perf stat --per-thread'. (Jiri Olsa)
      
        - Check access permission for --kallsyms and --vmlinux. (Li Zhang)
      
      Infrastructure changes:
      
        - Move stuff out of 'perf stat' and into the lib for further use. (Jiri Olsa)
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      2d6dac2f
  2. Jun 26, 2015
  3. Jun 25, 2015
    • Srikar Dronamraju's avatar
      perf bench numa: Fix to show proper convergence stats · 2b42b09b
      Srikar Dronamraju authored
      With commit: e1e455f4 (perf tools: Work around lack of sched_getcpu
      in glibc < 2.6), perf_bench numa mem with -c or -m option is not able to
      correctly calculate convergence.
      
      With the above commit, sched_getcpu always seems to return -1. The
      intention of commit e1e455f4
      
       was to add a sched_getcpu in glibc < 2.6.
      Hence keep the sched_getcpu definition under an ifdef.
      
      This regression happened occurred between v4.0 and v4.1
      
      Signed-off-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
      Acked-by: default avatarIngo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Vinson Lee <vlee@twitter.com>
      Fixes:  e1e455f4 ("perf tools: Work around lack of sched_getcpu in glibc < 2.6")
      Link: http://lkml.kernel.org/r/20150624111004.GA5220@linux.vnet.ibm.com
      
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      2b42b09b
    • Ingo Molnar's avatar
      Merge tag 'perf-core-for-mingo' of... · 27451700
      Ingo Molnar authored
      Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux
      
       into perf/core
      
      Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo:
      
      User visible changes:
      
        - Move toggling event logic from 'perf top' and into hists browser, allowing
          freeze/unfreeze with event lists with more than one entry (Namhyung Kim)
      
        - Add missing newlines when dumping PERF_RECORD_FINISHED_ROUND and
          showing the Aggregated stats in 'perf report -D' (Adrian Hunter)
      
      Infrastructure changes:
      
        - Allow auxtrace data alignment (Adrian Hunter)
      
        - Allow events with dot (Andi Kleen)
      
        - Fix failure to 'perf probe' events on arm (He Kuang)
      
        - Add testing for Makefile.perf (Jiri Olsa)
      
        - Add test for make install with prefix (Jiri Olsa)
      
        - Fix single target build dependency check (Jiri Olsa)
      
        - Access thread_map entries via accessors, prep patch to hold more info per
          entry, for ongoing 'perf stat --per-thread' work (Jiri Olsa)
      
        - Use __weak definition from compiler.h (Sukadev Bhattiprolu)
      
        - Split perf_pmu__new_alias() (Sukadev Bhattiprolu)
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      27451700
  4. Jun 24, 2015