Skip to content
  1. Feb 05, 2013
  2. Jan 17, 2013
    • Fabio Estevam's avatar
      video: imxfb: Do not crash on reboot · e6b267ce
      Fabio Estevam authored
      
      
      Issuing a "reboot" command after the LCD times out causes the following
      warnings:
      
      Requesting system reboot
      ------------[ cut here ]------------
      WARNING: at drivers/clk/clk.c:471 clk_disable+0x24/0x50()
      Modules linked in:
      [<c001ad90>] (unwind_backtrace+0x0/0xf4) from [<c0025aac>] (warn_slowpath_common+0x48/0x60)
      [<c0025aac>] (warn_slowpath_common+0x48/0x60) from [<c0025ae0>] (warn_slowpath_null+0x1c/0x24)
      [<c0025ae0>] (warn_slowpath_null+0x1c/0x24) from [<c03960a0>] (clk_disable+0x24/0x50)
      [<c03960a0>] (clk_disable+0x24/0x50) from [<c02695a0>] (imxfb_disable_controller+0x48/0x7c)
      [<c02695a0>] (imxfb_disable_controller+0x48/0x7c) from [<c029d838>] (platform_drv_shutdown+0x18/0x1c)
      [<c029d838>] (platform_drv_shutdown+0x18/0x1c) from [<c02990fc>] (device_shutdown+0x48/0x14c)
      [<c02990fc>] (device_shutdown+0x48/0x14c) from [<c003d09c>] (kernel_restart_prepare+0x2c/0x3c)
      [<c003d09c>] (kernel_restart_prepare+0x2c/0x3c) from [<c003d0e4>] (kernel_restart+0xc/0x48)
      [<c003d0e4>] (kernel_restart+0xc/0x48) from [<c003d1e8>] (sys_reboot+0xc0/0x1bc)
      [<c003d1e8>] (sys_reboot+0xc0/0x1bc) from [<c0014ca0>] (ret_fast_syscall+0x0/0x2c)
      ---[ end trace da6b502ca79c854f ]---
      ------------[ cut here ]------------
      WARNING: at drivers/clk/clk.c:380 clk_unprepare+0x1c/0x2c()
      Modules linked in:
      [<c001ad90>] (unwind_backtrace+0x0/0xf4) from [<c0025aac>] (warn_slowpath_common+0x48/0x60)
      [<c0025aac>] (warn_slowpath_common+0x48/0x60) from [<c0025ae0>] (warn_slowpath_null+0x1c/0x24)
      [<c0025ae0>] (warn_slowpath_null+0x1c/0x24) from [<c0396338>] (clk_unprepare+0x1c/0x2c)
      [<c0396338>] (clk_unprepare+0x1c/0x2c) from [<c02695a8>] (imxfb_disable_controller+0x50/0x7c)
      [<c02695a8>] (imxfb_disable_controller+0x50/0x7c) from [<c029d838>] (platform_drv_shutdown+0x18/0x1c)
      [<c029d838>] (platform_drv_shutdown+0x18/0x1c) from [<c02990fc>] (device_shutdown+0x48/0x14c)
      [<c02990fc>] (device_shutdown+0x48/0x14c) from [<c003d09c>] (kernel_restart_prepare+0x2c/0x3c)
      [<c003d09c>] (kernel_restart_prepare+0x2c/0x3c) from [<c003d0e4>] (kernel_restart+0xc/0x48)
      [<c003d0e4>] (kernel_restart+0xc/0x48) from [<c003d1e8>] (sys_reboot+0xc0/0x1bc)
      [<c003d1e8>] (sys_reboot+0xc0/0x1bc) from [<c0014ca0>] (ret_fast_syscall+0x0/0x2c)
      ---[ end trace da6b502ca79c8550 ]---
      ------------[ cut here ]------------
      
      This happens because "reboot" triggers imxfb_shutdown(), which calls
      imxfb_disable_controller with the clocks already disabled.
      
      To prevent this, add a clock enabled status so that we can check if the clocks
      are enabled before disabling them.
      
      Acked-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
      Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
      Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
      e6b267ce
  3. Jan 14, 2013
  4. Jan 11, 2013
    • Shawn Guo's avatar
      ARM: imx: fix build error with !CONFIG_SMP · aec99b7b
      Shawn Guo authored
      
      
      Commit 68b25325 (ARM: imx: select HAVE_IMX_SRC when SMP is enabled)
      introduces a build error with imx_v6_v7_defconfig when CONFIG_SMP is
      deselected.
      
        LINK    vmlinux
        LD      vmlinux.o
        MODPOST vmlinux.o
        GEN     .version
        CHK     include/generated/compile.h
        UPD     include/generated/compile.h
        CC      init/version.o
        LD      init/built-in.o
      arch/arm/mach-imx/built-in.o: In function `imx6q_restart':
      platform-ahci-imx.c:(.text+0x448c): undefined reference to `imx_src_prepare_restart'
      arch/arm/mach-imx/built-in.o: In function `imx6q_pm_enter':
      platform-ahci-imx.c:(.text+0x4544): undefined reference to `imx_set_cpu_jump'
      arch/arm/mach-imx/built-in.o: In function `imx6q_init_irq':
      platform-ahci-imx.c:(.init.text+0xbef0): undefined reference to `imx_src_init'
      make[1]: *** [vmlinux] Error 1
      
      While the commit adds 'def_bool y if SMP' for HAVE_IMX_SRC, it should
      not remove 'select HAVE_IMX_SRC' from SOC_IMX6Q, as the IMX6Q UP build
      also needs HAVE_IMX_SRC.  Add the HAVE_IMX_SRC select back for SOC_IMX6Q
      to fix above build error.
      
      Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
      aec99b7b
  5. Jan 08, 2013
  6. Jan 04, 2013
  7. Dec 22, 2012