Skip to content
  1. Nov 22, 2013
  2. Nov 21, 2013
  3. Nov 20, 2013
  4. Nov 19, 2013
  5. Nov 18, 2013
  6. Nov 16, 2013
  7. Nov 15, 2013
  8. Nov 14, 2013
    • Takashi Iwai's avatar
      ALSA: pcsp: Fix the order of input device unregistration · 6408eac2
      Takashi Iwai authored
      
      
      The current code may access to the already freed object.  The input
      device must be accessed and unregistered before freeing the top level
      sound object.
      
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      6408eac2
    • Oskar Schirmer's avatar
      ASoC: fsl: imx-pcm-fiq: omit fiq counter to avoid harm in unbalanced situations · fc7dc61d
      Oskar Schirmer authored
      
      
      Unbalanced calls to snd_imx_pcm_trigger() may result in endless
      FIQ activity and thus provoke eternal sound. While on the first glance,
      the switch statement looks pretty symmetric, the SUSPEND/RESUME
      pair is not: the suspend case comes along snd_pcm_suspend_all(),
      which for fsl/imx-pcm-fiq is called only at snd_soc_suspend(),
      but the resume case originates straight from the SNDRV_PCM_IOCTL_RESUME.
      This way userland may provoke an unbalanced resume, which might cause
      the fiq_enable counter to increase and never return to zero again,
      so eventually imx_pcm_fiq is never disabled.
      
      Simply removing the fiq_enable will solve the problem, as long as
      one never goes play and capture game simultaneously, but beware
      trying both at once, the early TRIGGER_STOP will cut off the other
      activity prematurely. So now playing and capturing is scrutinized
      separately, instead of by counting.
      
      Signed-off-by: default avatarOskar Schirmer <oskar@scara.com>
      Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      Cc: stable@vger.kernel.org
      fc7dc61d
    • Takashi Iwai's avatar
      ASoC: blackfin: Fix missing break · afed4dbe
      Takashi Iwai authored
      Fixes: 4b2ffc20
      
       ('ASoC: Blackfin I2S: add 8-bit sample support')
      Reported-by: David Binderman
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarMark Brown <broonie@linaro.org>
      Cc: stable@vger.kernel.org
      afed4dbe