Skip to content
  1. Oct 02, 2023
  2. Oct 01, 2023
  3. Sep 30, 2023
    • Linus Torvalds's avatar
      Merge tag '6.6-rc3-ksmbd-server-fixes' of git://git.samba.org/ksmbd · 9f3ebbef
      Linus Torvalds authored
      Pull smb server fixes from Steve French:
       "Two SMB3 server fixes for null pointer dereferences:
      
         - invalid SMB3 request case (fixes issue found in testing the read
           compound patch)
      
         - iovec error case in response processing"
      
      * tag '6.6-rc3-ksmbd-server-fixes' of git://git.samba.org/ksmbd:
        ksmbd: check iov vector index in ksmbd_conn_write()
        ksmbd: return invalid parameter error response if smb2 request is invalid
      9f3ebbef
    • Linus Torvalds's avatar
      Merge tag 'ceph-for-6.6-rc4' of https://github.com/ceph/ceph-client · 14c06b91
      Linus Torvalds authored
      Pull ceph fixes from Ilya Dryomov:
       "A series that fixes an involved 'double watch error' deadlock in RBD
        marked for stable and two cleanups"
      
      * tag 'ceph-for-6.6-rc4' of https://github.com/ceph/ceph-client:
        rbd: take header_rwsem in rbd_dev_refresh() only when updating
        rbd: decouple parent info read-in from updating rbd_dev
        rbd: decouple header read-in from updating rbd_dev->header
        rbd: move rbd_dev_refresh() definition
        Revert "ceph: make members in struct ceph_mds_request_args_ext a union"
        ceph: remove unnecessary check for NULL in parse_longname()
      14c06b91
    • Linus Torvalds's avatar
      Merge tag 'xfs-6.6-fixes-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux · 10c0b6ba
      Linus Torvalds authored
      Pull xfs fix from Chandan Babu:
      
       - fix for commit 68b957f6 ("xfs: load uncached unlinked inodes into
         memory on demand") which address review comments provided by Dave
         Chinner
      
      * tag 'xfs-6.6-fixes-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
        xfs: fix reloading entire unlinked bucket lists
      10c0b6ba
    • Uwe Kleine-König's avatar
      MAINTAINERS: Fix Florian Fainelli's email address · b0b88a58
      Uwe Kleine-König authored
      Commit 31345a0f ("MAINTAINERS: Replace my email address") added 13
      instances of ...@broadcom.com and one of only ...@broadcom. I didn't
      double check if Broadcom really owns that TLD, but git send-email
      doesn't accept it, so add ".com" to that one bogous(?) instance.
      
      Fixes: 31345a0f
      
       ("MAINTAINERS: Replace my email address")
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Acked-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      b0b88a58
    • Linus Torvalds's avatar
      Merge tag 'ata-6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata · 95289e49
      Linus Torvalds authored
      Pull ATA fixes from Damien Le Moal:
       "A larger than usual set of fixes for 6.6-rc4 due to the unexpected
        number of fixes needed to address ATA disks suspend/resume issues.
      
        In more detail:
      
         - Add missing additionalProperties on child nodes to the pata-common
           DT bindings (Rob)
      
         - Fix handling of the REPORT SUPPORTED OPERATION CODES command to
           ignore reserved bits (Niklas)
      
         - Increase port multiplier soft reset timeout to accomodate slow
           devices and avoid issues on wakeup (Matthias)
      
         - A couple of minor code fixes to avoid compilation warnings in
           libata-core and libata-eh (me)
      
         - Many patches from me to address suspend/resume issues, and in
           particular a potential deadlock on resume due to the SCSI disk
           driver resume operation not being synchronized with libata EH port
           resume handling.
      
           This is addressed by changing the scsi disk driver disk start/stop
           control to allow libata to execute disk suspend (spin down) and
           resume (spin up) on its own during system suspend/resume. Runtime
           suspend/resume control remains with the SCSI disk driver.
      
           Other fixes include:
            - Fix libata power management request issuing to avoid races
            - Establish a link between ATA ports and SCSI devices to order PM
              operations
            - Fix device removal to avoid issues with driver rmmod removal
            - Fix synchronization of libata device rescan and SCSI disk resume
              operation
            - Remove libsas PM operations as suspend/resume is handled
              directly by the sas controller resume
            - Fix the SCSI disk driver to not issue commands to suspended
              disks, thus avoiding potential system lock-up on resume"
      
      * tag 'ata-6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata:
        ata: libata-eh: Fix compilation warning in ata_eh_link_report()
        ata: libata-core: Fix compilation warning in ata_dev_config_ncq()
        scsi: sd: Do not issue commands to suspended disks on shutdown
        ata: libata-core: Do not register PM operations for SAS ports
        ata: libata-scsi: Fix delayed scsi_rescan_device() execution
        scsi: Do not attempt to rescan suspended devices
        ata: libata-scsi: Disable scsi device manage_system_start_stop
        scsi: sd: Differentiate system and runtime start/stop management
        ata: libata-scsi: link ata port and scsi device
        ata: libata-core: Fix port and device removal
        ata: libata-core: Fix ata_port_request_pm() locking
        ata: libata-sata: increase PMP SRST timeout to 10s
        ata: libata-scsi: ignore reserved bits for REPORT SUPPORTED OPERATION CODES
        dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes
      95289e49
    • Linus Torvalds's avatar
      Merge tag 'block-6.6-2023-09-28' of git://git.kernel.dk/linux · eafdc507
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
       "Just two minor comment / documentation fixes for the block side"
      
      * tag 'block-6.6-2023-09-28' of git://git.kernel.dk/linux:
        block: fix kernel-doc for disk_force_media_change()
        block: correct stale comment in rq_qos_wait
      eafdc507
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.6-2023-09-28' of git://git.kernel.dk/linux · a98b9595
      Linus Torvalds authored
      Pull io_uring fix from Jens Axboe:
       "A single fix going to stable for the IORING_OP_LINKAT flag handling"
      
      * tag 'io_uring-6.6-2023-09-28' of git://git.kernel.dk/linux:
        io_uring/fs: remove sqe->rw_flags checking from LINKAT
      a98b9595
    • Linus Torvalds's avatar
      Merge tag 'slab-fixes-for-6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab · 1c84724c
      Linus Torvalds authored
      Pull slab fixes from Vlastimil Babka:
      
       - stable fix to prevent list corruption when destroying caches with
         leftover objects (Rafael Aquini)
      
       - fix for a gotcha in kmalloc_size_roundup() when calling it with too
         high size, discovered when recently a networking call site had to be
         fixed for a different issue (David Laight)
      
      * tag 'slab-fixes-for-6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab:
        slab: kmalloc_size_roundup() must not return 0 for non-zero size
        mm/slab_common: fix slab_caches list corruption after kmem_cache_destroy()
      1c84724c
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2023-09-29' of git://anongit.freedesktop.org/drm/drm · 6edc84bc
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Regular pull, this feel suspiciously light so I expect next week might
        be a bit heavier? Let's see how we go. This is from a code point of
        view ivpu and i915 fixes.
      
        The only other patch is adding Danilo Krummrich to the nouveau
        maintainers, he's agreed to take on more of the roll after Ben
        retired.
      
        MAINTAINERS:
         - add Danilo for nouveau
      
        ivpu:
         - Add PCI ids for Arrow Lake
         - Fix memory corruption during IPC
         - Avoid dmesg flooding
         - 40xx: Wait for clock resource
         - 40xx: Fix interrupt usage
         - 40xx: Support caching when loading firmware
      
        i915:
         - Fix a panic regression on gen8_ggtt_insert_entries
         - Fix load issue due to reservation address in ggtt_reserve_guc_top
         - Fix a possible deadlock with guc busyness worker"
      
      * tag 'drm-fixes-2023-09-29' of git://anongit.freedesktop.org/drm/drm:
        accel/ivpu: Use cached buffers for FW loading
        accel/ivpu/40xx: Fix missing VPUIP interrupts
        accel/ivpu/40xx: Disable frequency change interrupt
        accel/ivpu/40xx: Ensure clock resource ownership Ack before Power-Up
        accel/ivpu: Don't flood dmesg with VPU ready message
        accel/ivpu: Do not use wait event interruptible
        MAINTAINERS: update nouveau maintainers
        i915/guc: Get runtime pm in busyness worker only if already active
        drm/i915/gt: Fix reservation address in ggtt_reserve_guc_top
        i915: Limit the length of an sg list to the requested length
        accel/ivpu: Add Arrow Lake pci id
      6edc84bc
    • Linus Torvalds's avatar
      Merge tag 'gpio-fixes-for-v6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux · 71e58659
      Linus Torvalds authored
      Pull gpio fixes from Bartosz Golaszewski:
      
       - fix a potential spinlock deadlock in gpio-timberdale
      
       - mark the gpio-pmic-eic-sprd driver as one that can sleep
      
      * tag 'gpio-fixes-for-v6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux:
        gpio: pmic-eic-sprd: Add can_sleep flag for PMIC EIC chip
        gpio: timberdale: Fix potential deadlock on &tgpio->lock
      71e58659
  4. Sep 29, 2023
  5. Sep 28, 2023
    • Chuck Lever's avatar
      NFSD: Fix zero NFSv4 READ results when RQ_SPLICE_OK is not set · 0d32a6bb
      Chuck Lever authored
      
      
      nfsd4_encode_readv() uses xdr->buf->page_len as a starting point for
      the nfsd_iter_read() sink buffer -- page_len is going to be offset
      by the parts of the COMPOUND that have already been encoded into
      xdr->buf->pages.
      
      However, that value must be captured /before/
      xdr_reserve_space_vec() advances page_len by the expected size of
      the read payload. Otherwise, the whole front part of the first
      page of the payload in the reply will be uninitialized.
      
      Mantas hit this because sec=krb5i forces RQ_SPLICE_OK off, which
      invokes the readv part of the nfsd4_encode_read() path. Also,
      older Linux NFS clients appear to send shorter READ requests
      for files smaller than a page, whereas newer clients just send
      page-sized requests and let the server send as many bytes as
      are in the file.
      
      Reported-by: default avatarMantas Mikulėnas <grawity@gmail.com>
      Closes: https://lore.kernel.org/linux-nfs/f1d0b234-e650-0f6e-0f5d-126b3d51d1eb@gmail.com/
      Fixes: 703d7521
      
       ("NFSD: Hoist rq_vec preparation into nfsd_read() [step two]")
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      0d32a6bb
    • Damien Le Moal's avatar
      ata: libata-eh: Fix compilation warning in ata_eh_link_report() · 49728bdc
      Damien Le Moal authored
      
      
      The 6 bytes length of the tries_buf string in ata_eh_link_report() is
      too short and results in a gcc compilation warning with W-!:
      
      drivers/ata/libata-eh.c: In function ‘ata_eh_link_report’:
      drivers/ata/libata-eh.c:2371:59: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 4 [-Wformat-truncation=]
       2371 |                 snprintf(tries_buf, sizeof(tries_buf), " t%d",
            |                                                           ^~
      drivers/ata/libata-eh.c:2371:56: note: directive argument in the range [-2147483648, 4]
       2371 |                 snprintf(tries_buf, sizeof(tries_buf), " t%d",
            |                                                        ^~~~~~
      drivers/ata/libata-eh.c:2371:17: note: ‘snprintf’ output between 4 and 14 bytes into a destination of size 6
       2371 |                 snprintf(tries_buf, sizeof(tries_buf), " t%d",
            |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       2372 |                          ap->eh_tries);
            |                          ~~~~~~~~~~~~~
      
      Avoid this warning by increasing the string size to 16B.
      
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      49728bdc
    • Damien Le Moal's avatar
      ata: libata-core: Fix compilation warning in ata_dev_config_ncq() · ed518d9b
      Damien Le Moal authored
      
      
      The 24 bytes length allocated to the ncq_desc string in
      ata_dev_config_lba() for ata_dev_config_ncq() to use is too short,
      causing the following gcc compilation warnings when compiling with W=1:
      
      drivers/ata/libata-core.c: In function ‘ata_dev_configure’:
      drivers/ata/libata-core.c:2378:56: warning: ‘%d’ directive output may be truncated writing between 1 and 2 bytes into a region of size between 1 and 11 [-Wformat-truncation=]
       2378 |                 snprintf(desc, desc_sz, "NCQ (depth %d/%d)%s", hdepth,
            |                                                        ^~
      In function ‘ata_dev_config_ncq’,
          inlined from ‘ata_dev_config_lba’ at drivers/ata/libata-core.c:2649:8,
          inlined from ‘ata_dev_configure’ at drivers/ata/libata-core.c:2952:9:
      drivers/ata/libata-core.c:2378:41: note: directive argument in the range [1, 32]
       2378 |                 snprintf(desc, desc_sz, "NCQ (depth %d/%d)%s", hdepth,
            |                                         ^~~~~~~~~~~~~~~~~~~~~
      drivers/ata/libata-core.c:2378:17: note: ‘snprintf’ output between 16 and 31 bytes into a destination of size 24
       2378 |                 snprintf(desc, desc_sz, "NCQ (depth %d/%d)%s", hdepth,
            |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       2379 |                         ddepth, aa_desc);
            |                         ~~~~~~~~~~~~~~~~
      
      Avoid these warnings and the potential truncation by changing the size
      of the ncq_desc string to 32 characters.
      
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      ed518d9b
    • Damien Le Moal's avatar
      scsi: sd: Do not issue commands to suspended disks on shutdown · 99398d20
      Damien Le Moal authored
      
      
      If an error occurs when resuming a host adapter before the devices
      attached to the adapter are resumed, the adapter low level driver may
      remove the scsi host, resulting in a call to sd_remove() for the
      disks of the host. This in turn results in a call to sd_shutdown() which
      will issue a synchronize cache command and a start stop unit command to
      spindown the disk. sd_shutdown() issues the commands only if the device
      is not already runtime suspended but does not check the power state for
      system-wide suspend/resume. That is, the commands may be issued with the
      device in a suspended state, which causes PM resume to hang, forcing a
      reset of the machine to recover.
      
      Fix this by tracking the suspended state of a disk by introducing the
      suspended boolean field in the scsi_disk structure. This flag is set to
      true when the disk is suspended is sd_suspend_common() and resumed with
      sd_resume(). When suspended is true, sd_shutdown() is not executed from
      sd_remove().
      
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
      Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      99398d20
    • Damien Le Moal's avatar
      ata: libata-core: Do not register PM operations for SAS ports · 75e2bd5f
      Damien Le Moal authored
      libsas does its own domain based power management of ports. For such
      ports, libata should not use a device type defining power management
      operations as executing these operations for suspend/resume in addition
      to libsas calls to ata_sas_port_suspend() and ata_sas_port_resume() is
      not necessary (and likely dangerous to do, even though problems are not
      seen currently).
      
      Introduce the new ata_port_sas_type device_type for ports managed by
      libsas. This new device type is used in ata_tport_add() and is defined
      without power management operations.
      
      Fixes: 2fcbdcb4
      
       ("[SCSI] libata: export ata_port suspend/resume infrastructure for sas")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Tested-by: default avatarChia-Lin Kao (AceLan) <acelan.kao@canonical.com>
      Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
      Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      75e2bd5f