Skip to content
Commit ff7e0055 authored by Andy Lutomirski's avatar Andy Lutomirski Committed by Rusty Russell
Browse files

module: Clean up ro/nx after early module load failures

The commit

    4982223e

 module: set nx before marking module MODULE_STATE_COMING.

introduced a regression: if a module fails to parse its arguments or
if mod_sysfs_setup fails, then the module's memory will be freed
while still read-only.  Anything that reuses that memory will crash
as soon as it tries to write to it.

Cc: stable@vger.kernel.org # v3.16
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAndy Lutomirski <luto@amacapital.net>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent c9d26423
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment