Skip to content
Commit fce15c45 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (lm90) Fix usage of CONFIG2 register in detect function



The detect function had a comment "Make compiler happy" when id did not
read the second configuration register. As it turns out, the code was
checking the contents of this register for manufacturer ID 0xA1 (NXP
Semiconductor/Philips), but never actually read the register. So it
wasn't surprising that the compiler complained, and it indeed had a point.
Fix the code to read the register contents for manufacturer ID 0xa1.

At the same time, the code was reading the register for manufacturer ID
0x41 (Analog Devices), but it was not using the results. In effect it was
just checking if reading the register returned an error. That doesn't
really add much if any value, so stop doing that.

Fixes: f90be42f ("hwmon: (lm90) Refactor reading of config2 register")
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2585cf9d
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment