Skip to content
Commit f88acaed authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

net: mdiobus: fix double put fwnode in the error path



[ Upstream commit 165df241 ]

If phy_device_register() or fwnode_mdiobus_phy_device_register()
fail, phy_device_free() is called, the device refcount is decreased
to 0, then fwnode_handle_put() will be called in phy_device_release(),
but in the error path, fwnode_handle_put() has already been called,
so set fwnode to NULL after fwnode_handle_put() in the error path to
avoid double put.

Fixes: cdde1560 ("net: mdiobus: fix unbalanced node reference count")
Reported-by: default avatarZeng Heng <zengheng4@huawei.com>
Tested-by: default avatarZeng Heng <zengheng4@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarZeng Heng <zengheng4@huawei.com>
Tested-by: default avatarZeng Heng <zengheng4@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent cc62d769
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment