Skip to content
Commit f3221361 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

net: tls: avoid hanging tasks on the tx_lock



syzbot sent a hung task report and Eric explains that adversarial
receiver may keep RWIN at 0 for a long time, so we are not guaranteed
to make forward progress. Thread which took tx_lock and went to sleep
may not release tx_lock for hours. Use interruptible sleep where
possible and reschedule the work if it can't take the lock.

Testing: existing selftest passes

Reported-by: default avatar <syzbot+9c0268252b8ef967c62e@syzkaller.appspotmail.com>
Fixes: 79ffe608 ("net/tls: add a TX lock")
Link: https://lore.kernel.org/all/000000000000e412e905f5b46201@google.com/


Cc: stable@vger.kernel.org # wait 4 weeks
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230301002857.2101894-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 49c47cc2
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment