Skip to content
Commit ef28df55 authored by Paul Moore's avatar Paul Moore
Browse files

selinux: ensure the context is NUL terminated in security_context_to_sid_core()



The syzbot/syzkaller automated tests found a problem in
security_context_to_sid_core() during early boot (before we load the
SELinux policy) where we could potentially feed context strings without
NUL terminators into the strcmp() function.

We already guard against this during normal operation (after the SELinux
policy has been loaded) by making a copy of the context strings and
explicitly adding a NUL terminator to the end.  The patch extends this
protection to the early boot case (no loaded policy) by moving the context
copy earlier in security_context_to_sid_core().

Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
Reviewed-By: default avatarWilliam Roberts <william.c.roberts@intel.com>
parent 4f0753e7
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment