Skip to content
Commit e8e0f0f4 authored by Hangbin Liu's avatar Hangbin Liu Committed by Daniel Borkmann
Browse files

bpf, devmap: Remove drops variable from bq_xmit_all()



As Colin pointed out, the first drops assignment after declaration will
be overwritten by the second drops assignment before using, which makes
it useless.

Since the drops variable will be used only once. Just remove it and
use "cnt - sent" in trace_xdp_devmap_xmit().

Fixes: cb261b59 ("bpf: Run devmap xdp_prog on flush instead of bulk enqueue")
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20210528024356.24333-1-liuhangbin@gmail.com
parent fc8c262e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment