Skip to content
Commit e44b49f6 authored by Zhu Lingshan's avatar Zhu Lingshan Committed by Marc Zyngier
Browse files

Revert "irqbypass: do not start cons/prod when failed connect"



This reverts commit a979a6aa.

The reverted commit may cause VM freeze on arm64 with GICv4,
where stopping a consumer is implemented by suspending the VM.
Should the connect fail, the VM will not be resumed, which
is a bit of a problem.

It also erroneously calls the producer destructor unconditionally,
which is unexpected.

Reported-by: default avatarShaokun Zhang <zhangshaokun@hisilicon.com>
Suggested-by: default avatarMarc Zyngier <maz@kernel.org>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Tested-by: default avatarShaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: default avatarZhu Lingshan <lingshan.zhu@intel.com>
[maz: tags and cc-stable, commit message update]
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Fixes: a979a6aa ("irqbypass: do not start cons/prod when failed connect")
Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com...
parent 6efb943b
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment