Skip to content
Commit e3b3afd3 authored by Matti Vaittinen's avatar Matti Vaittinen Committed by Wim Van Sebroeck
Browse files

watchdog: bd9576: Drop "always-running" property

The always-running (from linux,wdt-gpio.yaml) is abused by the BD9576
watchdog driver. It's defined meaning is "the watchdog is always running
and can not be stopped". The BD9576 watchdog driver has implemented it
as "start watchdog when loading the module and prevent it from being
stopped".

Furthermore, the implementation does not set the WDOG_HW_RUNNING when
enabling the watchdog due to the "always-running" at module loading.
This will end up resulting a watchdog timeout if the device is not
opened.

The culprit was pointed out by Guenter, discussion can be found from
https://lore.kernel.org/lkml/4fa3a64b-60fb-4e5e-8785-0f14da37eea2@roeck-us.net/



Drop the invalid "always-running" handling.

Signed-off-by: default avatarMatti Vaittinen <mazziesaccount@gmail.com>
Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
Fixes: b237bcac ("wdt: Support wdt on ROHM BD9576MUF and BD9573MUF")
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/ZhPAt76yaJMersXf@fedora


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 56e23c6d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment