Skip to content
Commit dda3bbbb authored by Saeed Mahameed's avatar Saeed Mahameed Committed by Jakub Kicinski
Browse files

Revert "net/mlx5e: MACsec, remove replay window size limitation in offload path"



This reverts commit c0071be0.

The cited commit removed the validity checks which initialized the
window_sz and never removed the use of the now uninitialized variable,
so now we are left with wrong value in the window size and the following
clang warning: [-Wuninitialized]
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c:232:45:
       warning: variable 'window_sz' is uninitialized when used here
       MLX5_SET(macsec_aso, aso_ctx, window_size, window_sz);

Revet at this time to address the clang issue due to lack of time to
test the proper solution.

Fixes: c0071be0 ("net/mlx5e: MACsec, remove replay window size limitation in offload path")
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Reported-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20221129093006.378840-1-saeed@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e493bec3
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment