Skip to content
Commit dcd479e1 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: always wind down STA state



When (for example) an IBSS station is pre-moved to AUTHORIZED
before it's inserted, and then the insertion fails, we don't
clean up the fast RX/TX states that might already have been
created, since we don't go through all the state transitions
again on the way down.

Do that, if it hasn't been done already, when the station is
freed. I considered only freeing the fast TX/RX state there,
but we might add more state so it's more robust to wind down
the state properly.

Note that we warn if the station was ever inserted, it should
have been properly cleaned up in that case, and the driver
will probably not like things happening out of order.

Reported-by: default avatar <syzbot+2e293dbd67de2836ba42@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/r/20201009141710.7223b322a955.I95bd08b9ad0e039c034927cce0b75beea38e059b@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9bdaf3b9
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment