Skip to content
Commit bc5519c1 authored by Kevin Groeneveld's avatar Kevin Groeneveld Committed by Martin K. Petersen
Browse files

scsi: sr: Fix typo in CDROM(CLOSETRAY|EJECT) handling

Commit 2e27f576 ("scsi: scsi_ioctl: Call scsi_cmd_ioctl() from
scsi_ioctl()") seems to have a typo as it is checking ret instead of cmd in
the if statement checking for CDROMCLOSETRAY and CDROMEJECT.  This changes
the behaviour of these ioctls as the cdrom_ioctl handling of these is more
restrictive than the scsi_ioctl version.

Link: https://lore.kernel.org/r/20220323002242.21157-1-kgroeneveld@lenbrook.com


Fixes: 2e27f576 ("scsi: scsi_ioctl: Call scsi_cmd_ioctl() from scsi_ioctl()")
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKevin Groeneveld <kgroeneveld@lenbrook.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f16aa285
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment