Skip to content
Commit b5875222 authored by Keith Busch's avatar Keith Busch Committed by Jens Axboe
Browse files

NVMe: IO ending fixes on surprise removal



This patch fixes a lost request discovered during IO + hot removal.

The driver's pci removal deletes gendisks prior to shutting down the
controller to allow dirty data to sync. Dirty data can not be synced on
a surprise removal, though, and would potentially block indefinitely.

The driver previously had marked the queue as dying in this scenario
to prevent new requests from attempting, however it will still block
for requests that already entered the queue. This patch fixes this by
quiescing IO first, then aborting the requeued requests before deleting
disks.

Reported-by: default avatarSujith Pandel <sujith_pandel@dell.com>
Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Tested-by: default avatarSujith Pandel <sujith_pandel@dell.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent af096e22
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment