Skip to content
Commit b178aa6f authored by Hans Verkuil's avatar Hans Verkuil
Browse files

media: b2c2: flexcop-usb: fix flexcop_usb_memory_req



smatch generated this warning:

drivers/media/usb/b2c2/flexcop-usb.c:199 flexcop_usb_memory_req() warn: iterator 'i' not incremented

and indeed the function is not using i or updating buf.

The reason this always worked is that this function is called to write just
6 bytes (a MAC address) to the USB device, and so in practice there is only
a single chunk written. If we ever would need to write more than one chunk,
this function would fail since each chunk would read from or write to the
same buf address.

Rewrite the function to properly handle this.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent e1bda64a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment