Skip to content
Commit af545bb5 authored by Jeff Vander Stoep's avatar Jeff Vander Stoep Committed by Jakub Kicinski
Browse files

vsock: use ns_capable_noaudit() on socket create



During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restricted VM. Unfortunately, if the caller doesn't have
CAP_NET_ADMIN, an audit message such as an selinux denial is
generated even if the caller does not want a trusted socket.

Logging errors on success is confusing. To avoid this, switch the
capable(CAP_NET_ADMIN) check to the noaudit version.

Reported-by: default avatarRoman Kiryanov <rkir@google.com>
https://android-review.googlesource.com/c/device/generic/goldfish/+/1468545/


Signed-off-by: default avatarJeff Vander Stoep <jeffv@google.com>
Reviewed-by: default avatarJames Morris <jamorris@linux.microsoft.com>
Link: https://lore.kernel.org/r/20201023143757.377574-1-jeffv@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 937d8420
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment