Skip to content
Commit ad5f97fa authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

r8169: fix network stalls due to missing bit TXCFG_AUTO_FIFO



Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
in register TxConfig. The original patch changed the order of some
calls resulting in these changes being overwritten by
rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
resulted in network stalls especially under high load.

Analyzing the chip-specific hw_start functions all chip version from
34, with the exception of version 39, need this bit set.
This patch moves setting this bit to rtl_set_tx_config_registers().

Fixes: 4fd48c4a ("r8169: move common initializations to tp->hw_start")
Reported-by: default avatarOrtwin Glück <odi@odi.ch>
Reported-by: default avatarDavid Arendt <admin@prnet.org>
Root-caused-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Tested-by: default avatarTony Atkinson <tatkinson@linux.com>
Tested-by: default avatarDavid Arendt <admin@prnet.org>
Tested-by: default avatarOrtwin Glück <odi@odi.ch>
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2547496e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment