Skip to content
Commit a4eb355a authored by Will Deacon's avatar Will Deacon
Browse files

arm64: vdso: Fix CFI directives in sigreturn trampoline



Daniel reports that the .cfi_startproc is misplaced for the sigreturn
trampoline, which causes LLVM's unwinder to misbehave:

  | I run into this with LLVM’s unwinder.
  | This combination was always broken.

This prompted Dave to question our use of CFI directives more generally,
and I ended up going down a rabbit hole trying to figure out how this
very poorly documented stuff gets used.

Move the CFI directives so that the "mysterious NOP" is included in
the .cfi_{start,end}proc block and add a bunch of comments so that I
can save myself another headache in future.

Cc: Tamas Zsoldos <tamas.zsoldos@arm.com>
Reported-by: default avatarDave Martin <dave.martin@arm.com>
Reported-by: default avatarDaniel Kiss <daniel.kiss@arm.com>
Tested-by: default avatarDaniel Kiss <daniel.kiss@arm.com>
Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 9a964285
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment