Skip to content
Commit a2472305 authored by Zhang Qilong's avatar Zhang Qilong Committed by Bjorn Andersson
Browse files

remoteproc: q6v5-mss: fix error handling in q6v5_pds_enable



If the pm_runtime_get_sync failed in q6v5_pds_enable when
loop (i), The unroll_pd_votes will start from (i - 1), and
it will resulted in following problems:

  1) pm_runtime_get_sync will increment pm usage counter even it
     failed. Forgetting to pm_runtime_put_noidle will result in
     reference leak.

  2) Have not reset pds[i] performance state.

Then we fix it.

Fixes: 4760a896 ("remoteproc: q6v5-mss: Vote for rpmh power domains")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201102143433.143996-1-zhangqilong3@huawei.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent e59aef4e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment