Skip to content
Commit 9c6694c2 authored by Phil Elwell's avatar Phil Elwell Committed by Phil Elwell
Browse files

ASOC: dwc: Fix 16-bit audio handling



IMO the Synopsys datasheet could be clearer in this area, but it seems
that the DMA data ports (DMATX and DMARX) expect left and right samples
in alternate writes; if a stereo pair is pushed in a single 32-bit
write, the upper half is ignored, leading to double speed audio with a
confused stereo image. Make sure the necessary changes happen by
updating the DMA configuration data in the hw_params method.

The set_bclk_ratio change was made at a time when it looked like it
could be causing an error, but I think the division of responsibilities
is clearer this way (and the kernel log clearer without the info-level
message).

Signed-off-by: default avatarPhil Elwell <phil@raspberrypi.com>
parent e6baee45
  • mirror @mirror

    mentioned in commit 52545628

    ·

    mentioned in commit 52545628

    Toggle commit list
  • mirror @mirror

    mentioned in commit a7f413faa8282c329faec8e310186f85d3cec3c6

    ·

    mentioned in commit a7f413faa8282c329faec8e310186f85d3cec3c6

    Toggle commit list
  • mirror @mirror

    mentioned in commit 8156681d0e83d050cf2d568ff485f343443d4a4d

    ·

    mentioned in commit 8156681d0e83d050cf2d568ff485f343443d4a4d

    Toggle commit list
  • mirror @mirror

    mentioned in commit 2a70f9572b4e87c0a9d901e6bd5107583fafc987

    ·

    mentioned in commit 2a70f9572b4e87c0a9d901e6bd5107583fafc987

    Toggle commit list
  • mirror @mirror

    mentioned in commit 538aadca213d2ec0e39717fe3bd3bcdbe875165a

    ·

    mentioned in commit 538aadca213d2ec0e39717fe3bd3bcdbe875165a

    Toggle commit list
  • mirror @mirror

    mentioned in commit 92ef2a0afc1dec3dfdc2b14fd108183927a13045

    ·

    mentioned in commit 92ef2a0afc1dec3dfdc2b14fd108183927a13045

    Toggle commit list
  • mirror @mirror

    mentioned in commit 04b99a20a5f4f4393135662c6bcfbe462566a1bb

    ·

    mentioned in commit 04b99a20a5f4f4393135662c6bcfbe462566a1bb

    Toggle commit list
  • mirror @mirror

    mentioned in commit c09d48d0

    ·

    mentioned in commit c09d48d0

    Toggle commit list
  • mirror @mirror

    mentioned in commit ef88a22236accc741e2c88d10fde510db1be72f1

    ·

    mentioned in commit ef88a22236accc741e2c88d10fde510db1be72f1

    Toggle commit list
  • mirror @mirror

    mentioned in commit 9ffacbff56455f19f8db69c14b79683040ea7c44

    ·

    mentioned in commit 9ffacbff56455f19f8db69c14b79683040ea7c44

    Toggle commit list
  • mirror @mirror

    mentioned in commit 9e2cab716c4de8afc2d134343bc856edcaebe452

    ·

    mentioned in commit 9e2cab716c4de8afc2d134343bc856edcaebe452

    Toggle commit list
  • mirror @mirror

    mentioned in commit 5558fd248014e5b8fce9d4554220f7f2f1d0d220

    ·

    mentioned in commit 5558fd248014e5b8fce9d4554220f7f2f1d0d220

    Toggle commit list
  • mirror @mirror

    mentioned in commit c9153a8a1933bc81594c592ea053bb72bd3a9222

    ·

    mentioned in commit c9153a8a1933bc81594c592ea053bb72bd3a9222

    Toggle commit list
  • mirror @mirror

    mentioned in commit 0ef597d4e3a09631e15b0d145673094dd7b8f6a3

    ·

    mentioned in commit 0ef597d4e3a09631e15b0d145673094dd7b8f6a3

    Toggle commit list
  • mirror @mirror

    mentioned in commit acab854a4feb603f1c45f8b406119c0086e2e0b5

    ·

    mentioned in commit acab854a4feb603f1c45f8b406119c0086e2e0b5

    Toggle commit list
  • mirror @mirror

    mentioned in commit 006b8eab7bbda8eb35bbd4659c5839c5ce5b016a

    ·

    mentioned in commit 006b8eab7bbda8eb35bbd4659c5839c5ce5b016a

    Toggle commit list
  • mirror @mirror

    mentioned in commit f990088c2482f6d162f39e4319b28e713e1b214b

    ·

    mentioned in commit f990088c2482f6d162f39e4319b28e713e1b214b

    Toggle commit list
  • mirror @mirror

    mentioned in commit ccccb3ec

    ·

    mentioned in commit ccccb3ec

    Toggle commit list
  • mirror @mirror

    mentioned in commit 200583ddc49226f23d26b609e8d24b5390d8a840

    ·

    mentioned in commit 200583ddc49226f23d26b609e8d24b5390d8a840

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment