Skip to content
Commit 8fafac20 authored by Dan Carpenter's avatar Dan Carpenter Committed by Juergen Gross
Browse files

xen/pvcalls-back: fix double frees with pvcalls_new_active_socket()



In the pvcalls_new_active_socket() function, most error paths call
pvcalls_back_release_active(fedata->dev, fedata, map) which calls
sock_release() on "sock".  The bug is that the caller also frees sock.

Fix this by making every error path in pvcalls_new_active_socket()
release the sock, and don't free it in the caller.

Fixes: 5db4d286 ("xen/pvcalls: implement connect command")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/e5f98dc2-0305-491f-a860-71bbd1398a2f@kili.mountain


Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent b6ebaa81
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment