Skip to content
Commit 8ecd39cb authored by THOBY Simon's avatar THOBY Simon Committed by Mimi Zohar
Browse files

IMA: prevent SETXATTR_CHECK policy rules with unavailable algorithms



SETXATTR_CHECK policy rules assume that any algorithm listed in the
'appraise_algos' flag must be accepted when performing setxattr() on
the security.ima xattr.  However nothing checks that they are
available in the current kernel.  A userland application could hash
a file with a digest that the kernel wouldn't be able to verify.
However, if SETXATTR_CHECK is not in use, the kernel already forbids
that xattr write.

Verify that algorithms listed in appraise_algos are available to the
current kernel and reject the policy update otherwise. This will fix
the inconsistency between SETXATTR_CHECK and non-SETXATTR_CHECK
behaviors.

That filtering is only performed in ima_parse_appraise_algos() when
updating policies so that we do not have to pay the price of
allocating a hash object every time validate_hash_algo() is called
in ima_inode_setxattr().

Signed-off-by: default avatarTHOBY Simon <Simon.THOBY@viveris.fr>
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
parent 4f2946aa
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment