Skip to content
Commit 83d3c4f2 authored by Lasse Collin's avatar Lasse Collin Committed by Gao Xiang
Browse files

lib/xz: Avoid overlapping memcpy() with invalid input with in-place decompression

With valid files, the safety margin described in lib/decompress_unxz.c
ensures that these buffers cannot overlap. But if the uncompressed size
of the input is larger than the caller thought, which is possible when
the input file is invalid/corrupt, the buffers can overlap. Obviously
the result will then be garbage (and usually the decoder will return
an error too) but no other harm will happen when such an over-run occurs.

This change only affects uncompressed LZMA2 chunks and so this
should have no effect on performance.

Link: https://lore.kernel.org/r/20211010213145.17462-2-xiang@kernel.org


Signed-off-by: default avatarLasse Collin <lasse.collin@tukaani.org>
Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent 38629291
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment