video: fbdev: fbcvt.c: fix printing in fb_cvt_print_name()
This code has two bugs: 1) "cnt" is 255 but the size of the buffer is 256 so the last byte is not used. 2) If we try to print more than 255 characters then "cnt" will be negative and that will trigger a WARN() in snprintf(). The fix for this is to use scnprintf() instead of snprintf(). We can re-write this code to be cleaner: 1) Rename "offset" to "off" because that's shorter. 2) Get rid of the "cnt" variable and just use "size - off" directly. 3) Get rid of the "read" variable and just increment "off" directly. Fixes: 96fe6a21 ("fbdev: Add VESA Coordinated Video Timings (CVT) support") Signed-off-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Helge Deller <deller@gmx.de>
parent
6a3827ea
Please register or sign in to comment