Skip to content
Commit 74569cb9 authored by Chang S. Bae's avatar Chang S. Bae Committed by Greg Kroah-Hartman
Browse files

x86/signal: Detect and prevent an alternate signal stack overflow



[ Upstream commit 2beb4a53 ]

The kernel pushes context on to the userspace stack to prepare for the
user's signal handler. When the user has supplied an alternate signal
stack, via sigaltstack(2), it is easy for the kernel to verify that the
stack size is sufficient for the current hardware context.

Check if writing the hardware context to the alternate stack will exceed
it's size. If yes, then instead of corrupting user-data and proceeding with
the original signal handler, an immediate SIGSEGV signal is delivered.

Refactor the stack pointer check code from on_sig_stack() and use the new
helper.

While the kernel allows new source code to discover and use a sufficient
alternate signal stack size, this check is still necessary to protect
binaries with insufficient alternate signal stack size from data
corruption.

Fixes: c2bc11f1 ("x86, AVX-512: Enable AVX-512 States Context Switch")
Reported-by: default avatarFlorian Weimer <fweimer@redhat.com>
Suggested-by: default avatarJann Horn <jannh@google.com>
Suggested-by: default avatarAndy Lutomirski <luto@kernel.org>
Signed-off-by: default avatarChang S. Bae <chang.seok.bae@intel.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarLen Brown <len.brown@intel.com>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20210518200320.17239-6-chang.seok.bae@intel.com
Link: https://bugzilla.kernel.org/show_bug.cgi?id=153531


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f0e905df
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment