Skip to content
Commit 6e54ea37 authored by Paolo Abeni's avatar Paolo Abeni Committed by David S. Miller
Browse files

net: mctp: hold key reference when looking up a general key



Currently, we have a race where we look up a sock through a "general"
(ie, not directly associated with the (src,dest,tag) tuple) key, then
drop the key reference while still holding the key's sock.

This change expands the key reference until we've finished using the
sock, and hence the sock reference too.

Commit message changes from Jeremy Kerr <jk@codeconstruct.com.au>.

Reported-by: default avatarNoam Rathaus <noamr@ssd-disclosure.com>
Fixes: 73c61845

 ("mctp: locking, lifetime and validity changes for sk_keys")
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5f41ae6f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment