Skip to content
Commit 6b6bc5b8 authored by Zheng Wang's avatar Zheng Wang Committed by David S. Miller
Browse files

net: qcom/emac: Fix use after free bug in emac_remove due to race condition



In emac_probe, &adpt->work_thread is bound with
emac_work_thread. Then it will be started by timeout
handler emac_tx_timeout or a IRQ handler emac_isr.

If we remove the driver which will call emac_remove
  to make cleanup, there may be a unfinished work.

The possible sequence is as follows:

Fix it by finishing the work before cleanup in the emac_remove
and disable timeout response.

CPU0                  CPU1

                    |emac_work_thread
emac_remove         |
free_netdev         |
kfree(netdev);      |
                    |emac_reinit_locked
                    |emac_mac_down
                    |//use netdev
Fixes: b9b17deb ("net: emac: emac gigabit ethernet controller driver")
Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a8eff035
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment