Skip to content
Commit 650b69b1 authored by Dai Ngo's avatar Dai Ngo Committed by Greg Kroah-Hartman
Browse files

NFSD: fix use-after-free in __nfs42_ssc_open()



[ Upstream commit 75333d48 ]

Problem caused by source's vfsmount being unmounted but remains
on the delayed unmount list. This happens when nfs42_ssc_open()
return errors.

Fixed by removing nfsd4_interssc_connect(), leave the vfsmount
for the laundromat to unmount when idle time expires.

We don't need to call nfs_do_sb_deactive when nfs42_ssc_open
return errors since the file was not opened so nfs_server->active
was not incremented. Same as in nfsd4_copy, if we fail to
launch nfsd4_do_async_copy thread then there's no need to
call nfs_do_sb_deactive

Reported-by: default avatarXingyuan Mo <hdthky0@gmail.com>
Signed-off-by: default avatarDai Ngo <dai.ngo@oracle.com>
Tested-by: default avatarXingyuan Mo <hdthky0@gmail.com>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ba50fee6
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment