Skip to content
Unverified Commit 62465415 authored by Matt Evans's avatar Matt Evans Committed by Arnd Bergmann
Browse files

locking/atomic: cmpxchg: Make __generic_cmpxchg_local compare against zero-extended 'old' value



__generic_cmpxchg_local takes unsigned long old/new arguments which
might end up being up-cast from smaller signed types (which will
sign-extend).  The loaded compare value must be compared against a
truncated smaller type, so down-cast appropriately for each size.

The issue is apparent on 64-bit machines with code, such as
atomic_dec_unless_positive(), that sign-extends from int.

64-bit machines generally don't use the generic cmpxchg but
development/early ports might make use of it, so make it correct.

Signed-off-by: default avatarMatt Evans <mev@rivosinc.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 88603b6d
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment