Skip to content
Commit 60c8144a authored by Borislav Petkov's avatar Borislav Petkov
Browse files

x86/MCE/AMD: Fix the thresholding machinery initialization order



Currently, the code sets up the thresholding interrupt vector and only
then goes about initializing the thresholding banks. Which is wrong,
because an early thresholding interrupt would cause a NULL pointer
dereference when accessing those banks and prevent the machine from
booting.

Therefore, set the thresholding interrupt vector only *after* having
initialized the banks successfully.

Fixes: 18807ddb ("x86/mce/AMD: Reset Threshold Limit after logging error")
Reported-by: default avatarRafał Miłecki <rafal@milecki.pl>
Reported-by: default avatarJohn Clemens <clemej@gmail.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Tested-by: default avatarRafał Miłecki <rafal@milecki.pl>
Tested-by: default avatarJohn Clemens <john@deater.net>
Cc: Aravind Gopalakrishnan <aravindksg.lkml@gmail.com>
Cc: linux-edac@vger.kernel.org
Cc: stable@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>
Cc: x86@kernel.org
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
Link: https://lkml.kernel.org/r/20181127101700.2964-1-zajec5@gmail.com
Link: https://bugzilla.kernel.org/show_bug.cgi?id=201291
parent ac26d1f7
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment