Skip to content
Commit 5d09c63f authored by Dan Williams's avatar Dan Williams
Browse files

cxl/hdm: Remove broken error path



Dan reports that cxl_decoder_commit() potentially leaks a hold of
cxl_dpa_rwsem. The potential error case is a "should not" happen
scenario, turn it into a "can not" happen scenario by adding the error
check to cxl_port_setup_targets() where other setting validation occurs.

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: http://lore.kernel.org/r/63295673-5d63-4919-b851-3b06d48734c0@moroto.mountain


Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Fixes: 176baefb ("cxl/hdm: Commit decoder state to hardware")
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 69d56b15
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment