Skip to content
Commit 543790f7 authored by Hans Verkuil's avatar Hans Verkuil Committed by Phil Elwell
Browse files

media: i2c: imx219: Selection compliance fixes

To comply with the intended usage of the V4L2 selection target when
used to retrieve a sensor image properties, adjust the rectangles
returned by the imx219 driver.

The top/left crop coordinates of the TGT_CROP rectangle were set to
(0, 0) instead of (8, 8) which is the offset from the larger physical
pixel array rectangle. This was also a mismatch with the default values
crop rectangle value, so this is corrected. Found with v4l2-compliance.

While at it, add V4L2_SEL_TGT_CROP_BOUNDS support: CROP_DEFAULT and
CROP_BOUNDS have the same size as the non-active pixels are not readable
using the selection API. Found with v4l2-compliance.

Fixes: e6d4ef7d

 ("media: i2c: imx219: Implement get_selection")
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
[reword commit message, use macros for pixel offsets]
Signed-off-by: default avatarJacopo Mondi <jacopo@jmondi.org>
parent 624a3520
  • mirror @mirror

    mentioned in commit a80c030e

    ·

    mentioned in commit a80c030e

    Toggle commit list
  • mirror @mirror

    mentioned in commit 35cf54a0

    ·

    mentioned in commit 35cf54a0

    Toggle commit list
  • mirror @mirror

    mentioned in commit 92f40662b52f3ffe349b1ae9b5ed76272dd1870b

    ·

    mentioned in commit 92f40662b52f3ffe349b1ae9b5ed76272dd1870b

    Toggle commit list
  • mirror @mirror

    mentioned in commit 4e1ac0e40deb63c89f9798905040f8cf5856b4f5

    ·

    mentioned in commit 4e1ac0e40deb63c89f9798905040f8cf5856b4f5

    Toggle commit list
  • mirror @mirror

    mentioned in commit c396d55c1f389eea28a49d31b5f58a08d6210fbd

    ·

    mentioned in commit c396d55c1f389eea28a49d31b5f58a08d6210fbd

    Toggle commit list
  • mirror @mirror

    mentioned in commit c31a9cefd65882b38b1b2fbd800cfa6a4dc4c72d

    ·

    mentioned in commit c31a9cefd65882b38b1b2fbd800cfa6a4dc4c72d

    Toggle commit list
  • mirror @mirror

    mentioned in commit e99ec850f206ef0beeb20e3297061fb60be046ff

    ·

    mentioned in commit e99ec850f206ef0beeb20e3297061fb60be046ff

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment