Skip to content
Commit 428b8f1d authored by Nick Desaulniers's avatar Nick Desaulniers Committed by Paolo Bonzini
Browse files

KVM: VMX: don't allow memory operands for inline asm that modifies SP



THUNK_TARGET defines [thunk_target] as having "rm" input constraints
when CONFIG_RETPOLINE is not set, which isn't constrained enough for
this specific case.

For inline assembly that modifies the stack pointer before using this
input, the underspecification of constraints is dangerous, and results
in an indirect call to a previously pushed flags register.

In this case `entry`'s stack slot is good enough to satisfy the "m"
constraint in "rm", but the inline assembly in
handle_external_interrupt_irqoff() modifies the stack pointer via
push+pushf before using this input, which in this case results in
calling what was the previous state of the flags register, rather than
`entry`.

Be more specific in the constraints by requiring `entry` be in a
register, and not a memory operand.

Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
Reported-by: default avatar <syzbot+3f29ca2efb056a761e38@syzkaller.appspotmail.com>
Debugged-by: default avatarAlexander Potapenko <glider@google.com>
Debugged-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Debugged-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Message-Id: <20200323191243.30002-1-ndesaulniers@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent edec6e01
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment