Skip to content
Commit 3a33d030 authored by Tom Roeder's avatar Tom Roeder Committed by Paolo Bonzini
Browse files

kvm: x86/vmx: Use kzalloc for cached_vmcs12

This changes the allocation of cached_vmcs12 to use kzalloc instead of
kmalloc. This removes the information leak found by Syzkaller (see
Reported-by) in this case and prevents similar leaks from happening
based on cached_vmcs12.

It also changes vmx_get_nested_state to copy out the full 4k VMCS12_SIZE
in copy_to_user rather than only the size of the struct.

Tested: rebuilt against head, booted, and ran the syszkaller repro
  https://syzkaller.appspot.com/text?tag=ReproC&x=174efca3400000

 without
  observing any problems.

Reported-by: default avatar <syzbot+ded1696f6b50b615b630@syzkaller.appspotmail.com>
Fixes: 8fcc4b59


Cc: stable@vger.kernel.org
Signed-off-by: default avatarTom Roeder <tmroeder@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 85ba2b16
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment