Skip to content
Commit 2fcb4090 authored by Johannes Berg's avatar Johannes Berg Committed by Richard Weinberger
Browse files

Revert "um: allocate a guard page to helper threads"



This reverts commit ef4459a6 ("um: allocate a guard page to
helper threads"), it's broken in multiple ways:

 1) the free no longer matches the alloc; and

 2) more importantly, the set_memory_ro() causes allocation of
    page tables for the normal memory that doesn't have any,
    and that later causes corruption and crashes (usually but
    not always in vfree()).

We could fix the first bug and use vmalloc() to work around the
second, but set_memory_ro() actually doesn't do anything either
so I'll just revert that as well.

Reported-by: default avatarBenjamin Berg <benjamin@sipsolutions.net>
Fixes: ef4459a6 ("um: allocate a guard page to helper threads")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent f4172b08
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment