Skip to content
Commit 2d77bd61 authored by Florian Faber's avatar Florian Faber Committed by Marc Kleine-Budde
Browse files

can: mscan: mscan_rx_poll(): fix rx path lockup when returning from polling to irq mode



Under load, the RX side of the mscan driver can get stuck while TX still
works. Restarting the interface locks up the system. This behaviour
could be reproduced reliably on a MPC5121e based system.

The patch fixes the return value of the NAPI polling function (should be
the number of processed packets, not constant 1) and the condition under
which IRQs are enabled again after polling is finished.

With this patch, no more lockups were observed over a test period of ten
days.

Fixes: afa17a50 ("net/can: add driver for mscan family & mpc52xx_mscan")
Signed-off-by: default avatarFlorian Faber <faber@faberman.de>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 2f361cd9
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment