Skip to content
Commit 2bc5bab9 authored by Yaliang Wang's avatar Yaliang Wang Committed by Thomas Bogendoerfer
Browse files

MIPS: pgalloc: fix memory leak caused by pgd_free()



pgd page is freed by generic implementation pgd_free() since commit
f9cb654c ("asm-generic: pgalloc: provide generic pgd_free()"),
however, there are scenarios that the system uses more than one page as
the pgd table, in such cases the generic implementation pgd_free() won't
be applicable anymore. For example, when PAGE_SIZE_4KB is enabled and
MIPS_VA_BITS_48 is not enabled in a 64bit system, the macro "PGD_ORDER"
will be set as "1", which will cause allocating two pages as the pgd
table. Well, at the same time, the generic implementation pgd_free()
just free one pgd page, which will result in the memory leak.

The memory leak can be easily detected by executing shell command:
"while true; do ls > /dev/null; grep MemFree /proc/meminfo; done"

Fixes: f9cb654c ("asm-generic: pgalloc: provide generic pgd_free()")
Signed-off-by: default avatarYaliang Wang <Yaliang.Wang@windriver.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 8755d57b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment