Skip to content
Commit 28967c76 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: remove redundant memory barrier from extent_io_tree_release()



The memory barrier at extent_io_tree_release() is redundant. Holding
spin_lock here is not enough to drop the barrier completely.  We only
change the waitqueue of an extent state record while holding the tree
lock - see wait_on_state().

The update to waitqueue state will not become stale because there will
be an spin_unlock/spin_lock sequence between the change and waiting,
this implies a full memory barrier.

So remove the explicit smp_mb() barrier.

Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
[ reword reasoning ]
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent a1c20d15
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment