Skip to content
Unverified Commit 21d2b122 authored by Eric Biggers's avatar Eric Biggers Committed by Maxime Ripard
Browse files

drm/vgem: fix use-after-free when drm_gem_handle_create() fails



If drm_gem_handle_create() fails in vgem_gem_create(), then the
drm_vgem_gem_object is freed twice: once when the reference is dropped
by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy().

This was hit by syzkaller using fault injection.

Fix it by skipping the second free.

Reported-by: default avatar <syzbot+e73f2fb5ed5a5df36d33@syzkaller.appspotmail.com>
Fixes: af33a919

 ("drm/vgem: Enable dmabuf import interfaces")
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarLaura Abbott <labbott@redhat.com>
Signed-off-by: default avatarRodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190226214451.195123-1-ebiggers@kernel.org
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
parent 9e98c678
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment