Skip to content
Commit 16960ac9 authored by Prashant Malani's avatar Prashant Malani Committed by Greg Kroah-Hartman
Browse files

platform/chrome: cros_ec_typec: Check for EC device



commit ffebd905 upstream.

The Type C ACPI device on older Chromebooks is not generated correctly
(since their EC firmware doesn't support the new commands required). In
such cases, the crafted ACPI device doesn't have an EC parent, and it is
therefore not useful (it shouldn't be generated in the first place since
the EC firmware doesn't support any of the Type C commands).

To handle devices which use these older firmware revisions, check for
the parent EC device handle, and fail the probe if it's not found.

Fixes: fdc6b21e ("platform/chrome: Add Type C connector class driver")
Reported-by: default avatarAlyssa Ross <hi@alyssa.is>
Reviewed-by: default avatarTzung-Bi Shih <tzungbi@google.com>
Signed-off-by: default avatarPrashant Malani <pmalani@chromium.org>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarAlyssa Ross <hi@alyssa.is>
Tested-by: default avatarAlyssa Ross <hi@alyssa.is>
Link: https://lore.kernel.org/r/20220126190219.3095419-1-pmalani@chromium.org


Signed-off-by: default avatarBenson Leung <bleung@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e5b68182
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment